From patchwork Sun Jun 24 18:36:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 10484751 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E56256023A for ; Sun, 24 Jun 2018 18:36:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C933E287CC for ; Sun, 24 Jun 2018 18:36:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BDC4F2886B; Sun, 24 Jun 2018 18:36:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2AF55287CC for ; Sun, 24 Jun 2018 18:36:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750997AbeFXSgV (ORCPT ); Sun, 24 Jun 2018 14:36:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbeFXSgV (ORCPT ); Sun, 24 Jun 2018 14:36:21 -0400 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E0DC4A6F3 for ; Sun, 24 Jun 2018 18:36:21 +0000 (UTC) Received: from steved.boston.devel.redhat.com (ovpn-116-218.phx2.redhat.com [10.3.116.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15A12916BB for ; Sun, 24 Jun 2018 18:36:21 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH] nfsdcltrack: getopt_long() fails on a non x86_64 archs Date: Sun, 24 Jun 2018 14:36:19 -0400 Message-Id: <20180624183619.59562-1-steved@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 24 Jun 2018 18:36:21 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP getopt_long() returns an int, not char, which matters on non-x86_64 archs since a char is signed on x86_64 arch but unsigned on other archs. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1551903 Signed-off-by: Steve Dickson --- utils/nfsdcltrack/nfsdcltrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/nfsdcltrack/nfsdcltrack.c b/utils/nfsdcltrack/nfsdcltrack.c index 76b06d2..b45a904 100644 --- a/utils/nfsdcltrack/nfsdcltrack.c +++ b/utils/nfsdcltrack/nfsdcltrack.c @@ -553,7 +553,7 @@ find_cmd(char *cmdname) int main(int argc, char **argv) { - char arg; + int arg; char *val; int rc = 0; char *progname, *cmdarg = NULL;