diff mbox

Revert "gssd.c: Remomved a couple of warning errors"

Message ID 20180627171252.18145-1-steved@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Steve Dickson June 27, 2018, 5:12 p.m. UTC 
This reverts commit 98118f5e382cdeb1acf25370768d5dfdc254ba5d.
Added back the 'm' character which cause memory to be
allocated for the string convertions.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 utils/gssd/gssd.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Steve Dickson June 27, 2018, 6:14 p.m. UTC | #1 
On 06/27/2018 01:12 PM, Steve Dickson wrote:
> This reverts commit 98118f5e382cdeb1acf25370768d5dfdc254ba5d.
> Added back the 'm' character which cause memory to be
> allocated for the string convertions.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... 

steved.

> ---
>  utils/gssd/gssd.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/utils/gssd/gssd.c b/utils/gssd/gssd.c
> index 7b21ee2..2c14e5f 100644
> --- a/utils/gssd/gssd.c
> +++ b/utils/gssd/gssd.c
> @@ -279,16 +279,16 @@ gssd_read_service_info(int dirfd, struct clnt_info *clp)
>  	 * (commit bf19aacecbeebccb2c3d150a8bd9416b7dba81fe)
>  	 */
>  	numfields = fscanf(info,
> -			   "RPC server: %s\n"
> -			   "service: %s (%d) version %d\n"
> -			   "address: %s\n"
> -			   "protocol: %s\n"
> -			   "port: %s\n",
> -			   (char *)&server,
> -			   (char *)&service, &program, &version,
> -			   (char *)&address,
> -			   (char *)&protoname,
> -			   (char *)&port);
> +			   "RPC server: %ms\n"
> +			   "service: %ms (%d) version %d\n"
> +			   "address: %ms\n"
> +			   "protocol: %ms\n"
> +			   "port: %ms\n",
> +			   &server,
> +			   &service, &program, &version,
> +			   &address,
> +			   &protoname,
> +			   &port);
>  
>  
>  	switch (numfields) {
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/utils/gssd/gssd.c b/utils/gssd/gssd.c
index 7b21ee2..2c14e5f 100644
--- a/utils/gssd/gssd.c
+++ b/utils/gssd/gssd.c
@@ -279,16 +279,16 @@  gssd_read_service_info(int dirfd, struct clnt_info *clp)
 	 * (commit bf19aacecbeebccb2c3d150a8bd9416b7dba81fe)
 	 */
 	numfields = fscanf(info,
-			   "RPC server: %s\n"
-			   "service: %s (%d) version %d\n"
-			   "address: %s\n"
-			   "protocol: %s\n"
-			   "port: %s\n",
-			   (char *)&server,
-			   (char *)&service, &program, &version,
-			   (char *)&address,
-			   (char *)&protoname,
-			   (char *)&port);
+			   "RPC server: %ms\n"
+			   "service: %ms (%d) version %d\n"
+			   "address: %ms\n"
+			   "protocol: %ms\n"
+			   "port: %ms\n",
+			   &server,
+			   &service, &program, &version,
+			   &address,
+			   &protoname,
+			   &port);
 
 
 	switch (numfields) {