From patchwork Sat Aug 18 13:24:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 10569547 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88D75139B for ; Sat, 18 Aug 2018 13:25:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 777842A836 for ; Sat, 18 Aug 2018 13:25:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B4662A84D; Sat, 18 Aug 2018 13:25:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2208E2A836 for ; Sat, 18 Aug 2018 13:25:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbeHRQcx (ORCPT ); Sat, 18 Aug 2018 12:32:53 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:45620 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726443AbeHRQcb (ORCPT ); Sat, 18 Aug 2018 12:32:31 -0400 Received: by mail-ed1-f67.google.com with SMTP id s16-v6so5972470edq.12 for ; Sat, 18 Aug 2018 06:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zk17HYVnUW58q1BR+6HYl6kqaH3L5J58mMwPolfdUbw=; b=KMM1Qe5vTRLN7KXhwDFKuGMbnvZcq8zfuoD3P7a00qb5GPO9kRJXvu7ZcumJgECqMi FWGHFCBN6hdMO4IE5uO3MzdbCs36Jc0gSe4yOOATvonVl5jIYxwxogOYIvwYajrrk1y3 VR99P99AWsRR5GUBnNS9IjluXyFZRe8Awbm1Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zk17HYVnUW58q1BR+6HYl6kqaH3L5J58mMwPolfdUbw=; b=qOQeZj3hZRVPkIEXUUzgOlqwIigZHCDnI2Ghdb8RZ9jn3MJZbTqV3IREqkqq1i3wNA xZ8QTjSdw+RwZyyMVX8pRMH7zvXiWLCOEwoTeJ2uU7arr9OpRroQEnBgYgbtBEg4nh6E FqvxMfaYb6L7bVa+r+8FU5rDeY/G02dipe7ZbnVTngriB3cxdq2BEhLD87mFN9pWYQmN DA7P/xIAaAF3lSexaOSyIB/x12A2RhRJUgzkGruGVnjwm0Efk9RkMI4donkII+KDtOdD vK77yj56r0Wq5+vZvFecd5KStnGz1Dtt/9LeFVSJRW9rRChwk9p2abT5tUGEABYgvsAg X6zA== X-Gm-Message-State: AOUpUlGVC36MLdQ/VCntdnZoa25Zaix9KJi+HzKP+Jzz7egrTO56tIOH 2KxT9rXQBy+pqcxjqbYehhh/enG+4Lr1IA== X-Google-Smtp-Source: AA+uWPxhrYDWnSfRi8u/2HjN9SurCTN4ESCd2SzEtbEfGZQw2TQwz8JPqoRglpGUxIzOj3kD8Npxzg== X-Received: by 2002:a50:c181:: with SMTP id m1-v6mr3842455edf.199.1534598687404; Sat, 18 Aug 2018 06:24:47 -0700 (PDT) Received: from prevas-ravi.waoo.dk (dhcp-5-186-114-212.cgn.ip.fibianet.dk. [5.186.114.212]) by smtp.gmail.com with ESMTPSA id a11-v6sm2739032edn.95.2018.08.18.06.24.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Aug 2018 06:24:46 -0700 (PDT) From: Rasmus Villemoes To: linux-nfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Rasmus Villemoes Subject: [PATCH v2 5/8] nfsd: use seq_open_data() in exports_net_open() Date: Sat, 18 Aug 2018 15:24:31 +0200 Message-Id: <20180818132434.9515-5-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20180818132434.9515-1-linux@rasmusvillemoes.dk> References: <20180818132434.9515-1-linux@rasmusvillemoes.dk> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using the seq_open_data() helper, exports_net_open() essentially becomes a oneliner. Signed-off-by: Rasmus Villemoes --- Depends on 1/8 introducing seq_open_data. fs/nfsd/nfsctl.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index d107b4426f7e..483a849b9ce1 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -135,17 +135,9 @@ static const struct file_operations transaction_ops = { static int exports_net_open(struct net *net, struct file *file) { - int err; - struct seq_file *seq; struct nfsd_net *nn = net_generic(net, nfsd_net_id); - err = seq_open(file, &nfs_exports_op); - if (err) - return err; - - seq = file->private_data; - seq->private = nn->svc_export_cache; - return 0; + return seq_open_data(file, &nfs_exports_op, nn->svc_export_cache); } static int exports_proc_open(struct inode *inode, struct file *file)