| Message ID | 20200115160806.99991-1-giulio.benetti@benettiengineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [nfs-utils] locktest: Makefile.am: remove host compiler costraint | expand |
Hi, > Currently locktest can be built only for host because CC_FOR_BUILD is > specified as CC, but this leads to build failure when passing CFLAGS not > available on host gcc(i.e. -mlongcalls) and most of all locktest would > be available on target systems the same way as rpcgen etc. So remove CC > and LIBTOOL assignments. > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Reviewed-by: Petr Vorel <petr.vorel@gmail.com> Tested-by: Petr Vorel <petr.vorel@gmail.com> NOTE: as I understand it's a compilation issue of a tool, so I didn't run rpcgen, I just test various compilation variants for buildroot. Kind regards, Petr > --- > tools/locktest/Makefile.am | 3 --- > 1 file changed, 3 deletions(-) > diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am > index 3156815d..e8914655 100644 > --- a/tools/locktest/Makefile.am > +++ b/tools/locktest/Makefile.am > @@ -1,8 +1,5 @@ > ## Process this file with automake to produce Makefile.in > -CC=$(CC_FOR_BUILD) > -LIBTOOL = @LIBTOOL@ --tag=CC > - > noinst_PROGRAMS = testlk > testlk_SOURCES = testlk.c > testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
Petr, On 1/19/20 2:10 PM, Petr Vorel wrote: > Hi, > >> Currently locktest can be built only for host because CC_FOR_BUILD is >> specified as CC, but this leads to build failure when passing CFLAGS not >> available on host gcc(i.e. -mlongcalls) and most of all locktest would >> be available on target systems the same way as rpcgen etc. So remove CC >> and LIBTOOL assignments. > >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > Reviewed-by: Petr Vorel <petr.vorel@gmail.com> > Tested-by: Petr Vorel <petr.vorel@gmail.com> > NOTE: as I understand it's a compilation issue of a tool, so I didn't run > rpcgen, I just test various compilation variants for buildroot. Just to be clear... Giulio's patch, removing CC and LIBTOOL from the locktest/Makefile.am does allows your cross build to succeed, correct? steved. > > Kind regards, > Petr > >> --- >> tools/locktest/Makefile.am | 3 --- >> 1 file changed, 3 deletions(-) > >> diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am >> index 3156815d..e8914655 100644 >> --- a/tools/locktest/Makefile.am >> +++ b/tools/locktest/Makefile.am >> @@ -1,8 +1,5 @@ >> ## Process this file with automake to produce Makefile.in > >> -CC=$(CC_FOR_BUILD) >> -LIBTOOL = @LIBTOOL@ --tag=CC >> - >> noinst_PROGRAMS = testlk >> testlk_SOURCES = testlk.c >> testlk_CFLAGS=$(CFLAGS_FOR_BUILD) >
Hi Steve, > >> Currently locktest can be built only for host because CC_FOR_BUILD is > >> specified as CC, but this leads to build failure when passing CFLAGS not > >> available on host gcc(i.e. -mlongcalls) and most of all locktest would > >> be available on target systems the same way as rpcgen etc. So remove CC > >> and LIBTOOL assignments. > >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > Reviewed-by: Petr Vorel <petr.vorel@gmail.com> > > Tested-by: Petr Vorel <petr.vorel@gmail.com> > > NOTE: as I understand it's a compilation issue of a tool, so I didn't run > > rpcgen, I just test various compilation variants for buildroot. > Just to be clear... Giulio's patch, removing CC and LIBTOOL from the > locktest/Makefile.am does allows your cross build to succeed, correct? Yes, for buildroot it's ok. I'm just not able to verify Gentoo. > steved. Kind regards, Petr
On 1/22/20 11:13 AM, Petr Vorel wrote: > Hi Steve, > >>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>> be available on target systems the same way as rpcgen etc. So remove CC >>>> and LIBTOOL assignments. > >>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>> Reviewed-by: Petr Vorel <petr.vorel@gmail.com> >>> Tested-by: Petr Vorel <petr.vorel@gmail.com> >>> NOTE: as I understand it's a compilation issue of a tool, so I didn't run >>> rpcgen, I just test various compilation variants for buildroot. >> Just to be clear... Giulio's patch, removing CC and LIBTOOL from the >> locktest/Makefile.am does allows your cross build to succeed, correct? > Yes, for buildroot it's ok. I'm just not able to verify Gentoo. Thanks... Lets cross that path when get there... steved. > >> steved. > > Kind regards, > Petr >
On 1/15/20 11:08 AM, Giulio Benetti wrote: > Currently locktest can be built only for host because CC_FOR_BUILD is > specified as CC, but this leads to build failure when passing CFLAGS not > available on host gcc(i.e. -mlongcalls) and most of all locktest would > be available on target systems the same way as rpcgen etc. So remove CC > and LIBTOOL assignments. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Committed... (tag: nfs-utils-2-4-3-rc6) steved. > --- > tools/locktest/Makefile.am | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am > index 3156815d..e8914655 100644 > --- a/tools/locktest/Makefile.am > +++ b/tools/locktest/Makefile.am > @@ -1,8 +1,5 @@ > ## Process this file with automake to produce Makefile.in > > -CC=$(CC_FOR_BUILD) > -LIBTOOL = @LIBTOOL@ --tag=CC > - > noinst_PROGRAMS = testlk > testlk_SOURCES = testlk.c > testlk_CFLAGS=$(CFLAGS_FOR_BUILD) >
Hi Steve, On 1/22/20 6:56 PM, Steve Dickson wrote: > > > On 1/15/20 11:08 AM, Giulio Benetti wrote: >> Currently locktest can be built only for host because CC_FOR_BUILD is >> specified as CC, but this leads to build failure when passing CFLAGS not >> available on host gcc(i.e. -mlongcalls) and most of all locktest would >> be available on target systems the same way as rpcgen etc. So remove CC >> and LIBTOOL assignments. >> >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > Committed... (tag: nfs-utils-2-4-3-rc6) I've just setup up a Gentoo to try building nfs-utils, I give a try anyway by now, so we should be sure. Best regards
Hi Steve, Petr, On 1/22/20 7:11 PM, Giulio Benetti wrote: > Hi Steve, > > On 1/22/20 6:56 PM, Steve Dickson wrote: >> >> >> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>> Currently locktest can be built only for host because CC_FOR_BUILD is >>> specified as CC, but this leads to build failure when passing CFLAGS not >>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>> be available on target systems the same way as rpcgen etc. So remove CC >>> and LIBTOOL assignments. >>> >>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> Committed... (tag: nfs-utils-2-4-3-rc6) > > I've just setup up a Gentoo to try building nfs-utils, I give a try > anyway by now, so we should be sure. Just tried, it builds correctly on latest Gentoo. Kind regards
On 1/22/20 1:54 PM, Giulio Benetti wrote: > Hi Steve, Petr, > > On 1/22/20 7:11 PM, Giulio Benetti wrote: >> Hi Steve, >> >> On 1/22/20 6:56 PM, Steve Dickson wrote: >>> >>> >>> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>> be available on target systems the same way as rpcgen etc. So remove CC >>>> and LIBTOOL assignments. >>>> >>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>> Committed... (tag: nfs-utils-2-4-3-rc6) >> >> I've just setup up a Gentoo to try building nfs-utils, I give a try >> anyway by now, so we should be sure. > > Just tried, it builds correctly on latest Gentoo. Good to hear... Thank you for your effort!!!! steved.
On 1/22/20 8:30 PM, Steve Dickson wrote: > > > On 1/22/20 1:54 PM, Giulio Benetti wrote: >> Hi Steve, Petr, >> >> On 1/22/20 7:11 PM, Giulio Benetti wrote: >>> Hi Steve, >>> >>> On 1/22/20 6:56 PM, Steve Dickson wrote: >>>> >>>> >>>> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>>> be available on target systems the same way as rpcgen etc. So remove CC >>>>> and LIBTOOL assignments. >>>>> >>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>>> Committed... (tag: nfs-utils-2-4-3-rc6) >>> >>> I've just setup up a Gentoo to try building nfs-utils, I give a try >>> anyway by now, so we should be sure. >> >> Just tried, it builds correctly on latest Gentoo. > Good to hear... Thank you for your effort!!!! It's a pleasure. Btw, when do you plan to release version 2.4.3? I have Buildroot patch ready to be sent. Kinds regards
On 1/22/20 4:55 PM, Giulio Benetti wrote: > On 1/22/20 8:30 PM, Steve Dickson wrote: >> >> >> On 1/22/20 1:54 PM, Giulio Benetti wrote: >>> Hi Steve, Petr, >>> >>> On 1/22/20 7:11 PM, Giulio Benetti wrote: >>>> Hi Steve, >>>> >>>> On 1/22/20 6:56 PM, Steve Dickson wrote: >>>>> >>>>> >>>>> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>>>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>>>> be available on target systems the same way as rpcgen etc. So remove CC >>>>>> and LIBTOOL assignments. >>>>>> >>>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>>>> Committed... (tag: nfs-utils-2-4-3-rc6) >>>> >>>> I've just setup up a Gentoo to try building nfs-utils, I give a try >>>> anyway by now, so we should be sure. >>> >>> Just tried, it builds correctly on latest Gentoo. >> Good to hear... Thank you for your effort!!!! > > It's a pleasure. Btw, when do you plan to release version 2.4.3? > I have Buildroot patch ready to be sent. Go ahead and send it... I'll make a release after that... steved. > > Kinds regards
Hi Steve, On 1/27/20 7:41 PM, Steve Dickson wrote: > > > On 1/22/20 4:55 PM, Giulio Benetti wrote: >> On 1/22/20 8:30 PM, Steve Dickson wrote: >>> >>> >>> On 1/22/20 1:54 PM, Giulio Benetti wrote: >>>> Hi Steve, Petr, >>>> >>>> On 1/22/20 7:11 PM, Giulio Benetti wrote: >>>>> Hi Steve, >>>>> >>>>> On 1/22/20 6:56 PM, Steve Dickson wrote: >>>>>> >>>>>> >>>>>> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>>>>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>>>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>>>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>>>>> be available on target systems the same way as rpcgen etc. So remove CC >>>>>>> and LIBTOOL assignments. >>>>>>> >>>>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>>>>> Committed... (tag: nfs-utils-2-4-3-rc6) >>>>> >>>>> I've just setup up a Gentoo to try building nfs-utils, I give a try >>>>> anyway by now, so we should be sure. >>>> >>>> Just tried, it builds correctly on latest Gentoo. >>> Good to hear... Thank you for your effort!!!! >> >> It's a pleasure. Btw, when do you plan to release version 2.4.3? >> I have Buildroot patch ready to be sent. > Go ahead and send it... I'll make a release after that... You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-) Thank you Best regards
On 1/27/20 1:58 PM, Giulio Benetti wrote: > Hi Steve, > > On 1/27/20 7:41 PM, Steve Dickson wrote: >> >> >> On 1/22/20 4:55 PM, Giulio Benetti wrote: >>> On 1/22/20 8:30 PM, Steve Dickson wrote: >>>> >>>> >>>> On 1/22/20 1:54 PM, Giulio Benetti wrote: >>>>> Hi Steve, Petr, >>>>> >>>>> On 1/22/20 7:11 PM, Giulio Benetti wrote: >>>>>> Hi Steve, >>>>>> >>>>>> On 1/22/20 6:56 PM, Steve Dickson wrote: >>>>>>> >>>>>>> >>>>>>> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>>>>>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>>>>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>>>>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>>>>>> be available on target systems the same way as rpcgen etc. So remove CC >>>>>>>> and LIBTOOL assignments. >>>>>>>> >>>>>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>>>>>> Committed... (tag: nfs-utils-2-4-3-rc6) >>>>>> >>>>>> I've just setup up a Gentoo to try building nfs-utils, I give a try >>>>>> anyway by now, so we should be sure. >>>>> >>>>> Just tried, it builds correctly on latest Gentoo. >>>> Good to hear... Thank you for your effort!!!! >>> >>> It's a pleasure. Btw, when do you plan to release version 2.4.3? >>> I have Buildroot patch ready to be sent. >> Go ahead and send it... I'll make a release after that... > > You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-) Ok... I'll try to get to it sometime this week. steved.
On 1/27/20 8:03 PM, Steve Dickson wrote: > > > On 1/27/20 1:58 PM, Giulio Benetti wrote: >> Hi Steve, >> >> On 1/27/20 7:41 PM, Steve Dickson wrote: >>> >>> >>> On 1/22/20 4:55 PM, Giulio Benetti wrote: >>>> On 1/22/20 8:30 PM, Steve Dickson wrote: >>>>> >>>>> >>>>> On 1/22/20 1:54 PM, Giulio Benetti wrote: >>>>>> Hi Steve, Petr, >>>>>> >>>>>> On 1/22/20 7:11 PM, Giulio Benetti wrote: >>>>>>> Hi Steve, >>>>>>> >>>>>>> On 1/22/20 6:56 PM, Steve Dickson wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>>>>>>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>>>>>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>>>>>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>>>>>>> be available on target systems the same way as rpcgen etc. So remove CC >>>>>>>>> and LIBTOOL assignments. >>>>>>>>> >>>>>>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>>>>>>> Committed... (tag: nfs-utils-2-4-3-rc6) >>>>>>> >>>>>>> I've just setup up a Gentoo to try building nfs-utils, I give a try >>>>>>> anyway by now, so we should be sure. >>>>>> >>>>>> Just tried, it builds correctly on latest Gentoo. >>>>> Good to hear... Thank you for your effort!!!! >>>> >>>> It's a pleasure. Btw, when do you plan to release version 2.4.3? >>>> I have Buildroot patch ready to be sent. >>> Go ahead and send it... I'll make a release after that... >> >> You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-) > Ok... I'll try to get to it sometime this week. Great, thank you! > steved. >
Kindly ping Giulio Benetti Inviato da iPhone > Il giorno 27 gen 2020, alle ore 20:51, Giulio Benetti <giulio.benetti@benettiengineering.com> ha scritto: > > On 1/27/20 8:03 PM, Steve Dickson wrote: >>> On 1/27/20 1:58 PM, Giulio Benetti wrote: >>> Hi Steve, >>> >>> On 1/27/20 7:41 PM, Steve Dickson wrote: >>>> >>>> >>>> On 1/22/20 4:55 PM, Giulio Benetti wrote: >>>>> On 1/22/20 8:30 PM, Steve Dickson wrote: >>>>>> >>>>>> >>>>>> On 1/22/20 1:54 PM, Giulio Benetti wrote: >>>>>>> Hi Steve, Petr, >>>>>>> >>>>>>> On 1/22/20 7:11 PM, Giulio Benetti wrote: >>>>>>>> Hi Steve, >>>>>>>> >>>>>>>> On 1/22/20 6:56 PM, Steve Dickson wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>>>>>>>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>>>>>>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>>>>>>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>>>>>>>> be available on target systems the same way as rpcgen etc. So remove CC >>>>>>>>>> and LIBTOOL assignments. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>>>>>>>> Committed... (tag: nfs-utils-2-4-3-rc6) >>>>>>>> >>>>>>>> I've just setup up a Gentoo to try building nfs-utils, I give a try >>>>>>>> anyway by now, so we should be sure. >>>>>>> >>>>>>> Just tried, it builds correctly on latest Gentoo. >>>>>> Good to hear... Thank you for your effort!!!! >>>>> >>>>> It's a pleasure. Btw, when do you plan to release version 2.4.3? >>>>> I have Buildroot patch ready to be sent. >>>> Go ahead and send it... I'll make a release after that... >>> >>> You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-) >> Ok... I'll try to get to it sometime this week. > > Great, thank you! > >> steved. > > -- > Giulio Benetti > Benetti Engineering sas
On 2/7/20 7:33 AM, Giulio Benetti wrote: > Kindly ping Working on it... ;-) Looking to get some manpages in as well as a few other minor issues... steved. > > Giulio Benetti > Inviato da iPhone > >> Il giorno 27 gen 2020, alle ore 20:51, Giulio Benetti <giulio.benetti@benettiengineering.com> ha scritto: >> >> On 1/27/20 8:03 PM, Steve Dickson wrote: >>>> On 1/27/20 1:58 PM, Giulio Benetti wrote: >>>> Hi Steve, >>>> >>>> On 1/27/20 7:41 PM, Steve Dickson wrote: >>>>> >>>>> >>>>> On 1/22/20 4:55 PM, Giulio Benetti wrote: >>>>>> On 1/22/20 8:30 PM, Steve Dickson wrote: >>>>>>> >>>>>>> >>>>>>> On 1/22/20 1:54 PM, Giulio Benetti wrote: >>>>>>>> Hi Steve, Petr, >>>>>>>> >>>>>>>> On 1/22/20 7:11 PM, Giulio Benetti wrote: >>>>>>>>> Hi Steve, >>>>>>>>> >>>>>>>>> On 1/22/20 6:56 PM, Steve Dickson wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On 1/15/20 11:08 AM, Giulio Benetti wrote: >>>>>>>>>>> Currently locktest can be built only for host because CC_FOR_BUILD is >>>>>>>>>>> specified as CC, but this leads to build failure when passing CFLAGS not >>>>>>>>>>> available on host gcc(i.e. -mlongcalls) and most of all locktest would >>>>>>>>>>> be available on target systems the same way as rpcgen etc. So remove CC >>>>>>>>>>> and LIBTOOL assignments. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >>>>>>>>>> Committed... (tag: nfs-utils-2-4-3-rc6) >>>>>>>>> >>>>>>>>> I've just setup up a Gentoo to try building nfs-utils, I give a try >>>>>>>>> anyway by now, so we should be sure. >>>>>>>> >>>>>>>> Just tried, it builds correctly on latest Gentoo. >>>>>>> Good to hear... Thank you for your effort!!!! >>>>>> >>>>>> It's a pleasure. Btw, when do you plan to release version 2.4.3? >>>>>> I have Buildroot patch ready to be sent. >>>>> Go ahead and send it... I'll make a release after that... >>>> >>>> You can already release, I've meant that I have a patch so send to Buildroot to bump nfs-utils version :-) >>> Ok... I'll try to get to it sometime this week. >> >> Great, thank you! >> >>> steved. >> >> -- >> Giulio Benetti >> Benetti Engineering sas >
diff --git a/tools/locktest/Makefile.am b/tools/locktest/Makefile.am index 3156815d..e8914655 100644 --- a/tools/locktest/Makefile.am +++ b/tools/locktest/Makefile.am @@ -1,8 +1,5 @@ ## Process this file with automake to produce Makefile.in -CC=$(CC_FOR_BUILD) -LIBTOOL = @LIBTOOL@ --tag=CC - noinst_PROGRAMS = testlk testlk_SOURCES = testlk.c testlk_CFLAGS=$(CFLAGS_FOR_BUILD)
Currently locktest can be built only for host because CC_FOR_BUILD is specified as CC, but this leads to build failure when passing CFLAGS not available on host gcc(i.e. -mlongcalls) and most of all locktest would be available on target systems the same way as rpcgen etc. So remove CC and LIBTOOL assignments. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- tools/locktest/Makefile.am | 3 --- 1 file changed, 3 deletions(-)