From patchwork Mon Feb 21 16:08:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Trond Myklebust X-Patchwork-Id: 12753865 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FA1C433EF for ; Mon, 21 Feb 2022 16:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379983AbiBUQP1 (ORCPT ); Mon, 21 Feb 2022 11:15:27 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379987AbiBUQPZ (ORCPT ); Mon, 21 Feb 2022 11:15:25 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F13427B07 for ; Mon, 21 Feb 2022 08:15:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 588BFB81257 for ; Mon, 21 Feb 2022 16:15:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E78ACC340F3 for ; Mon, 21 Feb 2022 16:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645460100; bh=C9FY7JQKBoL8OHLdydu8B5k+jIdHYV7qILcMGC1n+cI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ERRWCUUNXmbuGmudnBvDsGtoi+LFiFkdiH3Oi1Rk35jvZnn6YtQ4LpZB5d6grh4co 2/2yNrXRnhUWlzSxi0Lqdf8s4DrGjfsbyeI8dq9niXhDYR7EYwD7i7aeLo5Wr5+G3k 8l87KeP4kxyaTA1QfiIk1b1aG7h4zO2PSI9rLBJYbCLvfo09poGTIhv5YZotRVDKEF NvY/prWa6YwKE/iNu+xx3mnIDsGTa72P46JQhB1XPtQDtTj/vyfZgVVL9xsAZ7MJUA Pe1QjtcQFsaQ3LtI55F3SQ2WPFqhHsdDxDQ60IkEx6svgVUtPVdL3Pp1joe9oO0lvZ mtpIrIaPK2orw== From: trondmy@kernel.org To: linux-nfs@vger.kernel.org Subject: [PATCH v6 02/13] NFS: Trace lookup revalidation failure Date: Mon, 21 Feb 2022 11:08:40 -0500 Message-Id: <20220221160851.15508-3-trondmy@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221160851.15508-2-trondmy@kernel.org> References: <20220221160851.15508-1-trondmy@kernel.org> <20220221160851.15508-2-trondmy@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust Enable tracing of lookup revalidation failures. Signed-off-by: Trond Myklebust --- fs/nfs/dir.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 8b190c8e4a45..8e750ef34559 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -1474,9 +1474,7 @@ nfs_lookup_revalidate_done(struct inode *dir, struct dentry *dentry, { switch (error) { case 1: - dfprintk(LOOKUPCACHE, "NFS: %s(%pd2) is valid\n", - __func__, dentry); - return 1; + break; case 0: /* * We can't d_drop the root of a disconnected tree: @@ -1485,13 +1483,10 @@ nfs_lookup_revalidate_done(struct inode *dir, struct dentry *dentry, * inodes on unmount and further oopses. */ if (inode && IS_ROOT(dentry)) - return 1; - dfprintk(LOOKUPCACHE, "NFS: %s(%pd2) is invalid\n", - __func__, dentry); - return 0; + error = 1; + break; } - dfprintk(LOOKUPCACHE, "NFS: %s(%pd2) lookup returned error %d\n", - __func__, dentry, error); + trace_nfs_lookup_revalidate_exit(dir, dentry, 0, error); return error; } @@ -1623,9 +1618,7 @@ nfs_do_lookup_revalidate(struct inode *dir, struct dentry *dentry, goto out_bad; trace_nfs_lookup_revalidate_enter(dir, dentry, flags); - error = nfs_lookup_revalidate_dentry(dir, dentry, inode); - trace_nfs_lookup_revalidate_exit(dir, dentry, flags, error); - return error; + return nfs_lookup_revalidate_dentry(dir, dentry, inode); out_valid: return nfs_lookup_revalidate_done(dir, dentry, inode, 1); out_bad: