diff mbox series

[v2] nfsrahead: fix linking while static linking

Message ID 20220809223308.1421081-1-giulio.benetti@benettiengineering.com (mailing list archive)
State Superseded
Headers show
Series [v2] nfsrahead: fix linking while static linking | expand

Commit Message

Giulio Benetti Aug. 9, 2022, 10:33 p.m. UTC
-lmount must preceed -lblkid and to obtain this let's add:
`pkg-config --libs mount`
in place of:
`-lmount`
This ways the library order will always be correct.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* modify pkg-conf to pkg-config
---
 tools/nfsrahead/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Giulio Benetti Aug. 10, 2022, 9:43 p.m. UTC | #1
Hi All,

please drop this patch in favor of upcoming V3. This is not a good way
to use pkg-config with Autotools.

Sorry for the noise

Best regards
diff mbox series

Patch

diff --git a/tools/nfsrahead/Makefile.am b/tools/nfsrahead/Makefile.am
index 845ea0d5..280a2eb4 100644
--- a/tools/nfsrahead/Makefile.am
+++ b/tools/nfsrahead/Makefile.am
@@ -1,6 +1,6 @@ 
 libexec_PROGRAMS = nfsrahead
 nfsrahead_SOURCES = main.c
-nfsrahead_LDFLAGS= -lmount
+nfsrahead_LDFLAGS= `pkg-config --libs mount`
 nfsrahead_LDADD = ../../support/nfs/libnfsconf.la
 
 man5_MANS = nfsrahead.man