diff mbox series

nfs4_getfacl: Initialize acl pointer to NULL

Message ID 20221121191427.132409-1-steved@redhat.com (mailing list archive)
State New, archived
Headers show
Series nfs4_getfacl: Initialize acl pointer to NULL | expand

Commit Message

Steve Dickson Nov. 21, 2022, 7:14 p.m. UTC 
nfs4_getfacl.c: scope_hint: In function 'print_acl_from_path'
nfs4_getfacl.c:168:17: warning[-Wmaybe-uninitialized]:
    'acl' may be used uninitialized in this function

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 nfs4_getfacl/nfs4_getfacl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Steve Dickson Nov. 22, 2022, 1:11 p.m. UTC | #1 
On 11/21/22 2:14 PM, Steve Dickson wrote:
> nfs4_getfacl.c: scope_hint: In function 'print_acl_from_path'
> nfs4_getfacl.c:168:17: warning[-Wmaybe-uninitialized]:
>      'acl' may be used uninitialized in this function
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... (tag: nfs4-acl-tools-0.4.3-rc1)

steved.
> ---
>   nfs4_getfacl/nfs4_getfacl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nfs4_getfacl/nfs4_getfacl.c b/nfs4_getfacl/nfs4_getfacl.c
> index 954cf7e..ddb3005 100644
> --- a/nfs4_getfacl/nfs4_getfacl.c
> +++ b/nfs4_getfacl/nfs4_getfacl.c
> @@ -148,7 +148,7 @@ out:
>   
>   static void print_acl_from_path(const char *fpath, enum acl_type type)
>   {
> -	struct nfs4_acl *acl;
> +	struct nfs4_acl *acl = NULL;
>   
>   	switch (type) {
>   	case ACL_TYPE_ACL:
diff mbox series

Patch

diff --git a/nfs4_getfacl/nfs4_getfacl.c b/nfs4_getfacl/nfs4_getfacl.c
index 954cf7e..ddb3005 100644
--- a/nfs4_getfacl/nfs4_getfacl.c
+++ b/nfs4_getfacl/nfs4_getfacl.c
@@ -148,7 +148,7 @@  out:
 
 static void print_acl_from_path(const char *fpath, enum acl_type type)
 {
-	struct nfs4_acl *acl;
+	struct nfs4_acl *acl = NULL;
 
 	switch (type) {
 	case ACL_TYPE_ACL: