| Message ID | 20231110182104.23039-1-mngyadam@amazon.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | nfsd: fix file memleak on client_opens_relaese | expand |
On Sat, 11 Nov 2023, Mahmoud Adam wrote: > seq_release should be called to free the allocated seq_file > > Cc: stable@vger.kernel.org # v5.3+ > Signed-off-by: Mahmoud Adam <mngyadam@amazon.com> Fixes: 78599c42ae3c ("nfsd4: add file to display list of client's opens") Reviewed-by: NeilBrown <neilb@suse.de> Thanks, NeilBrown > --- > fs/nfsd/nfs4state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 4045c852a450..40415929e2ae 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -2804,7 +2804,7 @@ static int client_opens_release(struct inode *inode, struct file *file) > > /* XXX: alternatively, we could get/drop in seq start/stop */ > drop_client(clp); > - return 0; > + return seq_release(inode, file); > } > > static const struct file_operations client_states_fops = { > -- > 2.40.1 >
On Fri, 2023-11-10 at 19:21 +0100, Mahmoud Adam wrote: > seq_release should be called to free the allocated seq_file > > Cc: stable@vger.kernel.org # v5.3+ > Signed-off-by: Mahmoud Adam <mngyadam@amazon.com> > --- > fs/nfsd/nfs4state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 4045c852a450..40415929e2ae 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -2804,7 +2804,7 @@ static int client_opens_release(struct inode *inode, struct file *file) > > /* XXX: alternatively, we could get/drop in seq start/stop */ > drop_client(clp); > - return 0; > + return seq_release(inode, file); > } > > static const struct file_operations client_states_fops = { > -- > 2.40.1 Reviewed-by: Jeff Layton <jlayton@kernel.org>
> On Nov 10, 2023, at 4:31 PM, NeilBrown <neilb@suse.de> wrote: > > On Sat, 11 Nov 2023, Mahmoud Adam wrote: >> seq_release should be called to free the allocated seq_file >> >> Cc: stable@vger.kernel.org # v5.3+ >> Signed-off-by: Mahmoud Adam <mngyadam@amazon.com> > > Fixes: 78599c42ae3c ("nfsd4: add file to display list of client's opens") Agreed, and pushed to nfsd-fixes. > Reviewed-by: NeilBrown <neilb@suse.de> > > Thanks, > NeilBrown > > >> --- >> fs/nfsd/nfs4state.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c >> index 4045c852a450..40415929e2ae 100644 >> --- a/fs/nfsd/nfs4state.c >> +++ b/fs/nfsd/nfs4state.c >> @@ -2804,7 +2804,7 @@ static int client_opens_release(struct inode *inode, struct file *file) >> >> /* XXX: alternatively, we could get/drop in seq start/stop */ >> drop_client(clp); >> - return 0; >> + return seq_release(inode, file); >> } >> >> static const struct file_operations client_states_fops = { >> -- >> 2.40.1 >> > -- Chuck Lever
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 4045c852a450..40415929e2ae 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -2804,7 +2804,7 @@ static int client_opens_release(struct inode *inode, struct file *file) /* XXX: alternatively, we could get/drop in seq start/stop */ drop_client(clp); - return 0; + return seq_release(inode, file); } static const struct file_operations client_states_fops = {
seq_release should be called to free the allocated seq_file Cc: stable@vger.kernel.org # v5.3+ Signed-off-by: Mahmoud Adam <mngyadam@amazon.com> --- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.40.1