diff mbox series

[2/2] gssapi: fix rpc_gss_seccreate passed in cred

Message ID 20231206213127.55310-2-olga.kornievskaia@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] gssapi: revert commit f5b6e6fdb1e6 | expand

Commit Message

Olga Kornievskaia Dec. 6, 2023, 9:31 p.m. UTC 
From: Olga Kornievskaia <kolga@netapp.com>

Fix rpc_gss_seccreate() usage of the passed in gss credential.

Fixes: 5f1fe4dde861 ("Pass time_req and input_channel_bindings through to init_sec_context")
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
 src/auth_gss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chuck Lever Dec. 7, 2023, 2:26 p.m. UTC | #1 
On Wed, Dec 06, 2023 at 04:31:27PM -0500, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> Fix rpc_gss_seccreate() usage of the passed in gss credential.
> 
> Fixes: 5f1fe4dde861 ("Pass time_req and input_channel_bindings through to init_sec_context")
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


> ---
>  src/auth_gss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/auth_gss.c b/src/auth_gss.c
> index e317664..9d18f96 100644
> --- a/src/auth_gss.c
> +++ b/src/auth_gss.c
> @@ -842,9 +842,9 @@ rpc_gss_seccreate(CLIENT *clnt, char *principal, char *mechanism,
>  	gd->sec = sec;
>  
>  	if (req) {
> -		sec.req_flags = req->req_flags;
> +		gd->sec.req_flags = req->req_flags;
>  		gd->time_req = req->time_req;
> -		sec.cred = req->my_cred;
> +		gd->sec.cred = req->my_cred;
>  		gd->icb = req->input_channel_bindings;
>  	}
>  
> -- 
> 2.39.1
>
Steve Dickson Jan. 3, 2024, 11:39 p.m. UTC | #2 
On 12/6/23 4:31 PM, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> Fix rpc_gss_seccreate() usage of the passed in gss credential.
> 
> Fixes: 5f1fe4dde861 ("Pass time_req and input_channel_bindings through to init_sec_context")
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Committed... (tag: libtirpc-1-3-5-rc1)

steved.

> ---
>   src/auth_gss.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/auth_gss.c b/src/auth_gss.c
> index e317664..9d18f96 100644
> --- a/src/auth_gss.c
> +++ b/src/auth_gss.c
> @@ -842,9 +842,9 @@ rpc_gss_seccreate(CLIENT *clnt, char *principal, char *mechanism,
>   	gd->sec = sec;
>   
>   	if (req) {
> -		sec.req_flags = req->req_flags;
> +		gd->sec.req_flags = req->req_flags;
>   		gd->time_req = req->time_req;
> -		sec.cred = req->my_cred;
> +		gd->sec.cred = req->my_cred;
>   		gd->icb = req->input_channel_bindings;
>   	}
>
diff mbox series

Patch

diff --git a/src/auth_gss.c b/src/auth_gss.c
index e317664..9d18f96 100644
--- a/src/auth_gss.c
+++ b/src/auth_gss.c
@@ -842,9 +842,9 @@  rpc_gss_seccreate(CLIENT *clnt, char *principal, char *mechanism,
 	gd->sec = sec;
 
 	if (req) {
-		sec.req_flags = req->req_flags;
+		gd->sec.req_flags = req->req_flags;
 		gd->time_req = req->time_req;
-		sec.cred = req->my_cred;
+		gd->sec.cred = req->my_cred;
 		gd->icb = req->input_channel_bindings;
 	}