From patchwork Fri Jun 14 03:44:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Snitzer X-Patchwork-Id: 13697847 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CFF31474A3 for ; Fri, 14 Jun 2024 03:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718336688; cv=none; b=bxLN06PjktO4v+XD4dBqBMfB4KFga+VzcWDO4qkg+HBDviyG+7kZ9RDerR2Qs4ZjtwNwDVNu3Xn1V0uJEz6BwLya3ykeJ/bjjZC1WwxAXoI9ymA/TWjj3JtJAm5zuZyB4UrS9nAk1be4BiyTNssv/4akBnODYEgsO6+lSfaSUmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718336688; c=relaxed/simple; bh=+VhZPtOcWDWjNyUpwAsxKx4UiC1ph91VogY+peSTyBk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dMM623x9fXXtmVV3gfzl6IOVW7LhKwGTyRfg2Er7WDDYtJFWnvIKcleiK/PkC8nbh+ymAl1m3JPUg1UtrtdmJGHbrDyt+q/LpXgBC7C2A7QGSjcqhRaPC7OL26JQJuD5hOrIo0hSxP2nxUAMq7KgzuGc8/tsfx1j0Tvzc0DN1V4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LA6Ghs4m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LA6Ghs4m" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0A01C2BBFC; Fri, 14 Jun 2024 03:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718336688; bh=+VhZPtOcWDWjNyUpwAsxKx4UiC1ph91VogY+peSTyBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LA6Ghs4movrgCvDvalPtjedvJqHv5O2VYjUlPVROctw6gL4FZKG0WescT06r395Et C8vrbST+RE+BaniJFh84WZGS4lU9FLrIbZeYUX1fHZkhH2wluOwBDerGulMy88vfIj mOi3Y5li/+1ccNZGtAF3XGnHM8oK6WE2yQFYAexOmCGypveZsjcvPBnP7czY5dR7GE rlqMJhgtFHl6QPMyDvSh4OfGlXXCgELt8Z5Nal5s9NpeE9E6YcuMHstgPzSYw0apjt Fe/9InRx0YbOnNVeFjR/BPuCLtaGAO+L7Mv15/icUzNqoRVPuy+D4ToLx0GpGokTU9 1/J9n1JFGKWrw== From: Mike Snitzer To: linux-nfs@vger.kernel.org Cc: Jeff Layton , Chuck Lever , Trond Myklebust , NeilBrown , snitzer@hammerspace.com Subject: [PATCH v3 15/18] nfsd/localio: manage netns reference in nfsd_open_local_fh Date: Thu, 13 Jun 2024 23:44:23 -0400 Message-ID: <20240614034426.31043-16-snitzer@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240614034426.31043-1-snitzer@kernel.org> References: <20240614034426.31043-1-snitzer@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use maybe_get_net() and put_net() in nfsd_open_local_fh(). Also refactor nfsd_open_local_fh() slightly. Signed-off-by: Mike Snitzer --- fs/nfsd/localio.c | 45 ++++++++++++++++++++++++++------------------- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/fs/nfsd/localio.c b/fs/nfsd/localio.c index 34678bfed579..cdf8e115b33e 100644 --- a/fs/nfsd/localio.c +++ b/fs/nfsd/localio.c @@ -104,18 +104,11 @@ nfsd_local_fakerqst_destroy(struct svc_rqst *rqstp) static struct svc_rqst * nfsd_local_fakerqst_create(struct net *net, struct rpc_clnt *rpc_clnt, - const struct cred *cred) + const struct cred *cred, struct svc_serv *serv) { struct svc_rqst *rqstp; - struct nfsd_net *nn = net_generic(net, nfsd_net_id); int status; - /* FIXME: not running in nfsd context, must get reference on nfsd_serv */ - if (unlikely(!READ_ONCE(nn->nfsd_serv))) { - dprintk("%s: localio denied. Server not running\n", __func__); - return ERR_PTR(-ENXIO); - } - rqstp = kzalloc(sizeof(*rqstp), GFP_KERNEL); if (!rqstp) return ERR_PTR(-ENOMEM); @@ -125,13 +118,13 @@ nfsd_local_fakerqst_create(struct net *net, struct rpc_clnt *rpc_clnt, status = -ENOMEM; goto out_err; } - rqstp->rq_xprt->xpt_net = net; + __set_bit(RQ_SECURE, &rqstp->rq_flags); rqstp->rq_proc = 1; rqstp->rq_vers = 3; rqstp->rq_prot = IPPROTO_TCP; - rqstp->rq_server = nn->nfsd_serv; + rqstp->rq_server = serv; /* Note: we're connecting to ourself, so source addr == peer addr */ rqstp->rq_addrlen = rpc_peeraddr(rpc_clnt, @@ -193,28 +186,44 @@ int nfsd_open_local_fh(struct net *net, const fmode_t fmode, struct file **pfilp) { + struct nfsd_net *nn; const struct cred *save_cred; struct svc_rqst *rqstp; struct svc_fh fh; struct nfsd_file *nf; int status = 0; int mayflags = NFSD_MAY_LOCALIO; + struct svc_serv *serv; __be32 beres; + if (nfs_fh->size > NFS4_FHSIZE) + return -EINVAL; + + /* Not running in nfsd context, must safely get reference on nfsd_serv */ + net = maybe_get_net(net); + if (!net) { + dprintk("%s: localio denied. Server netns not available\n", __func__); + return -ENXIO; + } + nn = net_generic(net, nfsd_net_id); + + serv = READ_ONCE(nn->nfsd_serv); + if (unlikely(!serv)) { + dprintk("%s: localio denied. Server not running\n", __func__); + status = -ENXIO; + goto out_net; + } + /* Save creds before calling into nfsd */ save_cred = get_current_cred(); - rqstp = nfsd_local_fakerqst_create(net, rpc_clnt, cred); + rqstp = nfsd_local_fakerqst_create(net, rpc_clnt, cred, serv); if (IS_ERR(rqstp)) { status = PTR_ERR(rqstp); goto out_revertcred; } /* nfs_fh -> svc_fh */ - if (nfs_fh->size > NFS4_FHSIZE) { - status = -EINVAL; - goto out; - } fh_init(&fh, NFS4_FHSIZE); fh.fh_handle.fh_size = nfs_fh->size; memcpy(fh.fh_handle.fh_raw, nfs_fh->data, nfs_fh->size); @@ -230,17 +239,15 @@ int nfsd_open_local_fh(struct net *net, dprintk("%s: fh_verify failed %d\n", __func__, status); goto out_fh_put; } - *pfilp = get_file(nf->nf_file); - nfsd_file_put(nf); out_fh_put: fh_put(&fh); - -out: nfsd_local_fakerqst_destroy(rqstp); out_revertcred: revert_creds(save_cred); +out_net: + put_net(net); return status; } EXPORT_SYMBOL_GPL(nfsd_open_local_fh);