From patchwork Wed Aug 7 01:58:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Grimes X-Patchwork-Id: 13755584 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9331FC8E0 for ; Wed, 7 Aug 2024 01:59:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722995950; cv=none; b=NatTWfij8rDnz5gaYlNM3CA78DEVu64hatovyn0NG92e9842n4RW68UZz1x3NNi71vS2RH/pgicQ1ydhAF1ymUadr8n6daDi02ZCNisbejTbM8+yhkHc8bLVw65Tir/uY0XwPsNWcjZ0U4KAfkd95RToHadAXKnvzXmUXZd35Wc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722995950; c=relaxed/simple; bh=skMbL4HeJKvCzlDBjA0ZutSBXr/oskyL0uj+M4mKkDM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Svv9TW0NGDtTmO3XYj3ztciIscmgPKJEXecrFbPG0SCoMaL0CyumbbySTFivQg8XQkcSINhEEgyLoat73h1jglOMDn6b4fPx8ustljJGQxk30DBGT4qldi5iY6QuWQdf+rLTIhsFWyAhcIERT9TvSZfjfmqV6TcLUY92Y5WwBf4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ixsystems.com; spf=pass smtp.mailfrom=ixsystems.com; dkim=pass (2048-bit key) header.d=ixsystems.com header.i=@ixsystems.com header.b=grcg18Ef; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ixsystems.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ixsystems.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ixsystems.com header.i=@ixsystems.com header.b="grcg18Ef" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-70d199fb3dfso1029475b3a.3 for ; Tue, 06 Aug 2024 18:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ixsystems.com; s=google; t=1722995948; x=1723600748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SCIPcCSDa/PEPZmF24DhQG9SXXfINSbv01ae/ezl4x0=; b=grcg18EfJ7XF54dE1Z7NxClmHB1pFFxzS8ZHdy++UBdBcHvyZ5U4oezCCs8+ZTDcVl ZHlmXOsxwiX9uUr5mLAaOQ7MMXgw6mLBwVEXGkTwt13xxW8hFVFu7s8X3x4gWoDy9LnP JbnENHg6VzCGwDPoxQy5Z/JDemwNjG6UYFxPbK8Rb04GAifLSFKbKyw+VRbkTAUMmR/t G4kbHxmcFamaC3vEUySCRC4dr9Ngh+IHpXGwJ1T9TZybSkQX5ODkxVg4GHfH2qUuifOD 7hhZfnXkhOV3YyEAuX9FlQD2VnF2wKjIscl7KHV3pwVxi36mPDtCqFTw0CPwqSX6McfX p1JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722995948; x=1723600748; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SCIPcCSDa/PEPZmF24DhQG9SXXfINSbv01ae/ezl4x0=; b=N2gXshKNf0OK4VnLhCUxJE1tTC5pFtFcbOVS20DXbbMR3pyCvXmyHCLThs0n8Z2pwH OhzOP7yo/xL4hRsHbDP6ryPFZb59jkLI+kccSd4hOh4Buv4Y+DdVb37tLgKynrrD2lNv g9wpAj8jlNRn/Y3ZzG/i0GIcHYiGDJZPgxKZZ4PQqaDOIq0j/wZ6UOy/dS3JXJ4R1yui Vl26OeUOejOsaRQ7Z/hn9XUZSLsdNElZY/J63aBzTtaEe9zYi0X23SwmiJwP2O6ATiSp 0Wt+O9H2tg5P97pHpdaMVZ3n+w6E8zgI06zcQnPHNuQgaVQ1eA9SPScf8bHUWyEOVR3z xnMQ== X-Forwarded-Encrypted: i=1; AJvYcCUpeEJxqs+0xMDXkwlpyXgaljszUvyrSi597CT1hK3WvJu3NB+gMOKL3zADSQbhH63ekCFWasi/0lDgmHZGR8Oqv3WnmbLz/lWw X-Gm-Message-State: AOJu0YzI1NvgzEif/qVSSruHBWnWROJnDIYCZKMIr16zl/0lEu1i17Y5 6aSIu1MG8fzqvfGyabR5Ilbbx+WVaIpD/uu2aeFAo2rddN4Faim/pRn0M89t0A== X-Google-Smtp-Source: AGHT+IGgoRPV9X4BvPZbIAPUX5vt+UcpWRpi4UuFqMbgHFTS0xMqohswYbEz1lvorjjyQD99FiV7GQ== X-Received: by 2002:a05:6a21:338b:b0:1c6:ecee:184c with SMTP id adf61e73a8af0-1c6ecee1963mr1205795637.32.1722995947116; Tue, 06 Aug 2024 18:59:07 -0700 (PDT) Received: from localhost.localdomain (c-174-62-124-140.hsd1.ca.comcast.net. [174.62.124.140]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff5905f85csm94345695ad.160.2024.08.06.18.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 18:59:06 -0700 (PDT) From: Mark Grimes To: Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mark Grimes Subject: [PATCH] nfsd: Add quotes to client info 'callback address' Date: Tue, 6 Aug 2024 18:58:34 -0700 Message-Id: <20240807015834.44960-1-mark.grimes@ixsystems.com> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The 'callback address' in client_info_show is output without quotes causing yaml parsers to fail on processing IPv6 addresses. Adding quotes to 'callback address' also matches that used by the 'address' field. Signed-off-by: Mark Grimes Reviewed-by: NeilBrown Reviewed-by: Jeff Layton --- fs/nfsd/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index a20c2c9d7d45..0061ae253f4d 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -2692,7 +2692,7 @@ static int client_info_show(struct seq_file *m, void *v) clp->cl_nii_time.tv_sec, clp->cl_nii_time.tv_nsec); } seq_printf(m, "callback state: %s\n", cb_state2str(clp->cl_cb_state)); - seq_printf(m, "callback address: %pISpc\n", &clp->cl_cb_conn.cb_addr); + seq_printf(m, "callback address: \"%pISpc\"\n", &clp->cl_cb_conn.cb_addr); seq_printf(m, "admin-revoked states: %d\n", atomic_read(&clp->cl_admin_revoked)); drop_client(clp);