diff mbox series

[6.12-rc2,v2,2/7] nfs_common: fix Kconfig for NFS_COMMON_LOCALIO_SUPPORT

Message ID 20241003193504.34640-3-snitzer@kernel.org (mailing list archive)
State New
Headers show
Series NFS LOCALIO: fixes and various cleanups | expand

Commit Message

Mike Snitzer Oct. 3, 2024, 7:34 p.m. UTC
The 'default n' that was in NFS_COMMON_LOCALIO_SUPPORT caused these
extra defaults to be missed:
        default y if NFSD=y || NFS_FS=y
	default m if NFSD=m && NFS_FS=m

Remove the 'default n' for NFS_COMMON_LOCALIO_SUPPORT so that the
correct tristate is selected based on how NFSD and NFS_FS are
configured.  This fixes the reported case where NFS_FS=y but
NFS_COMMON_LOCALIO_SUPPORT=m, it is now correctly set to =y.

In addition, add extra 'depends on NFS_LOCALIO' to
NFS_COMMON_LOCALIO_SUPPORT so that if NFS_LOCALIO isn't set then
NFS_COMMON_LOCALIO_SUPPORT will not be either.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410031944.hMCFY9BO-lkp@intel.com/
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
---
 fs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/fs/Kconfig b/fs/Kconfig
index 24d4e4b419d1..da8ad9aba3e9 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -384,7 +384,7 @@  config NFS_COMMON
 
 config NFS_COMMON_LOCALIO_SUPPORT
 	tristate
-	default n
+	depends on NFS_LOCALIO
 	default y if NFSD=y || NFS_FS=y
 	default m if NFSD=m && NFS_FS=m
 	select SUNRPC