From patchwork Thu Oct 3 19:35:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Snitzer X-Patchwork-Id: 13821464 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6442C1AAE0C for ; Thu, 3 Oct 2024 19:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727984111; cv=none; b=eNV84dzwp+MWseG1ptaZUs9l1VJnbq9ShO8wD2Q74dSt3m9g4z6qno+goJiCfeC5gifmd8S824X3ss3szbSsWlS1HqSsvnhiOAvthp4FSYpxReOI3Iox4zqB2Jj1md2nOICqd5RhFl4MyPQJFaDuAvcLE+ZXY+1PjecBzmgfDCQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727984111; c=relaxed/simple; bh=dO9gozPdQl2OhaD5p9iHUgs5avHYX0qx6mcdaqSzgvU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pGezhtJS5Mj+/Ole2LhjJuUhRXUvZ6YlhImgfRDPYEWBHJ72DuPFUL7qxu/kB7S8Z38goX7aGZP39r/ON78KM6bm9jnvpPKwyTFkXvJQ/dUNtSyfpCJ8LgZxIhdftd0wlswrt8Ha1L1PjoPm23ndV9xct4gak5gU7Us1SPLGuYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZwuIIBN7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZwuIIBN7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7C37C4CEC5; Thu, 3 Oct 2024 19:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727984110; bh=dO9gozPdQl2OhaD5p9iHUgs5avHYX0qx6mcdaqSzgvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZwuIIBN7tZN7x0xAKa/l+UaZYPf7hmftHQYTZPvv3/g8ziN8rOf0QJx/C/Jf18dpD 7osM44OHVEBYWnepTfQVeV78aCfKeFQUvvWxnQUbZZ/3xxV1ORRyoIOo5pFJMM0qwb b1GAhJtpve4caZSLkDUmoFpyESbZnTIr7tqR/jK4uaiBa4g0+WIOxDHZcCqUkz7U2B IcgiHQOkxBRydVumR+O5Q7qZOczIcHN7LdxQ9tNpCEkeBW8t3XFlOx0D3WmLWJ4xZ1 DGQJYer0nTmO7qaeK3Zoit0ZM2I/XfrOqxGztCzprbtOyp+nPgyoPGeCBUh+zxo+dx DD4wBD7f70cZQ== From: Mike Snitzer To: linux-nfs@vger.kernel.org Cc: Jeff Layton , Chuck Lever , Anna Schumaker , Trond Myklebust , NeilBrown , Matthew Wilcox , Christian Brauner Subject: [6.12-rc2 v2 PATCH 4/7] nfs/localio: remove redundant suid/sgid handling Date: Thu, 3 Oct 2024 15:35:01 -0400 Message-ID: <20241003193504.34640-5-snitzer@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20241003193504.34640-1-snitzer@kernel.org> References: <20241003193504.34640-1-snitzer@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Mike Snitzer nfs_writeback_done() will take care of suid/sgid corner case. Signed-off-by: Mike Snitzer --- fs/nfs/localio.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/nfs/localio.c b/fs/nfs/localio.c index d124c265b8fd..88b6658b93fc 100644 --- a/fs/nfs/localio.c +++ b/fs/nfs/localio.c @@ -521,12 +521,7 @@ nfs_local_write_done(struct nfs_local_kiocb *iocb, long status) } if (status < 0) nfs_reset_boot_verifier(inode); - else if (nfs_should_remove_suid(inode)) { - /* Deal with the suid/sgid bit corner case */ - spin_lock(&inode->i_lock); - nfs_set_cache_invalid(inode, NFS_INO_INVALID_MODE); - spin_unlock(&inode->i_lock); - } + nfs_local_pgio_done(hdr, status); }