diff mbox series

nfsd: remove redundant WARN_ON_ONCE in nfsd4_write

Message ID 20250402140619.16565-1-guoqing.jiang@linux.dev (mailing list archive)
State Under Review
Delegated to: Chuck Lever
Headers show
Series nfsd: remove redundant WARN_ON_ONCE in nfsd4_write | expand

Commit Message

Guoqing Jiang April 2, 2025, 2:06 p.m. UTC 
It can be removed since svc_fill_write_vector already has the
same WARN_ON_ONCE.

Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
 fs/nfsd/nfs4proc.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Chuck Lever April 2, 2025, 2:33 p.m. UTC | #1 
From: Chuck Lever <chuck.lever@oracle.com>

On Wed, 02 Apr 2025 22:06:19 +0800, Guoqing Jiang wrote:
> It can be removed since svc_fill_write_vector already has the
> same WARN_ON_ONCE.

Applied to nfsd-testing, thanks!

[1/1] nfsd: remove redundant WARN_ON_ONCE in nfsd4_write
      commit: e20ef2bd835ca8c6e4b835a8e3f7cfa09957b7ab

--
Chuck Lever
diff mbox series

Patch

diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index b397246dae7b..d1be58b557d1 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1228,7 +1228,6 @@  nfsd4_write(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 	write->wr_how_written = write->wr_stable_how;
 
 	nvecs = svc_fill_write_vector(rqstp, &write->wr_payload);
-	WARN_ON_ONCE(nvecs > ARRAY_SIZE(rqstp->rq_vec));
 
 	status = nfsd_vfs_write(rqstp, &cstate->current_fh, nf,
 				write->wr_offset, rqstp->rq_vec, nvecs, &cnt,