diff mbox

SQUASHME: blkmapd: fix pretty_sig short sig endianess agnosticity

Message ID 4CF7C999.4070707@panasas.com (mailing list archive)
State RFC, archived
Delegated to: Trond Myklebust
Headers show

Commit Message

Benny Halevy Dec. 2, 2010, 4:30 p.m. UTC
None
diff mbox

Patch

diff --git a/utils/blkmapd/device-process.c b/utils/blkmapd/device-process.c
index ea8b8ec..0d8705f 100644
--- a/utils/blkmapd/device-process.c
+++ b/utils/blkmapd/device-process.c
@@ -58,10 +58,8 @@  static char *pretty_sig(char *sig, uint32_t siglen)
 		int i;
 
 		sigval = 0;
-		for (i = 0; i < siglen; i++) {
-			sigval <<= 8;
-			sigval += ((unsigned char *)sig)[i];
-		}
+		for (i = 0; i < siglen; i++)
+			sigval |= ((unsigned char *)sig)[i] << (i * 8);
 		sprintf(rs, "0x%0llx", sigval);
 	} else {
 		if (siglen > sizeof rs - 4) {