From patchwork Tue Jun 14 02:16:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mi Jinlong X-Patchwork-Id: 877252 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5E2DOjE031571 for ; Tue, 14 Jun 2011 02:13:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099Ab1FNCNX (ORCPT ); Mon, 13 Jun 2011 22:13:23 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:61662 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750796Ab1FNCNX (ORCPT ); Mon, 13 Jun 2011 22:13:23 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id DFCBB170144; Tue, 14 Jun 2011 10:13:20 +0800 (CST) Received: from mailserver.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id p5E2DKSd013521; Tue, 14 Jun 2011 10:13:20 +0800 Received: from [127.0.0.1] ([10.167.225.24]) by mailserver.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.1FP4) with ESMTP id 2011061410130468-559410 ; Tue, 14 Jun 2011 10:13:04 +0800 Message-ID: <4DF6C46C.9030201@cn.fujitsu.com> Date: Tue, 14 Jun 2011 10:16:12 +0800 From: Mi Jinlong User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Steve Dickson CC: NFS Subject: [PATCH] libexport.a: fix using bad index for loop at cltsetup() X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-06-14 10:13:04, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-06-14 10:13:05, Serialize complete at 2011-06-14 10:13:05 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 14 Jun 2011 02:13:24 +0000 (UTC) At cltsetup(), for address checking, it should use clp's naddr for index, not cltarg's naddr(and it's always zero here). Signed-off-by: Mi Jinlong --- support/export/nfsctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/support/export/nfsctl.c b/support/export/nfsctl.c index f89c644..2950a90 100644 --- a/support/export/nfsctl.c +++ b/support/export/nfsctl.c @@ -78,7 +78,7 @@ cltsetup(struct nfsctl_client *cltarg, nfs_client *clp) str_tolower(cltarg->cl_ident); j = 0; - for (i = 0; i < cltarg->cl_naddr && i < NFSCLNT_ADDRMAX; i++) { + for (i = 0; i < clp->m_naddr && i < NFSCLNT_ADDRMAX; i++) { const struct sockaddr_in *sin = get_addrlist_in(clp, i); if (sin->sin_family == AF_INET) cltarg->cl_addrlist[j++] = sin->sin_addr;