From patchwork Fri Jun 17 20:25:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boaz Harrosh X-Patchwork-Id: 892452 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5HKPrIh025698 for ; Fri, 17 Jun 2011 20:25:53 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754343Ab1FQUZw (ORCPT ); Fri, 17 Jun 2011 16:25:52 -0400 Received: from daytona.panasas.com ([67.152.220.89]:16252 "EHLO daytona.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752970Ab1FQUZv (ORCPT ); Fri, 17 Jun 2011 16:25:51 -0400 Received: from [172.17.33.140] ([172.17.33.140]) by daytona.panasas.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 17 Jun 2011 16:25:51 -0400 Message-ID: <4DFBB84F.2040708@panasas.com> Date: Fri, 17 Jun 2011 16:25:51 -0400 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.38.b3pre.fc13 Thunderbird/3.1.9 MIME-Version: 1.0 To: Benny Halevy , Trond Myklebust , NFS list Subject: [PATCH] pnfs-obj: No longer needed to take an extra ref at add_device X-OriginalArrivalTime: 17 Jun 2011 20:25:51.0349 (UTC) FILETIME=[C0363250:01CC2D2C] Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 17 Jun 2011 20:25:53 +0000 (UTC) Andy's last device_cache patches, already take an extra reference on the newly inserted device_id. So we can remove it from obj-io. Without this patch the device_ids are leaked. Andy's patches are not in Linus tree yet. So I'm not sure if they are scheduled for this Kernel or the next. This patch should be added as part of these. CC: Andy Adamson Signed-off-by: Boaz Harrosh --- fs/nfs/objlayout/objio_osd.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/nfs/objlayout/objio_osd.c b/fs/nfs/objlayout/objio_osd.c index f014038..70272d5 100644 --- a/fs/nfs/objlayout/objio_osd.c +++ b/fs/nfs/objlayout/objio_osd.c @@ -108,7 +108,6 @@ _dev_list_add(const struct nfs_server *nfss, de = n; } - atomic_inc(&de->id_node.ref); return de; }