From patchwork Fri Jun 24 02:22:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boaz Harrosh X-Patchwork-Id: 915262 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5O2N0nY022651 for ; Fri, 24 Jun 2011 02:23:00 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755200Ab1FXCWz (ORCPT ); Thu, 23 Jun 2011 22:22:55 -0400 Received: from natasha.panasas.com ([67.152.220.90]:43225 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216Ab1FXCWz (ORCPT ); Thu, 23 Jun 2011 22:22:55 -0400 Received: from zenyatta.panasas.com (zenyatta.int.panasas.com [172.17.28.63]) by natasha.panasas.com (8.13.1/8.13.1) with ESMTP id p5O2MfPg004628; Thu, 23 Jun 2011 22:22:41 -0400 Received: from [172.17.133.48] (172.17.133.48) by zenyatta.int.panasas.com (172.17.28.63) with Microsoft SMTP Server (TLS) id 14.1.289.1; Thu, 23 Jun 2011 22:22:36 -0400 Message-ID: <4E03F4EA.5050206@panasas.com> Date: Thu, 23 Jun 2011 19:22:34 -0700 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.38.b3pre.fc13 Thunderbird/3.1.9 MIME-Version: 1.0 To: "J. Bruce Fields" CC: Tigran Mkrtchyan , , Trond Myklebust Subject: Re: autoload rpcsec_gss_krb5 References: <20110622213209.GA3010@fieldses.org> <20110623155947.GC8911@fieldses.org> <20110623201117.GB12357@fieldses.org> <20110623203012.GD12357@fieldses.org> In-Reply-To: <20110623203012.GD12357@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 24 Jun 2011 02:23:01 +0000 (UTC) On 06/23/2011 01:30 PM, J. Bruce Fields wrote: > On Thu, Jun 23, 2011 at 04:11:17PM -0400, J. Bruce Fields wrote: >> On Thu, Jun 23, 2011 at 10:06:14PM +0200, Tigran Mkrtchyan wrote: >>> I recall a discussion at connectaton 2010, where Peter Staubach from >>> RedHat ( at that time ) >>> requested a way to disable pNFS without rebuilding the kernel. >>> >>> Probably that's why autoload is not implemented. >> >> Well, autoload *is* implemented, you just have to add an alias command >> to modprobe.conf before it'll work. >> >> And if we embed the alias in the module instead, it will still be >> possible to disable autloading by adding a "backlist " to >> modproble.conf. >> >> So I don't *think* that's the issue, unless I've missed something. > > So can we just do this? (Untested.) > > --b. > > commit 8b3065071b5469c428d70052c80f1df3cb398da6 > Author: J. Bruce Fields > Date: Thu Jun 23 16:15:39 2011 -0400 > > pnfs: simplify pnfs files module autoloading > > Embed the necessary alias into the module rather than waiting for > someone to add it to /etc/modprobe.conf > > Signed-off-by: J. Bruce Fields > > diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c > index 4269088..eb65f82 100644 > --- a/fs/nfs/nfs4filelayout.c > +++ b/fs/nfs/nfs4filelayout.c > @@ -896,5 +896,7 @@ static void __exit nfs4filelayout_exit(void) > pnfs_unregister_layoutdriver(&filelayout_type); > } > > +MODULE_ALIAS("nfs-layouttype4-1"); > + > module_init(nfs4filelayout_init); > module_exit(nfs4filelayout_exit); --- nfs-layouttype4-1 nfs-layouttype4-2 ... Can we use a name here or it must be the number? Thanks Boaz > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/nfs/objlayout/objio_osd.c b/fs/nfs/objlayout/objio_osd.c index 70272d5..dd6a453 100644 --- a/fs/nfs/objlayout/objio_osd.c +++ b/fs/nfs/objlayout/objio_osd.c @@ -1065,5 +1065,7 @@ objlayout_exit(void) __func__); } +MODULE_ALIAS("nfs-layouttype4-2"); + module_init(objlayout_init); module_exit(objlayout_exit);