| Message ID | 4FA345DA4F4AE44899BD2B03EEEC2FA93B54EC@SACEXCMBX04-PRD.hq.netapp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Sorry - company's policy ... What idmap version was this patch used against? The one I have (b701358c) seems to be a bit different (I used latest pull commit ddf343f635fe4440cad528e12f96f28bd50aa099), hence the patch fails again -----Original Message----- From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] Sent: Thursday, August 16, 2012 4:57 PM To: Shai Lazmi Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails On Thu, 2012-08-16 at 16:50 -0700, Shai Lazmi wrote: > MS outlook Don't ever use LookOut for patches. Its "I just reformatted your email" wonder feature breaks all the whitespace. > Best thing is to attached the patch We do not normally use attachments on the mailing list because it makes it impossible to comment the patches inline. Ah well, here goes... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
T24gVGh1LCAyMDEyLTA4LTE2IGF0IDE3OjA3IC0wNzAwLCBTaGFpIExhem1pIHdyb3RlOg0KPiBT b3JyeSAtIGNvbXBhbnkncyBwb2xpY3kgLi4uDQo+IFdoYXQgaWRtYXAgdmVyc2lvbiB3YXMgdGhp cyBwYXRjaCB1c2VkIGFnYWluc3Q/IFRoZSBvbmUgSSBoYXZlIChiNzAxMzU4Yykgc2VlbXMgdG8g YmUgYSBiaXQgZGlmZmVyZW50IChJIHVzZWQgbGF0ZXN0IHB1bGwgY29tbWl0IGRkZjM0M2Y2MzVm ZTQ0NDBjYWQ1MjhlMTJmOTZmMjhiZDUwYWEwOTkpLCBoZW5jZSB0aGUgcGF0Y2ggZmFpbHMgYWdh aW4NCg0KSXQgd29ya3MgZmluZSBmb3IgbWUgYWdhaW5zdCBjb21taXQgZGRmMzQzZjYzNWZlNDQ0 MGNhZDUyOGUxMmY5NmYyOGJkNTBhYTA5OToNCg0KW3Ryb25kbXlAbGFkZSBsaW51eC1uZnNdJCBn aXQgYnJhbmNoIHRlc3QtYXBwbHkgZGRmMzQzZjYzNWZlNDQ0MGNhZDUyOGUxMmY5NmYyOGJkNTBh YTA5OQ0KW3Ryb25kbXlAbGFkZSBsaW51eC1uZnNdJCBnaXQgY2hlY2tvdXQgdGVzdC1hcHBseSAN ClN3aXRjaGVkIHRvIGJyYW5jaCAndGVzdC1hcHBseScNClt0cm9uZG15QGxhZGUgbGludXgtbmZz XSQgZ2l0IGFtIH4vRGVza3RvcC9mb3Jfc2hhaS8wMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0 aW9uLWRhdGEtaWYtdGhlLWlkbWFwLXVwY2FsbC0ucGF0Y2gNCkFwcGx5aW5nOiBORlM6IENsZWFy IGtleSBjb25zdHJ1Y3Rpb24gZGF0YSBpZiB0aGUgaWRtYXAgdXBjYWxsIGZhaWxzDQpbdHJvbmRt eUBsYWRlIGxpbnV4LW5mc10kIGdpdCBhbSB+L0Rlc2t0b3AvZm9yX3NoYWkvMDAwMi1ORlMtcmV0 dXJuLUVOT0tFWS13aGVuLXRoZS11cGNhbGwtZmFpbHMtdG8tbWFwLXRoZS1uLnBhdGNoDQpBcHBs eWluZzogTkZTOiByZXR1cm4gLUVOT0tFWSB3aGVuIHRoZSB1cGNhbGwgZmFpbHMgdG8gbWFwIHRo ZSBuYW1lDQoNCldoYXQgZXJyb3IgbWVzc2FnZXMgYXJlIHlvdSBzZWVpbmc/DQoNCkNoZWVycw0K ICBUcm9uZA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IE15a2xlYnVz dCwgVHJvbmQgW21haWx0bzpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbV0NCj4gU2VudDogVGh1 cnNkYXksIEF1Z3VzdCAxNiwgMjAxMiA0OjU3IFBNDQo+IFRvOiBTaGFpIExhem1pDQo+IENjOiBX aWxsaWFtIERhdWNoeTsgU2NodW1ha2VyLCBCcnlhbjsgbGludXgtbmZzQHZnZXIua2VybmVsLm9y Zw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIDEvMl0gTkZTOiBDbGVhciBrZXkgY29uc3RydWN0aW9u IGRhdGEgaWYgdGhlIGlkbWFwIHVwY2FsbCBmYWlscw0KPiANCj4gT24gVGh1LCAyMDEyLTA4LTE2 IGF0IDE2OjUwIC0wNzAwLCBTaGFpIExhem1pIHdyb3RlOg0KPiA+IE1TIG91dGxvb2sNCj4gDQo+ IERvbid0IGV2ZXIgdXNlIExvb2tPdXQgZm9yIHBhdGNoZXMuIEl0cyAiSSBqdXN0IHJlZm9ybWF0 dGVkIHlvdXIgZW1haWwiDQo+IHdvbmRlciBmZWF0dXJlIGJyZWFrcyBhbGwgdGhlIHdoaXRlc3Bh Y2UuDQo+IA0KPiA+IEJlc3QgdGhpbmcgaXMgdG8gYXR0YWNoZWQgdGhlIHBhdGNoDQo+IA0KPiBX ZSBkbyBub3Qgbm9ybWFsbHkgdXNlIGF0dGFjaG1lbnRzIG9uIHRoZSBtYWlsaW5nIGxpc3QgYmVj YXVzZSBpdCBtYWtlcyBpdCBpbXBvc3NpYmxlIHRvIGNvbW1lbnQgdGhlIHBhdGNoZXMgaW5saW5l LiBBaCB3ZWxsLCBoZXJlIGdvZXMuLi4NCj4gDQo+IC0tDQo+IFRyb25kIE15a2xlYnVzdA0KPiBM aW51eCBORlMgY2xpZW50IG1haW50YWluZXINCj4gDQo+IE5ldEFwcA0KPiBUcm9uZC5NeWtsZWJ1 c3RAbmV0YXBwLmNvbQ0KPiB3d3cubmV0YXBwLmNvbQ0KPiANCj4gDQo+IFRoaXMgbWVzc2FnZSBh bmQgYW55IGF0dGFjaGVkIGRvY3VtZW50cyBjb250YWluIGluZm9ybWF0aW9uIGZyb20gUUxvZ2lj IENvcnBvcmF0aW9uIG9yIGl0cyB3aG9sbHktb3duZWQgc3Vic2lkaWFyaWVzIHRoYXQgbWF5IGJl IGNvbmZpZGVudGlhbC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkIHJlY2lwaWVudCwgeW91 IG1heSBub3QgcmVhZCwgY29weSwgZGlzdHJpYnV0ZSwgb3IgdXNlIHRoaXMgaW5mb3JtYXRpb24u IElmIHlvdSBoYXZlIHJlY2VpdmVkIHRoaXMgdHJhbnNtaXNzaW9uIGluIGVycm9yLCBwbGVhc2Ug bm90aWZ5IHRoZSBzZW5kZXIgaW1tZWRpYXRlbHkgYnkgcmVwbHkgZS1tYWlsIGFuZCB0aGVuIGRl bGV0ZSB0aGlzIG1lc3NhZ2UuDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xp ZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3 Lm5ldGFwcC5jb20NCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
git apply --check 0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch
error: patch failed: fs/nfs/idmap.c:61
error: fs/nfs/idmap.c: patch does not apply
idmap.c
define NFS_UINT_MAXLEN 11
static const struct cred *id_resolver_cache;
static struct key_type key_type_id_resolver_legacy;
struct idmap {
struct rpc_pipe *idmap_pipe;
struct key_construction *idmap_key_cons;
struct mutex idmap_mutex;
};
-----Original Message-----
From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com]
Sent: Thursday, August 16, 2012 5:14 PM
To: Shai Lazmi
Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails
On Thu, 2012-08-16 at 17:07 -0700, Shai Lazmi wrote:
> Sorry - company's policy ...
> What idmap version was this patch used against? The one I have (b701358c) seems to be a bit different (I used latest pull commit ddf343f635fe4440cad528e12f96f28bd50aa099), hence the patch fails again
It works fine for me against commit ddf343f635fe4440cad528e12f96f28bd50aa099:
[trondmy@lade linux-nfs]$ git branch test-apply ddf343f635fe4440cad528e12f96f28bd50aa099
[trondmy@lade linux-nfs]$ git checkout test-apply
Switched to branch 'test-apply'
[trondmy@lade linux-nfs]$ git am ~/Desktop/for_shai/0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch
Applying: NFS: Clear key construction data if the idmap upcall fails
[trondmy@lade linux-nfs]$ git am ~/Desktop/for_shai/0002-NFS-return-ENOKEY-when-the-upcall-fails-to-map-the-n.patch
Applying: NFS: return -ENOKEY when the upcall fails to map the name
What error messages are you seeing?
Cheers
Trond
> -----Original Message-----
> From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com]
> Sent: Thursday, August 16, 2012 4:57 PM
> To: Shai Lazmi
> Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org
> Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails
>
> On Thu, 2012-08-16 at 16:50 -0700, Shai Lazmi wrote:
> > MS outlook
>
> Don't ever use LookOut for patches. Its "I just reformatted your email"
> wonder feature breaks all the whitespace.
>
> > Best thing is to attached the patch
>
> We do not normally use attachments on the mailing list because it makes it impossible to comment the patches inline. Ah well, here goes...
>
> --
> Trond Myklebust
> Linux NFS client maintainer
>
> NetApp
> Trond.Myklebust@netapp.com
> www.netapp.com
>
>
> This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
On Thu, 2012-08-16 at 17:15 -0700, Shai Lazmi wrote: > git apply --check 0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch > error: patch failed: fs/nfs/idmap.c:61 > error: fs/nfs/idmap.c: patch does not apply > > > idmap.c > define NFS_UINT_MAXLEN 11 > > static const struct cred *id_resolver_cache; > static struct key_type key_type_id_resolver_legacy; > > struct idmap { > struct rpc_pipe *idmap_pipe; > struct key_construction *idmap_key_cons; > struct mutex idmap_mutex; > }; That's how it should more or less look after applying the patch. I'm guessing that one of your previous attempts has partially worked, and has left your checked out git tree in a "dirty" state. Please try the following: $ git reset --hard HEAD $ git apply --check 0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch $ git apply --check 0002-NFS-return-ENOKEY-when-the-upcall-fails-to-map-the-n.patch > > -----Original Message----- > From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] > Sent: Thursday, August 16, 2012 5:14 PM > To: Shai Lazmi > Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org > Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails > > On Thu, 2012-08-16 at 17:07 -0700, Shai Lazmi wrote: > > Sorry - company's policy ... > > What idmap version was this patch used against? The one I have (b701358c) seems to be a bit different (I used latest pull commit ddf343f635fe4440cad528e12f96f28bd50aa099), hence the patch fails again > > It works fine for me against commit ddf343f635fe4440cad528e12f96f28bd50aa099: > > [trondmy@lade linux-nfs]$ git branch test-apply ddf343f635fe4440cad528e12f96f28bd50aa099 > [trondmy@lade linux-nfs]$ git checkout test-apply > Switched to branch 'test-apply' > [trondmy@lade linux-nfs]$ git am ~/Desktop/for_shai/0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch > Applying: NFS: Clear key construction data if the idmap upcall fails > [trondmy@lade linux-nfs]$ git am ~/Desktop/for_shai/0002-NFS-return-ENOKEY-when-the-upcall-fails-to-map-the-n.patch > Applying: NFS: return -ENOKEY when the upcall fails to map the name > > What error messages are you seeing? > > Cheers > Trond > > > -----Original Message----- > > From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] > > Sent: Thursday, August 16, 2012 4:57 PM > > To: Shai Lazmi > > Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org > > Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails > > > > On Thu, 2012-08-16 at 16:50 -0700, Shai Lazmi wrote: > > > MS outlook > > > > Don't ever use LookOut for patches. Its "I just reformatted your email" > > wonder feature breaks all the whitespace. > > > > > Best thing is to attached the patch > > > > We do not normally use attachments on the mailing list because it makes it impossible to comment the patches inline. Ah well, here goes... > > > > -- > > Trond Myklebust > > Linux NFS client maintainer > > > > NetApp > > Trond.Myklebust@netapp.com > > www.netapp.com > > > > > > This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. > > -- > Trond Myklebust > Linux NFS client maintainer > > NetApp > Trond.Myklebust@netapp.com > www.netapp.com > > > This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com
SSd2ZSBsb29rZWQgYXQgdGhlIHJlcG8gKGh0dHA6Ly9naXQua2VybmVsLm9yZy8/cD1saW51eC9r ZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4LmdpdDthPWJsb2I7Zj1mcy9uZnMvaWRtYXAuYztoPWI3 MDEzNThjMzljMzUxZDA2MTNkMWRiMjllYmNmMzgyY2E4Y2IwYTY7aGI9ZGRmMzQzZjYzNWZlNDQ0 MGNhZDUyOGUxMmY5NmYyOGJkNTBhYTA5OSksIHNlZW1zIGp1c3QgbGlrZSB3aGF0IEkgaGF2ZQ0K Q2FuIGl0IGJlIGFscmVhZHkgY2hhbmdlZCBvbiB0aGUgdHJlZT8NCg0KLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCkZyb206IE15a2xlYnVzdCwgVHJvbmQgW21haWx0bzpUcm9uZC5NeWtsZWJ1 c3RAbmV0YXBwLmNvbV0NClNlbnQ6IFRodXJzZGF5LCBBdWd1c3QgMTYsIDIwMTIgNToyMiBQTQ0K VG86IFNoYWkgTGF6bWkNCkNjOiBXaWxsaWFtIERhdWNoeTsgU2NodW1ha2VyLCBCcnlhbjsgbGlu dXgtbmZzQHZnZXIua2VybmVsLm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIE5GUzogQ2xl YXIga2V5IGNvbnN0cnVjdGlvbiBkYXRhIGlmIHRoZSBpZG1hcCB1cGNhbGwgZmFpbHMNCg0KT24g VGh1LCAyMDEyLTA4LTE2IGF0IDE3OjE1IC0wNzAwLCBTaGFpIExhem1pIHdyb3RlOg0KPiBnaXQg YXBwbHkgLS1jaGVjayAwMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0aW9uLWRhdGEtaWYtdGhl LWlkbWFwLXVwY2FsbC0ucGF0Y2gNCj4gZXJyb3I6IHBhdGNoIGZhaWxlZDogZnMvbmZzL2lkbWFw LmM6NjENCj4gZXJyb3I6IGZzL25mcy9pZG1hcC5jOiBwYXRjaCBkb2VzIG5vdCBhcHBseQ0KPg0K Pg0KPiBpZG1hcC5jDQo+IGRlZmluZSBORlNfVUlOVF9NQVhMRU4gMTENCj4NCj4gc3RhdGljIGNv bnN0IHN0cnVjdCBjcmVkICppZF9yZXNvbHZlcl9jYWNoZTsNCj4gc3RhdGljIHN0cnVjdCBrZXlf dHlwZSBrZXlfdHlwZV9pZF9yZXNvbHZlcl9sZWdhY3k7DQo+DQo+IHN0cnVjdCBpZG1hcCB7DQo+ ICAgICAgICAgc3RydWN0IHJwY19waXBlICAgICAgICAgKmlkbWFwX3BpcGU7DQo+ICAgICAgICAg c3RydWN0IGtleV9jb25zdHJ1Y3Rpb24gKmlkbWFwX2tleV9jb25zOw0KPiAgICAgICAgIHN0cnVj dCBtdXRleCAgICAgICAgICAgIGlkbWFwX211dGV4Ow0KPiB9Ow0KDQpUaGF0J3MgaG93IGl0IHNo b3VsZCBtb3JlIG9yIGxlc3MgbG9vayBhZnRlciBhcHBseWluZyB0aGUgcGF0Y2guIEknbQ0KZ3Vl c3NpbmcgdGhhdCBvbmUgb2YgeW91ciBwcmV2aW91cyBhdHRlbXB0cyBoYXMgcGFydGlhbGx5IHdv cmtlZCwgYW5kDQpoYXMgbGVmdCB5b3VyIGNoZWNrZWQgb3V0IGdpdCB0cmVlIGluIGEgImRpcnR5 IiBzdGF0ZS4NCg0KUGxlYXNlIHRyeSB0aGUgZm9sbG93aW5nOg0KDQokIGdpdCByZXNldCAtLWhh cmQgSEVBRA0KJCBnaXQgYXBwbHkgLS1jaGVjayAwMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0 aW9uLWRhdGEtaWYtdGhlLWlkbWFwLXVwY2FsbC0ucGF0Y2gNCiQgZ2l0IGFwcGx5IC0tY2hlY2sg MDAwMi1ORlMtcmV0dXJuLUVOT0tFWS13aGVuLXRoZS11cGNhbGwtZmFpbHMtdG8tbWFwLXRoZS1u LnBhdGNoDQoNCg0KPg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBNeWts ZWJ1c3QsIFRyb25kIFttYWlsdG86VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb21dDQo+IFNlbnQ6 IFRodXJzZGF5LCBBdWd1c3QgMTYsIDIwMTIgNToxNCBQTQ0KPiBUbzogU2hhaSBMYXptaQ0KPiBD YzogV2lsbGlhbSBEYXVjaHk7IFNjaHVtYWtlciwgQnJ5YW47IGxpbnV4LW5mc0B2Z2VyLmtlcm5l bC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIE5GUzogQ2xlYXIga2V5IGNvbnN0cnVj dGlvbiBkYXRhIGlmIHRoZSBpZG1hcCB1cGNhbGwgZmFpbHMNCj4NCj4gT24gVGh1LCAyMDEyLTA4 LTE2IGF0IDE3OjA3IC0wNzAwLCBTaGFpIExhem1pIHdyb3RlOg0KPiA+IFNvcnJ5IC0gY29tcGFu eSdzIHBvbGljeSAuLi4NCj4gPiBXaGF0IGlkbWFwIHZlcnNpb24gd2FzIHRoaXMgcGF0Y2ggdXNl ZCBhZ2FpbnN0PyBUaGUgb25lIEkgaGF2ZSAoYjcwMTM1OGMpIHNlZW1zIHRvIGJlIGEgYml0IGRp ZmZlcmVudCAoSSB1c2VkIGxhdGVzdCBwdWxsIGNvbW1pdCBkZGYzNDNmNjM1ZmU0NDQwY2FkNTI4 ZTEyZjk2ZjI4YmQ1MGFhMDk5KSwgaGVuY2UgdGhlIHBhdGNoIGZhaWxzIGFnYWluDQo+DQo+IEl0 IHdvcmtzIGZpbmUgZm9yIG1lIGFnYWluc3QgY29tbWl0IGRkZjM0M2Y2MzVmZTQ0NDBjYWQ1Mjhl MTJmOTZmMjhiZDUwYWEwOTk6DQo+DQo+IFt0cm9uZG15QGxhZGUgbGludXgtbmZzXSQgZ2l0IGJy YW5jaCB0ZXN0LWFwcGx5IGRkZjM0M2Y2MzVmZTQ0NDBjYWQ1MjhlMTJmOTZmMjhiZDUwYWEwOTkN Cj4gW3Ryb25kbXlAbGFkZSBsaW51eC1uZnNdJCBnaXQgY2hlY2tvdXQgdGVzdC1hcHBseQ0KPiBT d2l0Y2hlZCB0byBicmFuY2ggJ3Rlc3QtYXBwbHknDQo+IFt0cm9uZG15QGxhZGUgbGludXgtbmZz XSQgZ2l0IGFtIH4vRGVza3RvcC9mb3Jfc2hhaS8wMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0 aW9uLWRhdGEtaWYtdGhlLWlkbWFwLXVwY2FsbC0ucGF0Y2gNCj4gQXBwbHlpbmc6IE5GUzogQ2xl YXIga2V5IGNvbnN0cnVjdGlvbiBkYXRhIGlmIHRoZSBpZG1hcCB1cGNhbGwgZmFpbHMNCj4gW3Ry b25kbXlAbGFkZSBsaW51eC1uZnNdJCBnaXQgYW0gfi9EZXNrdG9wL2Zvcl9zaGFpLzAwMDItTkZT LXJldHVybi1FTk9LRVktd2hlbi10aGUtdXBjYWxsLWZhaWxzLXRvLW1hcC10aGUtbi5wYXRjaA0K PiBBcHBseWluZzogTkZTOiByZXR1cm4gLUVOT0tFWSB3aGVuIHRoZSB1cGNhbGwgZmFpbHMgdG8g bWFwIHRoZSBuYW1lDQo+DQo+IFdoYXQgZXJyb3IgbWVzc2FnZXMgYXJlIHlvdSBzZWVpbmc/DQo+ DQo+IENoZWVycw0KPiAgIFRyb25kDQo+DQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0N Cj4gPiBGcm9tOiBNeWtsZWJ1c3QsIFRyb25kIFttYWlsdG86VHJvbmQuTXlrbGVidXN0QG5ldGFw cC5jb21dDQo+ID4gU2VudDogVGh1cnNkYXksIEF1Z3VzdCAxNiwgMjAxMiA0OjU3IFBNDQo+ID4g VG86IFNoYWkgTGF6bWkNCj4gPiBDYzogV2lsbGlhbSBEYXVjaHk7IFNjaHVtYWtlciwgQnJ5YW47 IGxpbnV4LW5mc0B2Z2VyLmtlcm5lbC5vcmcNCj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDEvMl0g TkZTOiBDbGVhciBrZXkgY29uc3RydWN0aW9uIGRhdGEgaWYgdGhlIGlkbWFwIHVwY2FsbCBmYWls cw0KPiA+DQo+ID4gT24gVGh1LCAyMDEyLTA4LTE2IGF0IDE2OjUwIC0wNzAwLCBTaGFpIExhem1p IHdyb3RlOg0KPiA+ID4gTVMgb3V0bG9vaw0KPiA+DQo+ID4gRG9uJ3QgZXZlciB1c2UgTG9va091 dCBmb3IgcGF0Y2hlcy4gSXRzICJJIGp1c3QgcmVmb3JtYXR0ZWQgeW91ciBlbWFpbCINCj4gPiB3 b25kZXIgZmVhdHVyZSBicmVha3MgYWxsIHRoZSB3aGl0ZXNwYWNlLg0KPiA+DQo+ID4gPiBCZXN0 IHRoaW5nIGlzIHRvIGF0dGFjaGVkIHRoZSBwYXRjaA0KPiA+DQo+ID4gV2UgZG8gbm90IG5vcm1h bGx5IHVzZSBhdHRhY2htZW50cyBvbiB0aGUgbWFpbGluZyBsaXN0IGJlY2F1c2UgaXQgbWFrZXMg aXQgaW1wb3NzaWJsZSB0byBjb21tZW50IHRoZSBwYXRjaGVzIGlubGluZS4gQWggd2VsbCwgaGVy ZSBnb2VzLi4uDQo+ID4NCj4gPiAtLQ0KPiA+IFRyb25kIE15a2xlYnVzdA0KPiA+IExpbnV4IE5G UyBjbGllbnQgbWFpbnRhaW5lcg0KPiA+DQo+ID4gTmV0QXBwDQo+ID4gVHJvbmQuTXlrbGVidXN0 QG5ldGFwcC5jb20NCj4gPiB3d3cubmV0YXBwLmNvbQ0KPiA+DQo+ID4NCj4gPiBUaGlzIG1lc3Nh Z2UgYW5kIGFueSBhdHRhY2hlZCBkb2N1bWVudHMgY29udGFpbiBpbmZvcm1hdGlvbiBmcm9tIFFM b2dpYyBDb3Jwb3JhdGlvbiBvciBpdHMgd2hvbGx5LW93bmVkIHN1YnNpZGlhcmllcyB0aGF0IG1h eSBiZSBjb25maWRlbnRpYWwuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZCByZWNpcGllbnQs IHlvdSBtYXkgbm90IHJlYWQsIGNvcHksIGRpc3RyaWJ1dGUsIG9yIHVzZSB0aGlzIGluZm9ybWF0 aW9uLiBJZiB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIHRyYW5zbWlzc2lvbiBpbiBlcnJvciwgcGxl YXNlIG5vdGlmeSB0aGUgc2VuZGVyIGltbWVkaWF0ZWx5IGJ5IHJlcGx5IGUtbWFpbCBhbmQgdGhl biBkZWxldGUgdGhpcyBtZXNzYWdlLg0KPg0KPiAtLQ0KPiBUcm9uZCBNeWtsZWJ1c3QNCj4gTGlu dXggTkZTIGNsaWVudCBtYWludGFpbmVyDQo+DQo+IE5ldEFwcA0KPiBUcm9uZC5NeWtsZWJ1c3RA bmV0YXBwLmNvbQ0KPiB3d3cubmV0YXBwLmNvbQ0KPg0KPg0KPiBUaGlzIG1lc3NhZ2UgYW5kIGFu eSBhdHRhY2hlZCBkb2N1bWVudHMgY29udGFpbiBpbmZvcm1hdGlvbiBmcm9tIFFMb2dpYyBDb3Jw b3JhdGlvbiBvciBpdHMgd2hvbGx5LW93bmVkIHN1YnNpZGlhcmllcyB0aGF0IG1heSBiZSBjb25m aWRlbnRpYWwuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZCByZWNpcGllbnQsIHlvdSBtYXkg bm90IHJlYWQsIGNvcHksIGRpc3RyaWJ1dGUsIG9yIHVzZSB0aGlzIGluZm9ybWF0aW9uLiBJZiB5 b3UgaGF2ZSByZWNlaXZlZCB0aGlzIHRyYW5zbWlzc2lvbiBpbiBlcnJvciwgcGxlYXNlIG5vdGlm eSB0aGUgc2VuZGVyIGltbWVkaWF0ZWx5IGJ5IHJlcGx5IGUtbWFpbCBhbmQgdGhlbiBkZWxldGUg dGhpcyBtZXNzYWdlLg0KDQotLQ0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1h aW50YWluZXINCg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFw cC5jb20NCg0KDQpUaGlzIG1lc3NhZ2UgYW5kIGFueSBhdHRhY2hlZCBkb2N1bWVudHMgY29udGFp biBpbmZvcm1hdGlvbiBmcm9tIFFMb2dpYyBDb3Jwb3JhdGlvbiBvciBpdHMgd2hvbGx5LW93bmVk IHN1YnNpZGlhcmllcyB0aGF0IG1heSBiZSBjb25maWRlbnRpYWwuIElmIHlvdSBhcmUgbm90IHRo ZSBpbnRlbmRlZCByZWNpcGllbnQsIHlvdSBtYXkgbm90IHJlYWQsIGNvcHksIGRpc3RyaWJ1dGUs IG9yIHVzZSB0aGlzIGluZm9ybWF0aW9uLiBJZiB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIHRyYW5z bWlzc2lvbiBpbiBlcnJvciwgcGxlYXNlIG5vdGlmeSB0aGUgc2VuZGVyIGltbWVkaWF0ZWx5IGJ5 IHJlcGx5IGUtbWFpbCBhbmQgdGhlbiBkZWxldGUgdGhpcyBtZXNzYWdlLg0K -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
T24gVGh1LCAyMDEyLTA4LTE2IGF0IDE4OjA5IC0wNzAwLCBTaGFpIExhem1pIHdyb3RlOg0KPiBJ J3ZlIGxvb2tlZCBhdCB0aGUgcmVwbyAoaHR0cDovL2dpdC5rZXJuZWwub3JnLz9wPWxpbnV4L2tl cm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0O2E9YmxvYjtmPWZzL25mcy9pZG1hcC5jO2g9Yjcw MTM1OGMzOWMzNTFkMDYxM2QxZGIyOWViY2YzODJjYThjYjBhNjtoYj1kZGYzNDNmNjM1ZmU0NDQw Y2FkNTI4ZTEyZjk2ZjI4YmQ1MGFhMDk5KSwgc2VlbXMganVzdCBsaWtlIHdoYXQgSSBoYXZlDQo+ IENhbiBpdCBiZSBhbHJlYWR5IGNoYW5nZWQgb24gdGhlIHRyZWU/DQoNCk5vLiBJdCBoYXNuJ3Qg YmVlbiBtZXJnZWQgdXBzdHJlYW0geWV0Lg0KDQpIb3dldmVyLCBJJ3ZlIG5vdyBwdXNoZWQgdGhl IHBhdGNoZXMgdXBzdHJlYW0gdG8gdGhlIE5GUyBidWdmaXhlcw0KYnJhbmNoLiBJbnN0ZWFkIG9m IGFwcGx5aW5nIHRoZSBwYXRjaGVzLCBwZXJoYXBzIHlvdSBjb3VsZCBqdXN0IHB1bGwgdGhlDQpm dWxsIHNldCBvZiBORlMgY2xpZW50IGJ1Z2ZpeGVzIGJ5IGRvaW5nDQoNCmdpdCBwdWxsIGdpdDov L2dpdC5saW51eC1uZnMub3JnL3Byb2plY3RzL3Ryb25kbXkvbGludXgtbmZzLmdpdCBidWdmaXhl cw0KDQpDaGVlcnMNCiAgVHJvbmQNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBG cm9tOiBNeWtsZWJ1c3QsIFRyb25kIFttYWlsdG86VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb21d DQo+IFNlbnQ6IFRodXJzZGF5LCBBdWd1c3QgMTYsIDIwMTIgNToyMiBQTQ0KPiBUbzogU2hhaSBM YXptaQ0KPiBDYzogV2lsbGlhbSBEYXVjaHk7IFNjaHVtYWtlciwgQnJ5YW47IGxpbnV4LW5mc0B2 Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzJdIE5GUzogQ2xlYXIga2V5 IGNvbnN0cnVjdGlvbiBkYXRhIGlmIHRoZSBpZG1hcCB1cGNhbGwgZmFpbHMNCj4gDQo+IE9uIFRo dSwgMjAxMi0wOC0xNiBhdCAxNzoxNSAtMDcwMCwgU2hhaSBMYXptaSB3cm90ZToNCj4gPiBnaXQg YXBwbHkgLS1jaGVjayAwMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0aW9uLWRhdGEtaWYtdGhl LWlkbWFwLXVwY2FsbC0ucGF0Y2gNCj4gPiBlcnJvcjogcGF0Y2ggZmFpbGVkOiBmcy9uZnMvaWRt YXAuYzo2MQ0KPiA+IGVycm9yOiBmcy9uZnMvaWRtYXAuYzogcGF0Y2ggZG9lcyBub3QgYXBwbHkN Cj4gPg0KPiA+DQo+ID4gaWRtYXAuYw0KPiA+IGRlZmluZSBORlNfVUlOVF9NQVhMRU4gMTENCj4g Pg0KPiA+IHN0YXRpYyBjb25zdCBzdHJ1Y3QgY3JlZCAqaWRfcmVzb2x2ZXJfY2FjaGU7DQo+ID4g c3RhdGljIHN0cnVjdCBrZXlfdHlwZSBrZXlfdHlwZV9pZF9yZXNvbHZlcl9sZWdhY3k7DQo+ID4N Cj4gPiBzdHJ1Y3QgaWRtYXAgew0KPiA+ICAgICAgICAgc3RydWN0IHJwY19waXBlICAgICAgICAg KmlkbWFwX3BpcGU7DQo+ID4gICAgICAgICBzdHJ1Y3Qga2V5X2NvbnN0cnVjdGlvbiAqaWRtYXBf a2V5X2NvbnM7DQo+ID4gICAgICAgICBzdHJ1Y3QgbXV0ZXggICAgICAgICAgICBpZG1hcF9tdXRl eDsNCj4gPiB9Ow0KPiANCj4gVGhhdCdzIGhvdyBpdCBzaG91bGQgbW9yZSBvciBsZXNzIGxvb2sg YWZ0ZXIgYXBwbHlpbmcgdGhlIHBhdGNoLiBJJ20NCj4gZ3Vlc3NpbmcgdGhhdCBvbmUgb2YgeW91 ciBwcmV2aW91cyBhdHRlbXB0cyBoYXMgcGFydGlhbGx5IHdvcmtlZCwgYW5kDQo+IGhhcyBsZWZ0 IHlvdXIgY2hlY2tlZCBvdXQgZ2l0IHRyZWUgaW4gYSAiZGlydHkiIHN0YXRlLg0KPiANCj4gUGxl YXNlIHRyeSB0aGUgZm9sbG93aW5nOg0KPiANCj4gJCBnaXQgcmVzZXQgLS1oYXJkIEhFQUQNCj4g JCBnaXQgYXBwbHkgLS1jaGVjayAwMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0aW9uLWRhdGEt aWYtdGhlLWlkbWFwLXVwY2FsbC0ucGF0Y2gNCj4gJCBnaXQgYXBwbHkgLS1jaGVjayAwMDAyLU5G Uy1yZXR1cm4tRU5PS0VZLXdoZW4tdGhlLXVwY2FsbC1mYWlscy10by1tYXAtdGhlLW4ucGF0Y2gN Cj4gDQo+IA0KPiA+DQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBN eWtsZWJ1c3QsIFRyb25kIFttYWlsdG86VHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb21dDQo+ID4g U2VudDogVGh1cnNkYXksIEF1Z3VzdCAxNiwgMjAxMiA1OjE0IFBNDQo+ID4gVG86IFNoYWkgTGF6 bWkNCj4gPiBDYzogV2lsbGlhbSBEYXVjaHk7IFNjaHVtYWtlciwgQnJ5YW47IGxpbnV4LW5mc0B2 Z2VyLmtlcm5lbC5vcmcNCj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIDEvMl0gTkZTOiBDbGVhciBr ZXkgY29uc3RydWN0aW9uIGRhdGEgaWYgdGhlIGlkbWFwIHVwY2FsbCBmYWlscw0KPiA+DQo+ID4g T24gVGh1LCAyMDEyLTA4LTE2IGF0IDE3OjA3IC0wNzAwLCBTaGFpIExhem1pIHdyb3RlOg0KPiA+ ID4gU29ycnkgLSBjb21wYW55J3MgcG9saWN5IC4uLg0KPiA+ID4gV2hhdCBpZG1hcCB2ZXJzaW9u IHdhcyB0aGlzIHBhdGNoIHVzZWQgYWdhaW5zdD8gVGhlIG9uZSBJIGhhdmUgKGI3MDEzNThjKSBz ZWVtcyB0byBiZSBhIGJpdCBkaWZmZXJlbnQgKEkgdXNlZCBsYXRlc3QgcHVsbCBjb21taXQgZGRm MzQzZjYzNWZlNDQ0MGNhZDUyOGUxMmY5NmYyOGJkNTBhYTA5OSksIGhlbmNlIHRoZSBwYXRjaCBm YWlscyBhZ2Fpbg0KPiA+DQo+ID4gSXQgd29ya3MgZmluZSBmb3IgbWUgYWdhaW5zdCBjb21taXQg ZGRmMzQzZjYzNWZlNDQ0MGNhZDUyOGUxMmY5NmYyOGJkNTBhYTA5OToNCj4gPg0KPiA+IFt0cm9u ZG15QGxhZGUgbGludXgtbmZzXSQgZ2l0IGJyYW5jaCB0ZXN0LWFwcGx5IGRkZjM0M2Y2MzVmZTQ0 NDBjYWQ1MjhlMTJmOTZmMjhiZDUwYWEwOTkNCj4gPiBbdHJvbmRteUBsYWRlIGxpbnV4LW5mc10k IGdpdCBjaGVja291dCB0ZXN0LWFwcGx5DQo+ID4gU3dpdGNoZWQgdG8gYnJhbmNoICd0ZXN0LWFw cGx5Jw0KPiA+IFt0cm9uZG15QGxhZGUgbGludXgtbmZzXSQgZ2l0IGFtIH4vRGVza3RvcC9mb3Jf c2hhaS8wMDAxLU5GUy1DbGVhci1rZXktY29uc3RydWN0aW9uLWRhdGEtaWYtdGhlLWlkbWFwLXVw Y2FsbC0ucGF0Y2gNCj4gPiBBcHBseWluZzogTkZTOiBDbGVhciBrZXkgY29uc3RydWN0aW9uIGRh dGEgaWYgdGhlIGlkbWFwIHVwY2FsbCBmYWlscw0KPiA+IFt0cm9uZG15QGxhZGUgbGludXgtbmZz XSQgZ2l0IGFtIH4vRGVza3RvcC9mb3Jfc2hhaS8wMDAyLU5GUy1yZXR1cm4tRU5PS0VZLXdoZW4t dGhlLXVwY2FsbC1mYWlscy10by1tYXAtdGhlLW4ucGF0Y2gNCj4gPiBBcHBseWluZzogTkZTOiBy ZXR1cm4gLUVOT0tFWSB3aGVuIHRoZSB1cGNhbGwgZmFpbHMgdG8gbWFwIHRoZSBuYW1lDQo+ID4N Cj4gPiBXaGF0IGVycm9yIG1lc3NhZ2VzIGFyZSB5b3Ugc2VlaW5nPw0KPiA+DQo+ID4gQ2hlZXJz DQo+ID4gICBUcm9uZA0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ ID4gRnJvbTogTXlrbGVidXN0LCBUcm9uZCBbbWFpbHRvOlRyb25kLk15a2xlYnVzdEBuZXRhcHAu Y29tXQ0KPiA+ID4gU2VudDogVGh1cnNkYXksIEF1Z3VzdCAxNiwgMjAxMiA0OjU3IFBNDQo+ID4g PiBUbzogU2hhaSBMYXptaQ0KPiA+ID4gQ2M6IFdpbGxpYW0gRGF1Y2h5OyBTY2h1bWFrZXIsIEJy eWFuOyBsaW51eC1uZnNAdmdlci5rZXJuZWwub3JnDQo+ID4gPiBTdWJqZWN0OiBSZTogW1BBVENI IDEvMl0gTkZTOiBDbGVhciBrZXkgY29uc3RydWN0aW9uIGRhdGEgaWYgdGhlIGlkbWFwIHVwY2Fs bCBmYWlscw0KPiA+ID4NCj4gPiA+IE9uIFRodSwgMjAxMi0wOC0xNiBhdCAxNjo1MCAtMDcwMCwg U2hhaSBMYXptaSB3cm90ZToNCj4gPiA+ID4gTVMgb3V0bG9vaw0KPiA+ID4NCj4gPiA+IERvbid0 IGV2ZXIgdXNlIExvb2tPdXQgZm9yIHBhdGNoZXMuIEl0cyAiSSBqdXN0IHJlZm9ybWF0dGVkIHlv dXIgZW1haWwiDQo+ID4gPiB3b25kZXIgZmVhdHVyZSBicmVha3MgYWxsIHRoZSB3aGl0ZXNwYWNl Lg0KPiA+ID4NCj4gPiA+ID4gQmVzdCB0aGluZyBpcyB0byBhdHRhY2hlZCB0aGUgcGF0Y2gNCj4g PiA+DQo+ID4gPiBXZSBkbyBub3Qgbm9ybWFsbHkgdXNlIGF0dGFjaG1lbnRzIG9uIHRoZSBtYWls aW5nIGxpc3QgYmVjYXVzZSBpdCBtYWtlcyBpdCBpbXBvc3NpYmxlIHRvIGNvbW1lbnQgdGhlIHBh dGNoZXMgaW5saW5lLiBBaCB3ZWxsLCBoZXJlIGdvZXMuLi4NCj4gPiA+DQo+ID4gPiAtLQ0KPiA+ ID4gVHJvbmQgTXlrbGVidXN0DQo+ID4gPiBMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCj4g PiA+DQo+ID4gPiBOZXRBcHANCj4gPiA+IFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQo+ID4g PiB3d3cubmV0YXBwLmNvbQ0KPiA+ID4NCj4gPiA+DQo+ID4gPiBUaGlzIG1lc3NhZ2UgYW5kIGFu eSBhdHRhY2hlZCBkb2N1bWVudHMgY29udGFpbiBpbmZvcm1hdGlvbiBmcm9tIFFMb2dpYyBDb3Jw b3JhdGlvbiBvciBpdHMgd2hvbGx5LW93bmVkIHN1YnNpZGlhcmllcyB0aGF0IG1heSBiZSBjb25m aWRlbnRpYWwuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZCByZWNpcGllbnQsIHlvdSBtYXkg bm90IHJlYWQsIGNvcHksIGRpc3RyaWJ1dGUsIG9yIHVzZSB0aGlzIGluZm9ybWF0aW9uLiBJZiB5 b3UgaGF2ZSByZWNlaXZlZCB0aGlzIHRyYW5zbWlzc2lvbiBpbiBlcnJvciwgcGxlYXNlIG5vdGlm eSB0aGUgc2VuZGVyIGltbWVkaWF0ZWx5IGJ5IHJlcGx5IGUtbWFpbCBhbmQgdGhlbiBkZWxldGUg dGhpcyBtZXNzYWdlLg0KPiA+DQo+ID4gLS0NCj4gPiBUcm9uZCBNeWtsZWJ1c3QNCj4gPiBMaW51 eCBORlMgY2xpZW50IG1haW50YWluZXINCj4gPg0KPiA+IE5ldEFwcA0KPiA+IFRyb25kLk15a2xl YnVzdEBuZXRhcHAuY29tDQo+ID4gd3d3Lm5ldGFwcC5jb20NCj4gPg0KPiA+DQo+ID4gVGhpcyBt ZXNzYWdlIGFuZCBhbnkgYXR0YWNoZWQgZG9jdW1lbnRzIGNvbnRhaW4gaW5mb3JtYXRpb24gZnJv bSBRTG9naWMgQ29ycG9yYXRpb24gb3IgaXRzIHdob2xseS1vd25lZCBzdWJzaWRpYXJpZXMgdGhh dCBtYXkgYmUgY29uZmlkZW50aWFsLiBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5kZWQgcmVjaXBp ZW50LCB5b3UgbWF5IG5vdCByZWFkLCBjb3B5LCBkaXN0cmlidXRlLCBvciB1c2UgdGhpcyBpbmZv cm1hdGlvbi4gSWYgeW91IGhhdmUgcmVjZWl2ZWQgdGhpcyB0cmFuc21pc3Npb24gaW4gZXJyb3Is IHBsZWFzZSBub3RpZnkgdGhlIHNlbmRlciBpbW1lZGlhdGVseSBieSByZXBseSBlLW1haWwgYW5k IHRoZW4gZGVsZXRlIHRoaXMgbWVzc2FnZS4NCj4gDQo+IC0tDQo+IFRyb25kIE15a2xlYnVzdA0K PiBMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCj4gDQo+IE5ldEFwcA0KPiBUcm9uZC5NeWts ZWJ1c3RAbmV0YXBwLmNvbQ0KPiB3d3cubmV0YXBwLmNvbQ0KPiANCj4gDQo+IFRoaXMgbWVzc2Fn ZSBhbmQgYW55IGF0dGFjaGVkIGRvY3VtZW50cyBjb250YWluIGluZm9ybWF0aW9uIGZyb20gUUxv Z2ljIENvcnBvcmF0aW9uIG9yIGl0cyB3aG9sbHktb3duZWQgc3Vic2lkaWFyaWVzIHRoYXQgbWF5 IGJlIGNvbmZpZGVudGlhbC4gSWYgeW91IGFyZSBub3QgdGhlIGludGVuZGVkIHJlY2lwaWVudCwg eW91IG1heSBub3QgcmVhZCwgY29weSwgZGlzdHJpYnV0ZSwgb3IgdXNlIHRoaXMgaW5mb3JtYXRp b24uIElmIHlvdSBoYXZlIHJlY2VpdmVkIHRoaXMgdHJhbnNtaXNzaW9uIGluIGVycm9yLCBwbGVh c2Ugbm90aWZ5IHRoZSBzZW5kZXIgaW1tZWRpYXRlbHkgYnkgcmVwbHkgZS1tYWlsIGFuZCB0aGVu IGRlbGV0ZSB0aGlzIG1lc3NhZ2UuDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMg Y2xpZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0K d3d3Lm5ldGFwcC5jb20NCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Yup - already saw that ;-) -----Original Message----- From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] Sent: Thursday, August 16, 2012 6:15 PM To: Shai Lazmi Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails On Thu, 2012-08-16 at 18:09 -0700, Shai Lazmi wrote: > I've looked at the repo (http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=fs/nfs/idmap.c;h=b701358c39c351d0613d1db29ebcf382ca8cb0a6;hb=ddf343f635fe4440cad528e12f96f28bd50aa099), seems just like what I have > Can it be already changed on the tree? No. It hasn't been merged upstream yet. However, I've now pushed the patches upstream to the NFS bugfixes branch. Instead of applying the patches, perhaps you could just pull the full set of NFS client bugfixes by doing git pull git://git.linux-nfs.org/projects/trondmy/linux-nfs.git bugfixes Cheers Trond > -----Original Message----- > From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] > Sent: Thursday, August 16, 2012 5:22 PM > To: Shai Lazmi > Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org > Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails > > On Thu, 2012-08-16 at 17:15 -0700, Shai Lazmi wrote: > > git apply --check 0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch > > error: patch failed: fs/nfs/idmap.c:61 > > error: fs/nfs/idmap.c: patch does not apply > > > > > > idmap.c > > define NFS_UINT_MAXLEN 11 > > > > static const struct cred *id_resolver_cache; > > static struct key_type key_type_id_resolver_legacy; > > > > struct idmap { > > struct rpc_pipe *idmap_pipe; > > struct key_construction *idmap_key_cons; > > struct mutex idmap_mutex; > > }; > > That's how it should more or less look after applying the patch. I'm > guessing that one of your previous attempts has partially worked, and > has left your checked out git tree in a "dirty" state. > > Please try the following: > > $ git reset --hard HEAD > $ git apply --check 0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch > $ git apply --check 0002-NFS-return-ENOKEY-when-the-upcall-fails-to-map-the-n.patch > > > > > > -----Original Message----- > > From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] > > Sent: Thursday, August 16, 2012 5:14 PM > > To: Shai Lazmi > > Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org > > Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails > > > > On Thu, 2012-08-16 at 17:07 -0700, Shai Lazmi wrote: > > > Sorry - company's policy ... > > > What idmap version was this patch used against? The one I have (b701358c) seems to be a bit different (I used latest pull commit ddf343f635fe4440cad528e12f96f28bd50aa099), hence the patch fails again > > > > It works fine for me against commit ddf343f635fe4440cad528e12f96f28bd50aa099: > > > > [trondmy@lade linux-nfs]$ git branch test-apply ddf343f635fe4440cad528e12f96f28bd50aa099 > > [trondmy@lade linux-nfs]$ git checkout test-apply > > Switched to branch 'test-apply' > > [trondmy@lade linux-nfs]$ git am ~/Desktop/for_shai/0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch > > Applying: NFS: Clear key construction data if the idmap upcall fails > > [trondmy@lade linux-nfs]$ git am ~/Desktop/for_shai/0002-NFS-return-ENOKEY-when-the-upcall-fails-to-map-the-n.patch > > Applying: NFS: return -ENOKEY when the upcall fails to map the name > > > > What error messages are you seeing? > > > > Cheers > > Trond > > > > > -----Original Message----- > > > From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] > > > Sent: Thursday, August 16, 2012 4:57 PM > > > To: Shai Lazmi > > > Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org > > > Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails > > > > > > On Thu, 2012-08-16 at 16:50 -0700, Shai Lazmi wrote: > > > > MS outlook > > > > > > Don't ever use LookOut for patches. Its "I just reformatted your email" > > > wonder feature breaks all the whitespace. > > > > > > > Best thing is to attached the patch > > > > > > We do not normally use attachments on the mailing list because it makes it impossible to comment the patches inline. Ah well, here goes... > > > > > > -- > > > Trond Myklebust > > > Linux NFS client maintainer > > > > > > NetApp > > > Trond.Myklebust@netapp.com > > > www.netapp.com > > > > > > > > > This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. > > > > -- > > Trond Myklebust > > Linux NFS client maintainer > > > > NetApp > > Trond.Myklebust@netapp.com > > www.netapp.com > > > > > > This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. > > -- > Trond Myklebust > Linux NFS client maintainer > > NetApp > Trond.Myklebust@netapp.com > www.netapp.com > > > This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
No luck ... ------------[ cut here ]------------ kernel BUG at fs/nfs/idmap.c:681! ACPI: Invalid Power Resource to register! invalid opcode: 0000 [#1] SMP Modules linked in: Pid: 145, comm: mount.nfs Not tainted 3.6.0-rc2 #22 System manufacturer System Product Name/K8N-DL EIP: 0060:[<c0596958>] EFLAGS: 00010286 CPU: 1 EIP is at nfs_idmap_legacy_upcall+0xf3/0x146 EAX: f5b5e1e0 EBX: f587e840 ECX: f5b5e000 EDX: 00000010 ESI: 00000010 EDI: f5b5e1f8 EBP: f5b77a6c ESP: f5b77a4c DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 CR0: 8005003b CR2: 0831e000 CR3: 35b5c000 CR4: 000007d0 DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000 DR6: ffff0ff0 DR7: 00000400 Process mount.nfs (pid: 145, ti=f5b76000 task=f5b530c0 task.ti=f5b76000) Stack: f5b5e000 f5969a60 f5b5e1e0 f5b5e1a4 f5b5e1b4 c0596865 f59d0a00 f5969a60 f5b77aa0 c0600831 c09e626c c0a9d74c f5b5e180 f61dcd80 c0a9d758 f5970f80 f61dce00 00000000 00000003 f63d7f80 f5b5e194 f5b77ac0 c06008f0 00000000 Call Trace: [<c0596865>] ? idmap_pipe_destroy_msg+0x1d/0x1d [<c0600831>] request_key_and_link+0x297/0x30c [<c06008f0>] request_key_with_auxdata+0x19/0x44 [<c0596a44>] nfs_idmap_request_key+0x99/0x128 [<c0596bbd>] nfs_idmap_lookup_id+0x5a/0x95 [<c05972cc>] nfs_map_group_to_gid+0x3d/0x47 [<c05900b3>] decode_getfattr_attrs+0x539/0xa1b [<c05933ac>] decode_getfattr_generic.constprop.64+0x63/0x7f [<c05933d8>] decode_getfattr+0x10/0x12 [<c05935c0>] nfs4_xdr_dec_lookup_root+0x49/0x50 [<c0593577>] ? nfs4_xdr_dec_link+0x98/0x98 [<c07f765c>] rpcauth_unwrap_resp+0x48/0x50 [<c07f06af>] call_decode+0x260/0x2a3 [<c0593577>] ? nfs4_xdr_dec_link+0x98/0x98 [<c07f691e>] __rpc_execute+0x7c/0x1d9 [<c07f044f>] ? call_transmit_status+0x7c/0x7c [<c07f044f>] ? call_transmit_status+0x7c/0x7c [<c0440c35>] ? wake_up_bit+0x1c/0x20 [<c07f6b06>] rpc_execute+0x50/0x58 [<c07f1618>] rpc_run_task+0x67/0x6d [<c07f1706>] rpc_call_sync+0x40/0x5b [<c058a518>] _nfs4_call_sync+0x11/0x13 [<c058a3ac>] nfs4_call_sync+0x18/0x1d [<c058dafc>] nfs4_lookup_root+0x8d/0xb9 [<c058e75c>] nfs4_proc_get_rootfh+0x22/0x86 [<c05984d5>] nfs4_get_rootfh+0x31/0xa4 [<c04bff76>] ? kmem_cache_alloc_trace+0xc5/0xcf [<c057e624>] ? nfs_alloc_fattr+0x21/0x3a [<c07f6beb>] ? rpciod_up+0xf/0x18 [<c057e5e6>] ? nfs_fattr_init+0x21/0x3e [<c0598608>] nfs4_server_common_setup+0x45/0xab [<c0598b95>] nfs4_create_server+0x14b/0x171 [<c0595b9f>] nfs4_remote_mount+0x26/0x46 [<c04c7e55>] mount_fs+0x13/0x9a [<c04d8c51>] vfs_kern_mount+0x4f/0xa1 [<c0595a22>] nfs_do_root_mount+0x73/0x8d [<c0595bee>] nfs4_try_mount+0x2f/0x45 [<c058084b>] nfs_fs_mount+0x5cc/0x627 [<c0580c33>] ? nfs_clone_super+0x60/0x60 [<c057ea2c>] ? nfs_setattr+0x107/0x107 [<c04c7e55>] mount_fs+0x13/0x9a [<c04d8c51>] vfs_kern_mount+0x4f/0xa1 [<c04d8f63>] do_kern_mount+0x34/0xb2 [<c04da51b>] do_mount+0x5d8/0x626 [<c04da5cf>] sys_mount+0x66/0x99 [<c082209c>] sysenter_do_call+0x12/0x2c Code: 00 8d 93 84 00 00 00 8d 45 ec e8 42 d0 09 00 89 c6 8b 45 e8 85 f6 89 58 08 c7 40 0c 8c 00 00 00 78 2b 8b 4d e0 83 79 04 00 74 02 <0f> 0b 8b 45 e4 8b 4d e0 8b 55 e8 89 41 04 8b 01 e8 e8 94 26 00 EIP: [<c0596958>] nfs_idmap_legacy_upcall+0xf3/0x146 SS:ESP 0068:f5b77a4c ---[ end trace 9adee0a80860a05f ]--- -----Original Message----- From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] Sent: Thursday, August 16, 2012 5:22 PM To: Shai Lazmi Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails On Thu, 2012-08-16 at 17:15 -0700, Shai Lazmi wrote: > git apply --check 0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch > error: patch failed: fs/nfs/idmap.c:61 > error: fs/nfs/idmap.c: patch does not apply > > > idmap.c > define NFS_UINT_MAXLEN 11 > > static const struct cred *id_resolver_cache; > static struct key_type key_type_id_resolver_legacy; > > struct idmap { > struct rpc_pipe *idmap_pipe; > struct key_construction *idmap_key_cons; > struct mutex idmap_mutex; > }; That's how it should more or less look after applying the patch. I'm guessing that one of your previous attempts has partially worked, and has left your checked out git tree in a "dirty" state. Please try the following: $ git reset --hard HEAD $ git apply --check 0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch $ git apply --check 0002-NFS-return-ENOKEY-when-the-upcall-fails-to-map-the-n.patch > > -----Original Message----- > From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] > Sent: Thursday, August 16, 2012 5:14 PM > To: Shai Lazmi > Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org > Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails > > On Thu, 2012-08-16 at 17:07 -0700, Shai Lazmi wrote: > > Sorry - company's policy ... > > What idmap version was this patch used against? The one I have (b701358c) seems to be a bit different (I used latest pull commit ddf343f635fe4440cad528e12f96f28bd50aa099), hence the patch fails again > > It works fine for me against commit ddf343f635fe4440cad528e12f96f28bd50aa099: > > [trondmy@lade linux-nfs]$ git branch test-apply ddf343f635fe4440cad528e12f96f28bd50aa099 > [trondmy@lade linux-nfs]$ git checkout test-apply > Switched to branch 'test-apply' > [trondmy@lade linux-nfs]$ git am ~/Desktop/for_shai/0001-NFS-Clear-key-construction-data-if-the-idmap-upcall-.patch > Applying: NFS: Clear key construction data if the idmap upcall fails > [trondmy@lade linux-nfs]$ git am ~/Desktop/for_shai/0002-NFS-return-ENOKEY-when-the-upcall-fails-to-map-the-n.patch > Applying: NFS: return -ENOKEY when the upcall fails to map the name > > What error messages are you seeing? > > Cheers > Trond > > > -----Original Message----- > > From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] > > Sent: Thursday, August 16, 2012 4:57 PM > > To: Shai Lazmi > > Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org > > Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails > > > > On Thu, 2012-08-16 at 16:50 -0700, Shai Lazmi wrote: > > > MS outlook > > > > Don't ever use LookOut for patches. Its "I just reformatted your email" > > wonder feature breaks all the whitespace. > > > > > Best thing is to attached the patch > > > > We do not normally use attachments on the mailing list because it makes it impossible to comment the patches inline. Ah well, here goes... > > > > -- > > Trond Myklebust > > Linux NFS client maintainer > > > > NetApp > > Trond.Myklebust@netapp.com > > www.netapp.com > > > > > > This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. > > -- > Trond Myklebust > Linux NFS client maintainer > > NetApp > Trond.Myklebust@netapp.com > www.netapp.com > > > This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
On Fri, 2012-08-17 at 09:20 -0700, Shai Lazmi wrote: > No luck ... > ------------[ cut here ]------------ > kernel BUG at fs/nfs/idmap.c:681! That suggests that you haven't been testing the right branch. The BUG_ON should have been moved to line 692 after the patches were applied. Did you copy the exact pull request from my email (i.e. "git pull git://git.linux-nfs.org/projects/trondmy/linux-nfs.git bugfixes"? If so, you should have gotten a vim page with a text of the form: Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/linux-nfs in # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit. (which you then follow up with a ':wq' to confirm) A 'git log' should then show your first commit as being something along the lines of: Merge: d987569 12dfd08 Author: Trond Myklebust <Trond.Myklebust@netapp.com> Date: Fri Aug 17 13:41:02 2012 -0400 Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/linux-nf Is that indeed the case? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com
Missed that, co and rebuild -----Original Message----- From: Myklebust, Trond [mailto:Trond.Myklebust@netapp.com] Sent: Friday, August 17, 2012 10:46 AM To: Shai Lazmi Cc: William Dauchy; Schumaker, Bryan; linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/2] NFS: Clear key construction data if the idmap upcall fails On Fri, 2012-08-17 at 09:20 -0700, Shai Lazmi wrote: > No luck ... > ------------[ cut here ]------------ > kernel BUG at fs/nfs/idmap.c:681! That suggests that you haven't been testing the right branch. The BUG_ON should have been moved to line 692 after the patches were applied. Did you copy the exact pull request from my email (i.e. "git pull git://git.linux-nfs.org/projects/trondmy/linux-nfs.git bugfixes"? If so, you should have gotten a vim page with a text of the form: Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/linux-nfs in # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit. (which you then follow up with a ':wq' to confirm) A 'git log' should then show your first commit as being something along the lines of: Merge: d987569 12dfd08 Author: Trond Myklebust <Trond.Myklebust@netapp.com> Date: Fri Aug 17 13:41:02 2012 -0400 Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/linux-nf Is that indeed the case? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
Q29vbCAtIFdvcmtzICEhIQ0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogTXlr bGVidXN0LCBUcm9uZCBbbWFpbHRvOlRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tXQ0KU2VudDog RnJpZGF5LCBBdWd1c3QgMTcsIDIwMTIgMTA6NDYgQU0NClRvOiBTaGFpIExhem1pDQpDYzogV2ls bGlhbSBEYXVjaHk7IFNjaHVtYWtlciwgQnJ5YW47IGxpbnV4LW5mc0B2Z2VyLmtlcm5lbC5vcmcN ClN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8yXSBORlM6IENsZWFyIGtleSBjb25zdHJ1Y3Rpb24gZGF0 YSBpZiB0aGUgaWRtYXAgdXBjYWxsIGZhaWxzDQoNCk9uIEZyaSwgMjAxMi0wOC0xNyBhdCAwOToy MCAtMDcwMCwgU2hhaSBMYXptaSB3cm90ZToNCj4gTm8gbHVjayAuLi4NCj4gLS0tLS0tLS0tLS0t WyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQo+IGtlcm5lbCBCVUcgYXQgZnMvbmZzL2lkbWFwLmM6 NjgxIQ0KDQpUaGF0IHN1Z2dlc3RzIHRoYXQgeW91IGhhdmVuJ3QgYmVlbiB0ZXN0aW5nIHRoZSBy aWdodCBicmFuY2guIFRoZSBCVUdfT04NCnNob3VsZCBoYXZlIGJlZW4gbW92ZWQgdG8gbGluZSA2 OTIgYWZ0ZXIgdGhlIHBhdGNoZXMgd2VyZSBhcHBsaWVkLg0KDQpEaWQgeW91IGNvcHkgdGhlIGV4 YWN0IHB1bGwgcmVxdWVzdCBmcm9tIG15IGVtYWlsIChpLmUuICJnaXQgcHVsbA0KZ2l0Oi8vZ2l0 LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9saW51eC1uZnMuZ2l0IGJ1Z2ZpeGVzIj8g SWYgc28sDQp5b3Ugc2hvdWxkIGhhdmUgZ290dGVuIGEgdmltIHBhZ2Ugd2l0aCBhIHRleHQgb2Yg dGhlIGZvcm06DQoNCiAgICAgICAgTWVyZ2UgYnJhbmNoICdidWdmaXhlcycgb2YgZ2l0Oi8vZ2l0 LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9saW51eC1uZnMgaW4NCg0KICAgICAgICAj IFBsZWFzZSBlbnRlciBhIGNvbW1pdCBtZXNzYWdlIHRvIGV4cGxhaW4gd2h5IHRoaXMgbWVyZ2Ug aXMgbmVjZXNzYXJ5LA0KICAgICAgICAjIGVzcGVjaWFsbHkgaWYgaXQgbWVyZ2VzIGFuIHVwZGF0 ZWQgdXBzdHJlYW0gaW50byBhIHRvcGljIGJyYW5jaC4NCiAgICAgICAgIw0KICAgICAgICAjIExp bmVzIHN0YXJ0aW5nIHdpdGggJyMnIHdpbGwgYmUgaWdub3JlZCwgYW5kIGFuIGVtcHR5IG1lc3Nh Z2UgYWJvcnRzDQogICAgICAgICMgdGhlIGNvbW1pdC4NCg0KDQood2hpY2ggeW91IHRoZW4gZm9s bG93IHVwIHdpdGggYSAnOndxJyB0byBjb25maXJtKQ0KDQpBICdnaXQgbG9nJyBzaG91bGQgdGhl biBzaG93IHlvdXIgZmlyc3QgY29tbWl0IGFzIGJlaW5nIHNvbWV0aGluZyBhbG9uZw0KdGhlIGxp bmVzIG9mOg0KDQogICAgICAgIE1lcmdlOiBkOTg3NTY5IDEyZGZkMDgNCiAgICAgICAgQXV0aG9y OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KICAgICAgICBE YXRlOiAgIEZyaSBBdWcgMTcgMTM6NDE6MDIgMjAxMiAtMDQwMA0KDQogICAgICAgICAgICBNZXJn ZSBicmFuY2ggJ2J1Z2ZpeGVzJyBvZiBnaXQ6Ly9naXQubGludXgtbmZzLm9yZy9wcm9qZWN0cy90 cm9uZG15L2xpbnV4LW5mDQoNCg0KSXMgdGhhdCBpbmRlZWQgdGhlIGNhc2U/DQoNCg0KDQotLQ0K VHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpU cm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFwcC5jb20NCg0KDQpUaGlzIG1lc3Nh Z2UgYW5kIGFueSBhdHRhY2hlZCBkb2N1bWVudHMgY29udGFpbiBpbmZvcm1hdGlvbiBmcm9tIFFM b2dpYyBDb3Jwb3JhdGlvbiBvciBpdHMgd2hvbGx5LW93bmVkIHN1YnNpZGlhcmllcyB0aGF0IG1h eSBiZSBjb25maWRlbnRpYWwuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZCByZWNpcGllbnQs IHlvdSBtYXkgbm90IHJlYWQsIGNvcHksIGRpc3RyaWJ1dGUsIG9yIHVzZSB0aGlzIGluZm9ybWF0 aW9uLiBJZiB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIHRyYW5zbWlzc2lvbiBpbiBlcnJvciwgcGxl YXNlIG5vdGlmeSB0aGUgc2VuZGVyIGltbWVkaWF0ZWx5IGJ5IHJlcGx5IGUtbWFpbCBhbmQgdGhl biBkZWxldGUgdGhpcyBtZXNzYWdlLg0K -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From d0f6eca7eb175373a61173d86f3cf4ec4a9166fa Mon Sep 17 00:00:00 2001 From: Bryan Schumaker <bjschuma@netapp.com> Date: Thu, 9 Aug 2012 14:05:50 -0400 Subject: [PATCH 2/2] NFS: return -ENOKEY when the upcall fails to map the name This allows the normal error-paths to handle the error, rather than making a special call to complete_request_key() just for this instance. Signed-off-by: Bryan Schumaker <bjschuma@netapp.com> Tested-by: William Dauchy <wdauchy@gmail.com> Cc: stable@vger.kernel.org [>= 3.4] Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> --- fs/nfs/idmap.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c index 6703c73..a850079 100644 --- a/fs/nfs/idmap.c +++ b/fs/nfs/idmap.c @@ -760,9 +760,8 @@ idmap_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) } if (!(im.im_status & IDMAP_STATUS_SUCCESS)) { - ret = mlen; - complete_request_key(cons, -ENOKEY); - goto out_incomplete; + ret = -ENOKEY; + goto out; } namelen_in = strnlen(im.im_name, IDMAP_NAMESZ); @@ -779,7 +778,6 @@ idmap_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) out: complete_request_key(cons, ret); -out_incomplete: return ret; } -- 1.7.11.2