From patchwork Fri Apr 24 11:04:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Andreas_Gr=C3=BCnbacher?= X-Patchwork-Id: 6268251 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CAD1DBF4A6 for ; Fri, 24 Apr 2015 11:11:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A9402201E4 for ; Fri, 24 Apr 2015 11:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E9252022A for ; Fri, 24 Apr 2015 11:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964919AbbDXLLy (ORCPT ); Fri, 24 Apr 2015 07:11:54 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36286 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964875AbbDXLFb (ORCPT ); Fri, 24 Apr 2015 07:05:31 -0400 Received: by wizk4 with SMTP id k4so17553599wiz.1; Fri, 24 Apr 2015 04:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=3wKA2rCppV+8qEW8QR7s8K9+zxwagOdV+xxP3tygbtY=; b=A3mgmuds/iHfAyjev2PhGIV52XnVvqDQU+VZx5Btvb8cbEXJ2AgNSoDq7fZQCjjamY Ga/q/sGlqWBBDRnGAAVzPsSDpEJDId3bkXib+U23Vgm4THNp66cc1vbHoTsXu3TdcoEU aOnQMzsqt4tY4LtZugg2lxj6PCbt/913cnN1YYFGdvUcOjRlV5PcVSa5pATGDukON55T GLjBXEXnroGuGyqggYG39ZYi3xh/Af0kDvGjqXxUiD1qzUT1MQurj6b0veJWxEG24UuE c91zltyqNA+6jsytrEglQQm3XZkHzmzIc1T37bh3cD4E1J6aC+IRZO9pwBxkEHh4AMbb u3YQ== X-Received: by 10.180.99.39 with SMTP id en7mr2819387wib.31.1429873529518; Fri, 24 Apr 2015 04:05:29 -0700 (PDT) Received: from nuc.home.com (80-110-112-232.cgn.dynamic.surfer.at. [80.110.112.232]) by mx.google.com with ESMTPSA id ch6sm16410648wjc.3.2015.04.24.04.05.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Apr 2015 04:05:28 -0700 (PDT) From: Andreas Gruenbacher X-Google-Original-From: Andreas Gruenbacher To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org Cc: Andreas Gruenbacher Subject: [RFC v3 28/45] richacl: Isolate the owner and group classes Date: Fri, 24 Apr 2015 13:04:25 +0200 Message-Id: <5320d28cb8a5e3783ed552fb9d8166733eedb0e1.1429868795.git.agruenba@redhat.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When applying the file masks to an acl, we need to ensure that no process gets more permissions than allowed by its file mask. This may require inserting an owner@ deny ace to ensure this if the owner mask contains fewer permissions than the group or other mask. For example, when applying mode 0466 to the following acl: everyone@:rw::allow A deny ace needs to be inserted so that the owner won't get elevated write access: owner@:w::deny everyone@:rw::allow Likewise, we may need to insert group class deny aces if the group mask contains fewer permissions than the other mask. For example, when applying mode 0646 to the following acl: owner@:rw::allow everyone@:rw::allow A deny ace needs to be inserted so that the owning group won't get elevated write access: owner@:rw::allow group@:w::deny everyone@:rw::allow Signed-off-by: Andreas Gruenbacher --- fs/richacl_compat.c | 233 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 233 insertions(+) diff --git a/fs/richacl_compat.c b/fs/richacl_compat.c index f43d007..645917f 100644 --- a/fs/richacl_compat.c +++ b/fs/richacl_compat.c @@ -414,3 +414,236 @@ richacl_propagate_everyone(struct richacl_alloc *x) } return 0; } + +/** + * richacl_max_allowed - maximum permissions that anybody is allowed + */ +static unsigned int +richacl_max_allowed(struct richacl *acl) +{ + struct richace *ace; + unsigned int allowed = 0; + + richacl_for_each_entry_reverse(ace, acl) { + if (richace_is_inherit_only(ace)) + continue; + if (richace_is_allow(ace)) + allowed |= ace->e_mask; + else if (richace_is_deny(ace)) { + if (richace_is_everyone(ace)) + allowed &= ~ace->e_mask; + } + } + return allowed; +} + +/** + * richacl_isolate_owner_class - limit the owner class to the owner file mask + * @x: acl and number of allocated entries + * + * POSIX requires that after a chmod, the owner class is granted no more + * permissions than the owner file permission bits. For richacls, this + * means that the owner class must not be granted any permissions that the + * owner mask does not include. + * + * When we apply file masks to an acl which grant more permissions to the group + * or other class than to the owner class, we may end up in a situation where + * the owner is granted additional permissions from other aces. For example, + * given this acl: + * + * everyone:rwx::allow + * + * when file masks corresponding to mode 0466 are applied, after + * richacl_propagate_everyone() and __richacl_apply_masks(), we end up with: + * + * owner@:r::allow + * everyone@:rw::allow + * + * This acl still grants the owner rw access through the everyone@ allow ace. + * To fix this, we must deny the owner w access: + * + * owner@:w::deny + * owner@:r::allow + * everyone@:rw::allow + */ +static int +richacl_isolate_owner_class(struct richacl_alloc *x) +{ + struct richace *ace; + unsigned int allowed = 0; + + allowed = richacl_max_allowed(x->acl); + if (allowed & ~x->acl->a_owner_mask) { + /* + * Figure out if we can update an existig OWNER@ DENY entry. + */ + richacl_for_each_entry(ace, x->acl) { + if (richace_is_inherit_only(ace)) + continue; + if (richace_is_deny(ace)) { + if (richace_is_owner(ace)) + break; + } else if (richace_is_allow(ace)) { + ace = x->acl->a_entries + x->acl->a_count; + break; + } + } + if (ace != x->acl->a_entries + x->acl->a_count) { + if (richace_change_mask(x, &ace, ace->e_mask | + (allowed & ~x->acl->a_owner_mask))) + return -1; + } else { + /* Insert an owner@ deny entry at the front. */ + ace = x->acl->a_entries; + if (richacl_insert_entry(x, &ace)) + return -1; + ace->e_type = RICHACE_ACCESS_DENIED_ACE_TYPE; + ace->e_flags = RICHACE_SPECIAL_WHO; + ace->e_mask = allowed & ~x->acl->a_owner_mask; + ace->e_id.special = RICHACE_OWNER_SPECIAL_ID; + } + } + return 0; +} + +/** + * __richacl_isolate_who - isolate entry from everyone@ allow entry + * @x: acl and number of allocated entries + * @who: identifier to isolate + * @deny: permissions this identifier should not be allowed + * + * See richacl_isolate_group_class(). + */ +static int +__richacl_isolate_who(struct richacl_alloc *x, struct richace *who, + unsigned int deny) +{ + struct richace *ace; + unsigned int n; + /* + * Compute the permissions already denied to @who. + */ + richacl_for_each_entry(ace, x->acl) { + if (richace_is_inherit_only(ace)) + continue; + if (richace_is_same_identifier(ace, who) && + richace_is_deny(ace)) + deny &= ~ace->e_mask; + } + if (!deny) + return 0; + + /* + * Figure out if we can update an existig deny entry. Start from the + * entry before the trailing everyone@ allow entry. We will not hit + * everyone@ entries in the loop. + */ + for (n = x->acl->a_count - 2; n != -1; n--) { + ace = x->acl->a_entries + n; + if (richace_is_inherit_only(ace)) + continue; + if (richace_is_deny(ace)) { + if (richace_is_same_identifier(ace, who)) + break; + } else if (richace_is_allow(ace) && + (ace->e_mask & deny)) { + n = -1; + break; + } + } + if (n != -1) { + if (richace_change_mask(x, &ace, ace->e_mask | deny)) + return -1; + } else { + /* + * Insert a new entry before the trailing everyone@ deny entry. + */ + struct richace who_copy; + + ace = x->acl->a_entries + x->acl->a_count - 1; + memcpy(&who_copy, who, sizeof(struct richace)); + if (richacl_insert_entry(x, &ace)) + return -1; + memcpy(ace, &who_copy, sizeof(struct richace)); + ace->e_type = RICHACE_ACCESS_DENIED_ACE_TYPE; + richace_clear_inheritance_flags(ace); + ace->e_mask = deny; + } + return 0; +} + +/** + * richacl_isolate_group_class - limit the group class to the group file mask + * @x: acl and number of allocated entries + * + * POSIX requires that after a chmod, the group class is granted no more + * permissions than the group file permission bits. For richacls, this + * means that the group class must not be granted any permissions that the + * group mask does not include. + * + * When we apply file masks to an acl which grant more permissions to the other + * class than to the group class, we may end up in a situation where processes + * in the group class are granted additional permission from other aces. For + * example, given this acl: + * + * joe:rwx::allow + * everyone:rwx::allow + * + * when file masks corresponding to mode 0646 are applied, after + * richacl_propagate_everyone() and __richacl_apply_masks(), we end up with: + * + * joe:r::allow + * owner@:rw::allow + * group@:r::allow + * everyone@:rw::allow + * + * This acl still grants joe and group@ rw access through the everyone@ allow + * ace. To fix this, we must deny w access to group class aces before the + * everyone@ allow ace at the end of the acl: + * + * joe:r::allow + * owner@:rw::allow + * group@:r::allow + * joe:w::deny + * group@:w::deny + * everyone@:rw::allow + */ +static int +richacl_isolate_group_class(struct richacl_alloc *x) +{ + struct richace who = { + .e_flags = RICHACE_SPECIAL_WHO, + .e_id.special = RICHACE_GROUP_SPECIAL_ID, + }; + struct richace *ace; + unsigned int deny; + + if (!x->acl->a_count) + return 0; + ace = x->acl->a_entries + x->acl->a_count - 1; + if (richace_is_inherit_only(ace) || !richace_is_everyone(ace)) + return 0; + deny = ace->e_mask & ~x->acl->a_group_mask; + + if (deny) { + unsigned int n; + + if (__richacl_isolate_who(x, &who, deny)) + return -1; + /* + * Start from the entry before the trailing everyone@ allow + * entry. We will not hit everyone@ entries in the loop. + */ + for (n = x->acl->a_count - 2; n != -1; n--) { + ace = x->acl->a_entries + n; + + if (richace_is_inherit_only(ace) || + richace_is_owner(ace) || + richace_is_group(ace)) + continue; + if (__richacl_isolate_who(x, ace, deny)) + return -1; + } + } + return 0; +}