From patchwork Sun Apr 13 12:56:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 3973741 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 15FCC9F336 for ; Sun, 13 Apr 2014 12:57:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 384FB201E4 for ; Sun, 13 Apr 2014 12:56:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64191201DE for ; Sun, 13 Apr 2014 12:56:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190AbaDMM45 (ORCPT ); Sun, 13 Apr 2014 08:56:57 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:43970 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754083AbaDMM44 (ORCPT ); Sun, 13 Apr 2014 08:56:56 -0400 Received: by mail-pb0-f42.google.com with SMTP id rr13so7245270pbb.15 for ; Sun, 13 Apr 2014 05:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=FIbsYVRWRc4YtANGk9qVBaBOGA/ctD2iDMEsWGhxHsM=; b=wM2EInio9zMXa+mi6Cq+dUM5AmZgP3P4Z7INWebkeEniTvGhOwH9tJGX7bjzeSYMon uBXgAXiUq363lYbEzPB/08sQy4h6QlLYyS9Cyb73IW+1Tef5Hdqx6oirqtwZg/HgBNqc hjuTtd+ia+8a7ux7nQLCu5SrYx/K7ZEp77FG6bDJjBkWNpWpC+/sEZnsA1938+0+QCKx 7srgnJKg34aJVXOKqOdE6FLc3/VVpEIyIizP7Nqq+3i5AnHDn4JRhmAbsdSnHX+6s3tn zenyRAlZwz8gy0juUooqT07Ov8xZghRSjPu9NCGR29DkC6d8nY8m5AFjXr+EdsoHOiGY QDLA== X-Received: by 10.66.148.230 with SMTP id tv6mr57217pab.155.1397393815819; Sun, 13 Apr 2014 05:56:55 -0700 (PDT) Received: from [192.168.0.104] ([171.215.249.239]) by mx.google.com with ESMTPSA id j3sm27580707pbh.38.2014.04.13.05.56.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 13 Apr 2014 05:56:54 -0700 (PDT) Message-ID: <534A897E.10303@gmail.com> Date: Sun, 13 Apr 2014 20:56:30 +0800 From: Kinglong Mee User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "J. Bruce Fields" , linux-nfs@vger.kernel.org Subject: [PATCH 1/2] NFSD: Cleanup unused comments and codes in summarize_posix_acl Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Kinglong Mee --- fs/nfsd/nfs4acl.c | 7 ------- 1 file changed, 7 deletions(-) case ACL_USER_OBJ: diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c index 6f3f392..de5d66b 100644 --- a/fs/nfsd/nfs4acl.c +++ b/fs/nfsd/nfs4acl.c @@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct posix_acl_summary *pas) { struct posix_acl_entry *pa, *pe; - /* - * Only pas.users and pas.groups need initialization; previous - * posix_acl_valid() calls ensure that the other fields will be - * initialized in the following loop. But, just to placate gcc: - */ memset(pas, 0, sizeof(*pas)); pas->mask = 07; - pe = acl->a_entries + acl->a_count; - FOREACH_ACL_ENTRY(pa, acl, pe) { switch (pa->e_tag) {