| Message ID | 534A8D29.5070101@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
I'd rather leave the comment there as long as we keep the memset. I think you're right about the pe initialization, I don't know why that's there.... --b. On Sun, Apr 13, 2014 at 09:12:09PM +0800, Kinglong Mee wrote: > Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> > --- > fs/nfsd/nfs4acl.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c > index 6f3f392..de5d66b 100644 > --- a/fs/nfsd/nfs4acl.c > +++ b/fs/nfsd/nfs4acl.c > @@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct > posix_acl_summary *pas) > { > struct posix_acl_entry *pa, *pe; > > - /* > - * Only pas.users and pas.groups need initialization; previous > - * posix_acl_valid() calls ensure that the other fields will be > - * initialized in the following loop. But, just to placate gcc: > - */ > memset(pas, 0, sizeof(*pas)); > pas->mask = 07; > > - pe = acl->a_entries + acl->a_count; > - > FOREACH_ACL_ENTRY(pa, acl, pe) { > switch (pa->e_tag) { > case ACL_USER_OBJ: > -- > 1.9.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c index 6f3f392..de5d66b 100644 --- a/fs/nfsd/nfs4acl.c +++ b/fs/nfsd/nfs4acl.c @@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct posix_acl_summary *pas) { struct posix_acl_entry *pa, *pe; - /* - * Only pas.users and pas.groups need initialization; previous - * posix_acl_valid() calls ensure that the other fields will be - * initialized in the following loop. But, just to placate gcc: - */ memset(pas, 0, sizeof(*pas)); pas->mask = 07; - pe = acl->a_entries + acl->a_count; - FOREACH_ACL_ENTRY(pa, acl, pe) { switch (pa->e_tag) {
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> --- fs/nfsd/nfs4acl.c | 7 ------- 1 file changed, 7 deletions(-) case ACL_USER_OBJ: