From patchwork Sun Apr 13 13:12:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 3973901 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E607C9F2CC for ; Sun, 13 Apr 2014 13:12:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3214820200 for ; Sun, 13 Apr 2014 13:12:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B1DF201FE for ; Sun, 13 Apr 2014 13:12:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754557AbaDMNMq (ORCPT ); Sun, 13 Apr 2014 09:12:46 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:34768 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754338AbaDMNMq (ORCPT ); Sun, 13 Apr 2014 09:12:46 -0400 Received: by mail-pd0-f171.google.com with SMTP id r10so7098181pdi.2 for ; Sun, 13 Apr 2014 06:12:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=FIbsYVRWRc4YtANGk9qVBaBOGA/ctD2iDMEsWGhxHsM=; b=sJvWkIessCIBw5Ga/IkRmMdFVts5Y3Um5CEePmlc6V/2p1AwTUj9YAh9YdI/Xlf+6f vad0PrVg5voDo+L3BlfrAoAkVIZCJhV1Hl7WuF+GTylWZeFcbkUPH2eHanUuzrju4OBz 91XuqSwkXjm9EkO7rmi0IMyFKOtll0wGe5hgAV9p2Dqj8kh7iKiFGjI2z5FLuauVovI1 mYZjFMANjKdpe4kSQuZ3AqovqV3KttkiXabl1zWDKl/Vwft7RvnId3xIDu9WpWjCg/q3 MCnCLJTMPTwL/wlRfej/qeNJiZ0Qg7HEwbTdO8wInfv3DGxDloVH8DFx1483rgZiXBEG tV2Q== X-Received: by 10.66.177.168 with SMTP id cr8mr1545073pac.128.1397394765382; Sun, 13 Apr 2014 06:12:45 -0700 (PDT) Received: from [192.168.0.104] ([171.215.249.239]) by mx.google.com with ESMTPSA id f5sm65441643pat.11.2014.04.13.06.12.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 13 Apr 2014 06:12:44 -0700 (PDT) Message-ID: <534A8D29.5070101@gmail.com> Date: Sun, 13 Apr 2014 21:12:09 +0800 From: Kinglong Mee User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "J. Bruce Fields" , linux-nfs@vger.kernel.org Subject: [PATCH] NFSD: Cleanup unused comments and codes in summarize_posix_acl References: <534A897E.10303@gmail.com> In-Reply-To: <534A897E.10303@gmail.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Kinglong Mee --- fs/nfsd/nfs4acl.c | 7 ------- 1 file changed, 7 deletions(-) case ACL_USER_OBJ: diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c index 6f3f392..de5d66b 100644 --- a/fs/nfsd/nfs4acl.c +++ b/fs/nfsd/nfs4acl.c @@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct posix_acl_summary *pas) { struct posix_acl_entry *pa, *pe; - /* - * Only pas.users and pas.groups need initialization; previous - * posix_acl_valid() calls ensure that the other fields will be - * initialized in the following loop. But, just to placate gcc: - */ memset(pas, 0, sizeof(*pas)); pas->mask = 07; - pe = acl->a_entries + acl->a_count; - FOREACH_ACL_ENTRY(pa, acl, pe) { switch (pa->e_tag) {