From patchwork Fri May 23 12:53:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 4232441 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8E27EBF90B for ; Fri, 23 May 2014 12:54:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D2905202C8 for ; Fri, 23 May 2014 12:54:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DB4520108 for ; Fri, 23 May 2014 12:54:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbaEWMyH (ORCPT ); Fri, 23 May 2014 08:54:07 -0400 Received: from mail-qc0-f178.google.com ([209.85.216.178]:50079 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbaEWMyF (ORCPT ); Fri, 23 May 2014 08:54:05 -0400 Received: by mail-qc0-f178.google.com with SMTP id l6so7904294qcy.23 for ; Fri, 23 May 2014 05:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=gR4rdm7MXMOCq6QoJs4Jr9a8m7nP35qY6AHuTYwYxNA=; b=tcJbCxCL40S7/LDOHckzBKdqzU2hRRlzSCJQjzLDSVpMGJRoAVVNQFi8HJOvpKdU0l 51IjxUFEiJFZ69lJcQ+WOeNwXDfBwO8tNX0jCWIayDvC0T53yLMBAc/31LiErPT7onCV m0hX6KwhYvGpdtg7pN2sQUSJJV+4ZxqMJoD8NwpUAjLUow1azbQubC0cfhPYI/A/Qu8z /vc0t+YWq9AofzK+WlQEOQ2b6r9r+vgcQXfZrTnDg7fSFtTwcgMT7hiDVP21SFFygeGr gxR7pmIUcpg1klM5hk2acQo5LRJT0hISi2OPPOxZFPqtodhCu8rk6oGquyqqGfJIgSN8 0bcQ== X-Received: by 10.224.46.195 with SMTP id k3mr6190009qaf.51.1400849645044; Fri, 23 May 2014 05:54:05 -0700 (PDT) Received: from [192.168.31.158] ([118.117.113.227]) by mx.google.com with ESMTPSA id d8sm4744283qas.24.2014.05.23.05.54.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 May 2014 05:54:04 -0700 (PDT) Message-ID: <537F44D8.2060606@gmail.com> Date: Fri, 23 May 2014 20:53:44 +0800 From: Kinglong Mee User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: "J. Bruce Fields" CC: Linux NFS Mailing List , kinglongmee@gmail.com Subject: [PATCH 2/5] NFSD: Cleanup unused variable in nfsd_setuser() Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP commit 8f6c5ffc8987f4f5b5a3e9d557d94bbf3a9bf216 have remove the last using of "ret", just remove it right now. Signed-off-by: Kinglong Mee --- fs/nfsd/auth.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c index 1042325..72f4482 100644 --- a/fs/nfsd/auth.c +++ b/fs/nfsd/auth.c @@ -24,7 +24,6 @@ int nfsd_setuser(struct svc_rqst *rqstp, struct svc_export *exp) struct cred *new; int i; int flags = nfsexp_flags(rqstp, exp); - int ret; validate_process_creds(); @@ -85,8 +84,7 @@ int nfsd_setuser(struct svc_rqst *rqstp, struct svc_export *exp) return 0; oom: - ret = -ENOMEM; abort_creds(new); - return ret; + return -ENOMEM; }