From patchwork Wed Nov 5 16:17:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Dickson X-Patchwork-Id: 5235581 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8BBEDC11AC for ; Wed, 5 Nov 2014 16:17:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A88162015E for ; Wed, 5 Nov 2014 16:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A2C9200E9 for ; Wed, 5 Nov 2014 16:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754468AbaKEQRX (ORCPT ); Wed, 5 Nov 2014 11:17:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46195 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754004AbaKEQRW (ORCPT ); Wed, 5 Nov 2014 11:17:22 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA5GHKDB001391 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 5 Nov 2014 11:17:20 -0500 Received: from smallhat.boston.devel.redhat.com (vpn-60-154.rdu2.redhat.com [10.10.60.154]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sA5GHJK9000955; Wed, 5 Nov 2014 11:17:19 -0500 Message-ID: <545A4D8E.5010106@RedHat.com> Date: Wed, 05 Nov 2014 11:17:18 -0500 From: Steve Dickson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: NeilBrown CC: Linux NFS Mailing list Subject: Re: [PATCH 1/2] rpc.svcgssd: Add a configure switch to disable building the daemon References: <1411489301-28991-1-git-send-email-steved@redhat.com> <1411489301-28991-2-git-send-email-steved@redhat.com> <20141105135633.4ea63a2c@notabene.brown> In-Reply-To: <20141105135633.4ea63a2c@notabene.brown> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/04/2014 09:56 PM, NeilBrown wrote: > Hi Steve, > I just noticed that this causes an error when I try "./configure". > It tries to run a program called "enable_svcgss" with args "=" and "yes", > but this fails.... > > A simple fix would leave the code doing nothing if enable_gss = yes, but > enable_svcgss = no. Is that what you want? No... > > Should it be: > > if test "$enable_gss" = yes -a "$enable_svcgss" = yes; then > SVCGSSD=svcgssd >> > + else >> > + enable_svcgss= >> > + SVCGSSD= >> > + fi > ?? > > Would you like a patch, or will you just fix it up? I got it... thanks! commit e186d734cb3d7c53ef8038b2f62e5b1825d9fa26 Author: Steve Dickson Date: Wed Nov 5 11:12:03 2014 -0500 configure: Fixed logic around $enable_gss and $enable_svcgss Signed-off-by: Steve Dickson steved. --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/configure.ac b/configure.ac index 59fd14d..377ba2e 100644 --- a/configure.ac +++ b/configure.ac @@ -108,10 +108,8 @@ AC_ARG_ENABLE(svcgss, [enable building svcgssd for rpcsec_gss server support @<:@default=yes@:>@])], enable_svcgss=$enableval, enable_svcgss=yes) - if test "$enable_gss" = yes; then - if "enable_svcgss" = yes; then - SVCGSSD=svcgssd - fi + if test "$enable_gss" = yes -a "enable_svcgss" = yes; then + SVCGSSD=svcgssd else enable_svcgss= SVCGSSD=