| Message ID | 5521422A.7080005@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks, sorry for messing up the last minute update..
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/05/2015 10:09 AM, Kinglong Mee wrote: > When using pnfs with "fsid=0", exportfs prints error as, > > # exportfs -a > exportfs: /var/lib/nfs/etab:1: unknown keyword "no_pnfsfsid=0" > > Commit cdd16bef98 ("nfs-utils: add support for the "pnfs" export option") > miss the comma after "pnfs"/"on_pnfs" operation. > > Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> Committed... steved. > --- > support/nfs/exports.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/support/nfs/exports.c b/support/nfs/exports.c > index 9b325b9..761a046 100644 > --- a/support/nfs/exports.c > +++ b/support/nfs/exports.c > @@ -275,7 +275,7 @@ putexportent(struct exportent *ep) > "no_" : ""); > if (ep->e_flags & NFSEXP_NOREADDIRPLUS) > fprintf(fp, "nordirplus,"); > - fprintf(fp, "%spnfs", (ep->e_flags & NFSEXP_PNFS)? "" : "no_"); > + fprintf(fp, "%spnfs,", (ep->e_flags & NFSEXP_PNFS)? "" : "no_"); > if (ep->e_flags & NFSEXP_FSID) { > fprintf(fp, "fsid=%d,", ep->e_fsid); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/support/nfs/exports.c b/support/nfs/exports.c index 9b325b9..761a046 100644 --- a/support/nfs/exports.c +++ b/support/nfs/exports.c @@ -275,7 +275,7 @@ putexportent(struct exportent *ep) "no_" : ""); if (ep->e_flags & NFSEXP_NOREADDIRPLUS) fprintf(fp, "nordirplus,"); - fprintf(fp, "%spnfs", (ep->e_flags & NFSEXP_PNFS)? "" : "no_"); + fprintf(fp, "%spnfs,", (ep->e_flags & NFSEXP_PNFS)? "" : "no_"); if (ep->e_flags & NFSEXP_FSID) { fprintf(fp, "fsid=%d,", ep->e_fsid); }
When using pnfs with "fsid=0", exportfs prints error as, # exportfs -a exportfs: /var/lib/nfs/etab:1: unknown keyword "no_pnfsfsid=0" Commit cdd16bef98 ("nfs-utils: add support for the "pnfs" export option") miss the comma after "pnfs"/"on_pnfs" operation. Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> --- support/nfs/exports.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)