From patchwork Tue Jun 2 10:59:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 6528311 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C28C5C0020 for ; Tue, 2 Jun 2015 10:59:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E4D4C2051F for ; Tue, 2 Jun 2015 10:59:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E80C4204FB for ; Tue, 2 Jun 2015 10:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753073AbbFBK71 (ORCPT ); Tue, 2 Jun 2015 06:59:27 -0400 Received: from mail-qc0-f179.google.com ([209.85.216.179]:33103 "EHLO mail-qc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbbFBK70 (ORCPT ); Tue, 2 Jun 2015 06:59:26 -0400 Received: by qcmi9 with SMTP id i9so57975560qcm.0 for ; Tue, 02 Jun 2015 03:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=WegP+wYlqR5Hir87nmuL+NAe9SHM0k6IHlnoxnYWDTc=; b=CCpswGjOB5Va0Kjp3gJJFgl/+JBkVT3mJgPt5OhtxstbnlmqrfocuYLJLHrn8hrS6y sd1tBDP6BXYv97+TfbV2gRgWSAI+CtZe+2g0bAL5BRw+k5l6O1/48EwH8yFpu9lF8rFJ kmGr6BVXCX80mU5A87cF4eI/b7D95/Lc6I+9PeHtzScwb43n8d9TRDqoafnfwIBybxnZ VQjwCZzl9nH70fETARY3/uuSU1IIrXt8iHLQj2AuOt2lEdHG+oDIY5JpjhvWc8KT2irw +YGcbuva1/RxJamdFcJznNXQZgpRLIAI4ATyYR+SmnFdsmL1+1fNhUY2JUvtbsUHC4I6 WphQ== X-Received: by 10.229.249.6 with SMTP id mi6mr29222616qcb.24.1433242765914; Tue, 02 Jun 2015 03:59:25 -0700 (PDT) Received: from [192.168.99.20] ([104.143.41.79]) by mx.google.com with ESMTPSA id e71sm2244072qka.40.2015.06.02.03.59.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jun 2015 03:59:25 -0700 (PDT) Message-ID: <556D8C87.2000507@gmail.com> Date: Tue, 02 Jun 2015 18:59:19 +0800 From: Kinglong Mee User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "J. Bruce Fields" , "linux-nfs@vger.kernel.org" CC: Christoph Hellwig , Trond Myklebust , kinglongmee@gmail.com Subject: [PATCH 1/2] nfsd: Reset cb_status in nfsd4_cb_prepare() at retrying Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP nfsd enters a infinite loop and print message per 10 seconds, May 31 18:33:52 test-server kernel: Error sending entire callback! May 31 18:34:01 test-server kernel: Error sending entire callback! It is caused by a cb_layoutreturn got error -10008 (NFS4ERR_DELAY), and then, the client crash, nfsd enter the infinite loop. bc_sendto --> call_timeout --> nfsd4_cb_done --> nfsd4_cb_layout_done with error -10008 --> rpc_delay(task, HZ/100) --> bc_sendto ... Signed-off-by: Kinglong Mee --- fs/nfsd/nfs4callback.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 5694cfb..8b1ac8d 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -875,6 +875,7 @@ static void nfsd4_cb_prepare(struct rpc_task *task, void *calldata) u32 minorversion = clp->cl_minorversion; cb->cb_minorversion = minorversion; + cb->cb_status = 0; if (minorversion) { if (!nfsd41_cb_get_slot(clp, task)) return;