From patchwork Sat Jun 6 14:41:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 6559701 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 703C29F444 for ; Sat, 6 Jun 2015 14:41:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9CB652061E for ; Sat, 6 Jun 2015 14:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFE4320620 for ; Sat, 6 Jun 2015 14:41:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbbFFOll (ORCPT ); Sat, 6 Jun 2015 10:41:41 -0400 Received: from mail-qc0-f195.google.com ([209.85.216.195]:35219 "EHLO mail-qc0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813AbbFFOlk (ORCPT ); Sat, 6 Jun 2015 10:41:40 -0400 Received: by qcvp6 with SMTP id p6so4424268qcv.2; Sat, 06 Jun 2015 07:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; bh=N9X1u5a14A1dtxyj5jwng+HuJIi29ncKCg12KclIEWw=; b=qrmxTnkEBlcyXUpwvhHh7ucQM8mgZOA7SQoG9hB9C8gBRUv+1VdUMZh5ZqmAJpfwtw k7581juCO5ywYWYSY4UZSmH0gyqydAFEdZfjza+vtXvlvXjpc/FAXL/KdKaU35u3SmS1 VCHSX8wrJBCM/zt4yL7g9erA/lmN4qXj8jhNdg9qmrHDVHl1WHR2yvk7vIUzw/FQBJNc vMBnAklVy0YQlhTo+G0y9OjegnNWBWkiIloJYPRxbpJTs6Ie2LLFz+3rZNWumnbZUI4Y hi3v5fsfZVyKiQ22sUMk/QPMcDY0n6LZYtf3CYcF/ewuHE5pGAf/cj6FdJ4OyoQI8w2t WtFw== X-Received: by 10.140.231.19 with SMTP id b19mr10106895qhc.22.1433601699523; Sat, 06 Jun 2015 07:41:39 -0700 (PDT) Received: from [192.168.99.5] ([104.143.41.79]) by mx.google.com with ESMTPSA id 10sm5415210qkp.39.2015.06.06.07.41.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Jun 2015 07:41:39 -0700 (PDT) Message-ID: <5573069D.9050401@gmail.com> Date: Sat, 06 Jun 2015 22:41:33 +0800 From: Kinglong Mee User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Al Viro , "J. Bruce Fields" , linux-fsdevel@vger.kernel.org, "linux-nfs@vger.kernel.org" CC: NeilBrown , Trond Myklebust , kinglongmee@gmail.com Subject: [PATCH 1/5 v4] fs_pin: Initialize value for fs_pin explicitly Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Without initialized, done in fs_pin at stack space may contains strange value. v3, v4, Adds macro for header file Signed-off-by: Kinglong Mee --- include/linux/fs_pin.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/fs_pin.h b/include/linux/fs_pin.h index 3886b3b..0dde7b7 100644 --- a/include/linux/fs_pin.h +++ b/include/linux/fs_pin.h @@ -1,3 +1,6 @@ +#ifndef _LINUX_FS_PIN_H +#define _LINUX_FS_PIN_H + #include struct fs_pin { @@ -16,9 +19,12 @@ static inline void init_fs_pin(struct fs_pin *p, void (*kill)(struct fs_pin *)) INIT_HLIST_NODE(&p->s_list); INIT_HLIST_NODE(&p->m_list); p->kill = kill; + p->done = 0; } void pin_remove(struct fs_pin *); void pin_insert_group(struct fs_pin *, struct vfsmount *, struct hlist_head *); void pin_insert(struct fs_pin *, struct vfsmount *); void pin_kill(struct fs_pin *); + +#endif