From patchwork Wed Jun 17 07:49:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 6622441 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5215E9F326 for ; Wed, 17 Jun 2015 07:49:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8967A20834 for ; Wed, 17 Jun 2015 07:49:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AA7D20836 for ; Wed, 17 Jun 2015 07:49:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932440AbbFQHtt (ORCPT ); Wed, 17 Jun 2015 03:49:49 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:35329 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932439AbbFQHtr (ORCPT ); Wed, 17 Jun 2015 03:49:47 -0400 Received: by pdbnf5 with SMTP id nf5so32890122pdb.2; Wed, 17 Jun 2015 00:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=IfXFG4GAnUQdL0ojsszuuhKgL3z4F4kbGq9YIM2eN/0=; b=YRpLHmd0sNfRc/36SpwvqqKOqIB1JMFwx6U3J0qiiOCpy/XFEbmFg1eXJ3I3CPyFEE TWh2ro3ytzV89XXUDARl/ML0TvZfWM6gh+eZL0YAZEDcg78PM03TiUUAdmhZbiePRDKB mFKtCXmxo9IlcRCIEtgWofTKb8ywn16lZrQRRdMGVOuxQZnlVpQ0JSVFGE9Rl6cJj6Id wD1aRUB2jDH0UqjyQ+qWAs0AWV4lLFmT77otPNVtEEJd7jI88NVLYSLK12nNhWqjn619 ZJOvzNTKJRT0enSlu/gAPXc6Ef8LjHIOrT50K6PqR8DrFhdssbdfHB+j9EnCZmTnhJeV 9V+Q== X-Received: by 10.70.20.196 with SMTP id p4mr8374785pde.58.1434527387270; Wed, 17 Jun 2015 00:49:47 -0700 (PDT) Received: from [192.168.99.30] ([104.143.41.79]) by mx.google.com with ESMTPSA id jt2sm3669454pbc.21.2015.06.17.00.49.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jun 2015 00:49:46 -0700 (PDT) Message-ID: <55812695.8020401@gmail.com> Date: Wed, 17 Jun 2015 15:49:41 +0800 From: Kinglong Mee User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Al Viro , "J. Bruce Fields" , "linux-nfs@vger.kernel.org" , linux-fsdevel@vger.kernel.org CC: NeilBrown , Trond Myklebust , kinglongmee@gmail.com Subject: [PATCH 1/6 v5] fs_pin: Initialize value for fs_pin explicitly References: <5581266C.9080404@gmail.com> In-Reply-To: <5581266C.9080404@gmail.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Without initialized, done in fs_pin at stack space may contains strange value. v3, v4, v5, Adds macro for header file Signed-off-by: Kinglong Mee --- include/linux/fs_pin.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/fs_pin.h b/include/linux/fs_pin.h index 3886b3b..0dde7b7 100644 --- a/include/linux/fs_pin.h +++ b/include/linux/fs_pin.h @@ -1,3 +1,6 @@ +#ifndef _LINUX_FS_PIN_H +#define _LINUX_FS_PIN_H + #include struct fs_pin { @@ -16,9 +19,12 @@ static inline void init_fs_pin(struct fs_pin *p, void (*kill)(struct fs_pin *)) INIT_HLIST_NODE(&p->s_list); INIT_HLIST_NODE(&p->m_list); p->kill = kill; + p->done = 0; } void pin_remove(struct fs_pin *); void pin_insert_group(struct fs_pin *, struct vfsmount *, struct hlist_head *); void pin_insert(struct fs_pin *, struct vfsmount *); void pin_kill(struct fs_pin *); + +#endif