From patchwork Thu Jun 18 08:04:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Blomdell X-Patchwork-Id: 6634351 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5CD579F399 for ; Thu, 18 Jun 2015 08:23:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 890EE2068C for ; Thu, 18 Jun 2015 08:23:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB82020668 for ; Thu, 18 Jun 2015 08:23:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbbFRIXM (ORCPT ); Thu, 18 Jun 2015 04:23:12 -0400 Received: from sperry-03.control.lth.se ([130.235.83.190]:53577 "EHLO sperry-03.control.lth.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbbFRIXK (ORCPT ); Thu, 18 Jun 2015 04:23:10 -0400 X-Greylist: delayed 1117 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Jun 2015 04:23:09 EDT Received: from [130.235.83.12] (lie.control.lth.se [130.235.83.12]) (authenticated bits=0) by sperry-03.control.lth.se (8.14.4/8.14.4) with ESMTP id t5I84Tja017271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Thu, 18 Jun 2015 10:04:29 +0200 Message-ID: <55827B8D.3070103@control.lth.se> Date: Thu, 18 Jun 2015 10:04:29 +0200 From: Anders Blomdell User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: linux-nfs@vger.kernel.org Subject: Mount regression between 4.0.4 client and 2.6.35 server Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I have a problem with a 4.0.4 client refusing to mount from a 2.6.35 server due to NFS4ERR_INVAL returned during nfs4_discover_server_trunking. See https://bugzilla.redhat.com/show_bug.cgi?id=1228272. Proposed patch attached. Regards Anders Blomdell Minimum viable patch to continue version autonegotiotion in case where the server returns an unexpected NFS4ERR_INVAL, which happens for a 4.0.4-303.fc22.x86_64 client talking to a 2.6.35.14-106.fc14.i686.PAE server, see https://bugzilla.redhat.com/show_bug.cgi?id=1228272 Signed-off-by: Anders Blomdell --- utils/mount/stropts.c.orig 2015-06-18 09:51:02.091148891 +0200 +++ utils/mount/stropts.c 2015-06-18 09:48:56.859970023 +0200 @@ -838,6 +838,10 @@ check_result: return result; switch (errno) { + case EIO: + /* Fix to handle nfs4_discover_server_trunking returning + * EIO in case where nfs server returns NFS4ERR_INVAL, + * see https://bugzilla.redhat.com/show_bug.cgi?id=1228272 */ case EPROTONOSUPPORT: /* A clear indication that the server or our * client does not support NFS version 4 and minor */