| Message ID | 55A375A1.4000800@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Kinglong, I meant to describe the rational as a comment in the code, not as a more verbose commit log. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 7/13/2015 17:01, Christoph Hellwig wrote: > Hi Kinglong, > > I meant to describe the rational as a comment in the code, not as > a more verbose commit log. Sorry for my mistake, I will update it later. Thanks again. thanks, Kinglong Mee -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/utils/blkmapd/device-inq.c b/utils/blkmapd/device-inq.c index 6b56b67..57fe7a3 100644 --- a/utils/blkmapd/device-inq.c +++ b/utils/blkmapd/device-inq.c @@ -198,7 +198,7 @@ struct bl_serial *bldev_read_serial(int fd, const char *filename) dev_id = (struct bl_dev_id *)&(dev_root->data[pos]); pos += (dev_id->len + devid_len); - if ((dev_id->ids & 0xf) < current_id) + if ((dev_id->ids & 0xf) < current_id || !dev_id->len) continue; switch (dev_id->ids & 0xf) { /* We process SCSI ID with four ID cases: 0, 1, 2 and 3.
In vmware linux, the iscsi device contains more than one SCSI ID, and, the second one's data length is zero. If there are two iSCSI devices with the second SCSI ID's data length is zero, the first iSCSI device will record with an invalid SCSI ID as zero length, the second one will be treat as the first one for the SCSI ID is zero length too. It means the only the first iSCSI device is exist in blkmapd's cache, the request for the second iSCSI device will failed as, "blkmapd: Could not find disk for device" and, "bl_resolve_deviceid failed to decode device: 2". v2, update comments Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> --- utils/blkmapd/device-inq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)