From patchwork Mon Nov 6 13:24:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Averin X-Patchwork-Id: 10043445 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DD437602BF for ; Mon, 6 Nov 2017 13:24:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4DFC286C2 for ; Mon, 6 Nov 2017 13:24:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C99CD286CB; Mon, 6 Nov 2017 13:24:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E71A285CB for ; Mon, 6 Nov 2017 13:24:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753113AbdKFNY2 (ORCPT ); Mon, 6 Nov 2017 08:24:28 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:4711 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbdKFNY1 (ORCPT ); Mon, 6 Nov 2017 08:24:27 -0500 Received: from [172.16.24.21] (msk-vpn.virtuozzo.com [195.214.232.6]) by relay.sw.ru (8.13.4/8.13.4) with ESMTP id vA6DOEtH000050; Mon, 6 Nov 2017 16:24:14 +0300 (MSK) From: Vasily Averin Subject: [PATCH v3 07/21] nfs4blocklayout: exit_net cleanup check added To: netdev@vger.kernel.org Cc: "J. Bruce Fields" , Jeff Layton , linux-nfs@vger.kernel.org, Trond Myklebust , Anna Schumaker References: <4fdc4264-e338-6ee8-a662-7d98b45733a1@virtuozzo.com> Message-ID: <87a33322-18a9-a451-e69a-505eddb99333@virtuozzo.com> Date: Mon, 6 Nov 2017 16:24:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4fdc4264-e338-6ee8-a662-7d98b45733a1@virtuozzo.com> Content-Language: en-US Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Be sure that bl_wq wait queue initialized in net_init hook is not used anymore. Signed-off-by: Vasily Averin --- fs/nfs/blocklayout/rpc_pipefs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/nfs/blocklayout/rpc_pipefs.c b/fs/nfs/blocklayout/rpc_pipefs.c index 9fb067a6..8c3941b 100644 --- a/fs/nfs/blocklayout/rpc_pipefs.c +++ b/fs/nfs/blocklayout/rpc_pipefs.c @@ -256,6 +256,9 @@ static void nfs4blocklayout_net_exit(struct net *net) nfs4blocklayout_unregister_net(net, nn->bl_device_pipe); rpc_destroy_pipe_data(nn->bl_device_pipe); nn->bl_device_pipe = NULL; + WARN_ONCE(!list_empty(&nn->bl_wq.head), + "net %x %s: bl_wq head is not empty\n", + net->ns.inum, __func__); } static struct pernet_operations nfs4blocklayout_net_ops = {