From patchwork Tue Jan 30 19:23:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kenneth Dsouza X-Patchwork-Id: 10192305 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4295160375 for ; Tue, 30 Jan 2018 19:23:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3211C205AD for ; Tue, 30 Jan 2018 19:23:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 26C17268AE; Tue, 30 Jan 2018 19:23:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1C1E205AD for ; Tue, 30 Jan 2018 19:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751559AbeA3TXH (ORCPT ); Tue, 30 Jan 2018 14:23:07 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:41752 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbeA3TXG (ORCPT ); Tue, 30 Jan 2018 14:23:06 -0500 Received: by mail-lf0-f65.google.com with SMTP id f136so17033117lff.8 for ; Tue, 30 Jan 2018 11:23:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=9IrnUeF/kWo8hKUzKI6dz9kIGkhU3OS5djHwD4onFFA=; b=okniXN9gE0HaqvMxDtKXr9N6akLM7mHJTSWIK2nLNpGqEiNDQPwZrOGNGFnEmQYPQ2 S2SxF4IJs22Nuyc9FxbiLVM1iVNqr2Nrlw8SnM1c5Z9e9Ey00EZc6p6mB+LhI2CqzCx8 E9/9NsZ+Mmkg9brGU5aMve6tQS/acUz5OYwOdxLj0XpAg5+Srsu2vZFIBxMXoR0ol/Jn z1G/DqguDNUyrpa+E9aEhm/YR3HzRKDFET31jZvUzcIyzJ+V1nRRjw1FLsz87BaaXWaO zZxofFiI6En1UdrrwO03zIzefk4PTodtCKvUE/P4mHF3ZrlzjjM4J577XFf1s0nT+WHc 1Zgw== X-Gm-Message-State: AKwxyteP6yRsEclYKUFXfdV8qplRkzzRTiO7exC04OhngOiTjgJ9WQRw geY0RrBSPVpDtdzBFTaoGEKiSMqydjBNuoEYAlwMbTYN X-Google-Smtp-Source: AH8x224Ub8MdJLJBUY+EDqGV9R6dlK9Ik0mM6EMYoyXLDFHktfCzPN/j7/8QW8S0E+NLGtpVdaJixMUJaUkXcG2i2e0= X-Received: by 10.25.208.210 with SMTP id h201mr15854476lfg.22.1517340184736; Tue, 30 Jan 2018 11:23:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.17.221 with HTTP; Tue, 30 Jan 2018 11:23:04 -0800 (PST) From: Kenneth Dsouza Date: Wed, 31 Jan 2018 00:53:04 +0530 Message-ID: Subject: [PATCH] nfs4_getfacl: Add support to accept more paths To: linux-nfs@vger.kernel.org Cc: bfields@fieldses.org Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, nfs4_getfacl accepts only a single path at a time, which makes us run the command several times. This patch will help us to list (ACL) on multiple files at a time. nfs4getfacl file ... --- nfs4_getfacl/nfs4_getfacl.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) usage(1); res = 0; @@ -68,12 +64,15 @@ int main(int argc, char **argv) res = 0; goto out; } - acl = nfs4_acl_for_path(argv[1]); + for (counter = 1; counter < agrc; counter++) { + acl = nfs4_acl_for_path(argv[counter]); if (acl != NULL) { + printf("\n# file: %s\n", argv[counter]); nfs4_print_acl(stdout, acl); nfs4_free_acl(acl); res = 0; } + } out: return res; } diff --git a/nfs4_getfacl/nfs4_getfacl.c b/nfs4_getfacl/nfs4_getfacl.c index 5363096..bbbbb62 100644 --- a/nfs4_getfacl/nfs4_getfacl.c +++ b/nfs4_getfacl/nfs4_getfacl.c @@ -48,17 +48,13 @@ int main(int argc, char **argv) { struct nfs4_acl *acl; int res = 1; - + int count = 1; execname = basename(argv[0]); if (argc < 2) { fprintf(stderr, "%s: you must specify a path.\n", execname); usage(0); goto out; - } else if (argc > 2) { - fprintf(stderr, "%s: currently, you may only specify a single path.\n", execname); - usage(0); - goto out; } else if (!strcmp(argv[1], "-?") || !strcmp(argv[1], "-h") || !strcmp(argv[1], "--help")) {