From patchwork Thu Apr 18 02:31:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2457261 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id A79DDDF23A for ; Thu, 18 Apr 2013 02:31:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964925Ab3DRCbW (ORCPT ); Wed, 17 Apr 2013 22:31:22 -0400 Received: from mail-we0-f176.google.com ([74.125.82.176]:38280 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964932Ab3DRCbS (ORCPT ); Wed, 17 Apr 2013 22:31:18 -0400 Received: by mail-we0-f176.google.com with SMTP id s43so1709269wey.21 for ; Wed, 17 Apr 2013 19:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=tK84S81EAWkuSMbDjrLrLSKspwcb24aFC+2jXq2TqrY=; b=DHodM/IrF1Da+N9OZvT1bkr9XhtkR4MdvNpAR2OKvuqh+FVQT2av141Pg9lvvQMZ28 rT5gKwI0LdpMA/egYlWXJPWjSe6UQAILvqkIr62DOGk/uFtZc5PLGXF9J4t+eOJFStTh quBgPXDsxDYvWYdM8pXUkzN5OJqR2o56U/pnVzdw7W7q4Mu+YUfvaLkVIhpxRbt6r2In QBQH3psKWjBNAlF/eKVGr1/XuQ+MTJNC7+Tk/yzg2Qv4Z7cS4HCFAKNoVlMVeuON1nc/ kh1yaZvdKywXyGGDfovai2T8kcQYfzynanvBHQuug6rp0NqEb8msUQ//tjDpene9KbjK cmcQ== MIME-Version: 1.0 X-Received: by 10.194.83.33 with SMTP id n1mr15293704wjy.7.1366252277405; Wed, 17 Apr 2013 19:31:17 -0700 (PDT) Received: by 10.194.51.1 with HTTP; Wed, 17 Apr 2013 19:31:17 -0700 (PDT) Date: Thu, 18 Apr 2013 10:31:17 +0800 Message-ID: Subject: [PATCH] svcauth_gss: fix error return code in rsc_parse() From: Wei Yongjun To: bfields@fieldses.org, Trond.Myklebust@netapp.com, ebiederm@xmission.com, skinsbursky@parallels.com, jlayton@redhat.com, simo@redhat.com Cc: yongjun_wei@trendmicro.com.cn, linux-nfs@vger.kernel.org Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun --- net/sunrpc/auth_gss/svcauth_gss.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index 5ead605..c2156fb 100644 --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c @@ -505,8 +505,10 @@ static int rsc_parse(struct cache_detail *cd, len = qword_get(&mesg, buf, mlen); if (len > 0) { rsci.cred.cr_principal = kstrdup(buf, GFP_KERNEL); - if (!rsci.cred.cr_principal) + if (!rsci.cred.cr_principal) { + status = -ENOMEM; goto out; + } } }