| Message ID | CAPgLHd8a+6FGVDScg25XGKc8bAZDdkS6aU4tmknyDMKvZ-DgDg@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: linux-nfs-owner@vger.kernel.org [mailto:linux-nfs-owner@vger.kernel.org] On Behalf Of Wei > Yongjun > Sent: Wednesday, September 05, 2012 2:38 PM > To: Trond.Myklebust@netapp.com > Cc: yongjun_wei@trendmicro.com.cn; linux-nfs@vger.kernel.org > Subject: [PATCH] pnfsblock: use list_move_tail instead of list_del/list_add_tail > > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Using list_move_tail() instead of list_del() + list_add_tail(). > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> This looks good. Thanks! Reviewed-by: Peng Tao <tao.peng@emc.com> > --- > fs/nfs/blocklayout/extents.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/nfs/blocklayout/extents.c b/fs/nfs/blocklayout/extents.c > index 1f9a603..9c3e117 100644 > --- a/fs/nfs/blocklayout/extents.c > +++ b/fs/nfs/blocklayout/extents.c > @@ -683,8 +683,7 @@ encode_pnfs_block_layoutupdate(struct pnfs_block_layout *bl, > p = xdr_encode_hyper(p, lce->bse_length << SECTOR_SHIFT); > p = xdr_encode_hyper(p, 0LL); > *p++ = cpu_to_be32(PNFS_BLOCK_READWRITE_DATA); > - list_del(&lce->bse_node); > - list_add_tail(&lce->bse_node, &bl->bl_committing); > + list_move_tail(&lce->bse_node, &bl->bl_committing); > bl->bl_count--; > count++; > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/nfs/blocklayout/extents.c b/fs/nfs/blocklayout/extents.c index 1f9a603..9c3e117 100644 --- a/fs/nfs/blocklayout/extents.c +++ b/fs/nfs/blocklayout/extents.c @@ -683,8 +683,7 @@ encode_pnfs_block_layoutupdate(struct pnfs_block_layout *bl, p = xdr_encode_hyper(p, lce->bse_length << SECTOR_SHIFT); p = xdr_encode_hyper(p, 0LL); *p++ = cpu_to_be32(PNFS_BLOCK_READWRITE_DATA); - list_del(&lce->bse_node); - list_add_tail(&lce->bse_node, &bl->bl_committing); + list_move_tail(&lce->bse_node, &bl->bl_committing); bl->bl_count--; count++; }