From patchwork Thu Aug 22 14:12:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Staubach X-Patchwork-Id: 2848283 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A36BEBF546 for ; Thu, 22 Aug 2013 14:21:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8D0FC205F1 for ; Thu, 22 Aug 2013 14:21:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D20B205EA for ; Thu, 22 Aug 2013 14:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752790Ab3HVOVf (ORCPT ); Thu, 22 Aug 2013 10:21:35 -0400 Received: from p02c11o142.mxlogic.net ([208.65.144.75]:59796 "EHLO p02c11o142.mxlogic.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516Ab3HVOVf convert rfc822-to-8bit (ORCPT ); Thu, 22 Aug 2013 10:21:35 -0400 X-Greylist: delayed 461 seconds by postgrey-1.27 at vger.kernel.org; Thu, 22 Aug 2013 10:21:34 EDT Received: from unknown [69.84.133.248] (EHLO IT-1874.Isys.com) by p02c11o142.mxlogic.net(mxl_mta-7.1.0-4) with ESMTP id e6e16125.2ace31254940.150086.00-571.325785.p02c11o142.mxlogic.net (envelope-from ); Thu, 22 Aug 2013 08:21:34 -0600 (MDT) X-MXL-Hash: 52161e6e311abbf2-648d98db1a39ed8105f956013a9d4c08653c56bb Received: from unknown [69.84.133.248] (EHLO IT-1874.Isys.com) by p02c11o142.mxlogic.net(mxl_mta-7.1.0-4) over TLS secured channel with ESMTP id b5c16125.0.143551.00-331.309194.p02c11o142.mxlogic.net (envelope-from ); Thu, 22 Aug 2013 08:12:46 -0600 (MDT) X-MXL-Hash: 52161c5e5b33d446-8204e2a78d3f1a027203591bcb991223c9de1434 Received: from IT-1874.Isys.com ([172.20.0.223]) by IT-1874.Isys.com ([172.20.0.223]) with mapi; Thu, 22 Aug 2013 10:12:42 -0400 From: Peter Staubach To: Trond Myklebust , "linux-nfs@vger.kernel.org" Date: Thu, 22 Aug 2013 10:12:41 -0400 Subject: RE: [PATCH 1/6] NFSv3: Deal with a sparse warning in nfs3_proc_create Thread-Topic: [PATCH 1/6] NFSv3: Deal with a sparse warning in nfs3_proc_create Thread-Index: Ac6ezkK4OnPzvjZXRGmOxLUexYBiUQAcxqRw Message-ID: References: <1377131186-40249-1-git-send-email-Trond.Myklebust@netapp.com> In-Reply-To: <1377131186-40249-1-git-send-email-Trond.Myklebust@netapp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-AnalysisOut: [v=2.0 cv=fOyOK+me c=1 sm=1 a=YmXeKoonWU0GTmr6cORa5w==:17 a] X-AnalysisOut: [=2mke-WeS7EQA:10 a=ooaBVg03rvgA:10 a=BLceEmwcHowA:10 a=kj9] X-AnalysisOut: [zAlcOel0A:10 a=ZC8462-RAAAA:8 a=_njUq414AAAA:8 a=FjgHV-MlF] X-AnalysisOut: [2UA:10 a=VwQbUJbxAAAA:8 a=JDjsHSkAAAAA:8 a=mdzaXZBg7K65XGG] X-AnalysisOut: [7ovgA:9 a=CjuIK1q_8ugA:10 a=x8gzFH9gYPwA:10 a=Hf6muOzgCGQA] X-AnalysisOut: [:10 a=-Hszx4VbP8eRiZJZ:21 a=QX1eGmEkQ0fliQRZ:21] X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-MAIL-FROM: X-SOURCE-IP: [69.84.133.248] Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RDNS_NONE,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It seems a shame to byte swap something which doesn't really need to be byte swapped. It is pretty much just an opaque value that the server stores and then checks during possible retransmits. I suppose that it is cheap enough to do, not so many times per second. Thanx... ps -----Original Message----- From: linux-nfs-owner@vger.kernel.org [mailto:linux-nfs-owner@vger.kernel.org] On Behalf Of Trond Myklebust Sent: Wednesday, August 21, 2013 8:26 PM To: linux-nfs@vger.kernel.org Subject: [PATCH 1/6] NFSv3: Deal with a sparse warning in nfs3_proc_create Signed-off-by: Trond Myklebust --- fs/nfs/nfs3proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/nfs/nfs3proc.c b/fs/nfs/nfs3proc.c index f5c84c3..1db588a 100644 --- a/fs/nfs/nfs3proc.c +++ b/fs/nfs/nfs3proc.c @@ -336,8 +336,8 @@ nfs3_proc_create(struct inode *dir, struct dentry *dentry, struct iattr *sattr, data->arg.create.createmode = NFS3_CREATE_UNCHECKED; if (flags & O_EXCL) { data->arg.create.createmode = NFS3_CREATE_EXCLUSIVE; - data->arg.create.verifier[0] = jiffies; - data->arg.create.verifier[1] = current->pid; + data->arg.create.verifier[0] = cpu_to_be32(jiffies); + data->arg.create.verifier[1] = cpu_to_be32(current->pid); } sattr->ia_mode &= ~current_umask();