From patchwork Fri Dec 7 23:46:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Eshel X-Patchwork-Id: 1852131 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E47F1DF2EE for ; Fri, 7 Dec 2012 23:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754027Ab2LGXqR (ORCPT ); Fri, 7 Dec 2012 18:46:17 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:36980 "EHLO e9.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754348Ab2LGXqQ (ORCPT ); Fri, 7 Dec 2012 18:46:16 -0500 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 7 Dec 2012 18:46:15 -0500 Received: from d01dlp01.pok.ibm.com (9.56.250.166) by e9.ny.us.ibm.com (192.168.1.109) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 7 Dec 2012 18:46:12 -0500 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id A925538C8045; Fri, 7 Dec 2012 18:46:12 -0500 (EST) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qB7NkCtY301390; Fri, 7 Dec 2012 18:46:12 -0500 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qB7NkBgq011302; Fri, 7 Dec 2012 18:46:11 -0500 Received: from d01ml604.pok.ibm.com (d01ml604.pok.ibm.com [9.63.8.151]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id qB7NkB2R011299; Fri, 7 Dec 2012 18:46:11 -0500 In-Reply-To: References: To: "Myklebust, Trond" Cc: "J. Bruce Fields" , linux-nfs@vger.kernel.org, linux-nfs-owner@vger.kernel.org MIME-Version: 1.0 Subject: Re: notify_deviceid_type4 X-KeepSent: B389C816:CDC36461-88257ACD:0082322A; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3 September 15, 2011 Message-ID: From: Marc Eshel Date: Fri, 7 Dec 2012 15:46:11 -0800 X-MIMETrack: Serialize by Router on D01ML604/01/M/IBM(Release 8.5.3FP2 ZX853FP2HF2|October 8, 2012) at 12/07/2012 18:46:10, Serialize complete at 12/07/2012 18:46:10 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12120723-7182-0000-0000-000003A16AC5 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Trond, can you please apply the following patch so we are in compliance with the spec. Thanks, Marc. ------------------------------------------------------------------------------------------------------------- The spec defines notify_deviceid_type4 as: 20.12.1. ARGUMENT /* * Device notification types. */ enum notify_deviceid_type4 { NOTIFY_DEVICEID4_CHANGE = 1, NOTIFY_DEVICEID4_DELETE = 2 }; --- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/nfs4.h b/include/linux/nfs4.h index 59cc833..ad32df5 100644 --- a/include/linux/nfs4.h +++ b/include/linux/nfs4.h @@ -499,8 +499,8 @@ enum pnfs_iomode { }; enum pnfs_notify_deviceid_type4 { - NOTIFY_DEVICEID4_CHANGE = 1 << 1, - NOTIFY_DEVICEID4_DELETE = 1 << 2, + NOTIFY_DEVICEID4_CHANGE = 1, + NOTIFY_DEVICEID4_DELETE = 2, }; #define NFL4_UFLG_MASK 0x0000003F