diff mbox series

nfsdcld: prevent from accessing /var/lib/nfs/nfsdcld in read-only file system during boot

Message ID OSZPR01MB7772A3965EF12B8BEBFEAA7A88722@OSZPR01MB7772.jpnprd01.prod.outlook.com (mailing list archive)
State New
Headers show
Series nfsdcld: prevent from accessing /var/lib/nfs/nfsdcld in read-only file system during boot | expand

Commit Message

Seiichi Ikarashi (Fujitsu) Oct. 4, 2024, 9:04 a.m. UTC 
I saw a VMWare guest that hit a rare condition during boot;
nfsdcld started too early to check access on /var/lib/nfs/nfsdcld which were
still in read-only file system as follows:

  nfsdcld[...]: Unexpected error when checking access on /var/lib/nfs/nfsdcld: Read-only file system
  systemd[1]: nfsdcld.service: Main process exited, code=exited, status=226/NAMESPACE
  systemd[1]: nfsdcld.service: Failed with result 'exit-code'.

nfsdcld.service needs to wait the root file system to be remounted at least.

Signed-off-by: Seiichi Ikarashi <s.ikarashi@fujitsu.com>
---
 systemd/nfsdcld.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Layton Oct. 4, 2024, 2:43 p.m. UTC | #1 
On Fri, 2024-10-04 at 09:04 +0000, Seiichi Ikarashi (Fujitsu) wrote:
> I saw a VMWare guest that hit a rare condition during boot;
> nfsdcld started too early to check access on /var/lib/nfs/nfsdcld which were
> still in read-only file system as follows:
> 
>   nfsdcld[...]: Unexpected error when checking access on /var/lib/nfs/nfsdcld: Read-only file system
>   systemd[1]: nfsdcld.service: Main process exited, code=exited, status=226/NAMESPACE
>   systemd[1]: nfsdcld.service: Failed with result 'exit-code'.
> 
> nfsdcld.service needs to wait the root file system to be remounted at least.
> 
> Signed-off-by: Seiichi Ikarashi <s.ikarashi@fujitsu.com>
> ---
>  systemd/nfsdcld.service | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/systemd/nfsdcld.service b/systemd/nfsdcld.service
> index 3ced565..188123d 100644
> --- a/systemd/nfsdcld.service
> +++ b/systemd/nfsdcld.service
> @@ -4,7 +4,7 @@ Documentation=man:nfsdcld(8)
>  DefaultDependencies=no
>  Conflicts=umount.target
>  Requires=rpc_pipefs.target proc-fs-nfsd.mount
> -After=rpc_pipefs.target proc-fs-nfsd.mount
> +After=rpc_pipefs.target proc-fs-nfsd.mount systemd-remount-fs.service
>  
>  [Service]
>  Type=forking
> 

Good catch! Seems like a reasonable fix.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
diff mbox series

Patch

diff --git a/systemd/nfsdcld.service b/systemd/nfsdcld.service
index 3ced565..188123d 100644
--- a/systemd/nfsdcld.service
+++ b/systemd/nfsdcld.service
@@ -4,7 +4,7 @@  Documentation=man:nfsdcld(8)
 DefaultDependencies=no
 Conflicts=umount.target
 Requires=rpc_pipefs.target proc-fs-nfsd.mount
-After=rpc_pipefs.target proc-fs-nfsd.mount
+After=rpc_pipefs.target proc-fs-nfsd.mount systemd-remount-fs.service
 
 [Service]
 Type=forking