From patchwork Tue Jun 7 17:33:11 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Rees X-Patchwork-Id: 858522 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p57HXFxq015750 for ; Tue, 7 Jun 2011 17:33:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755451Ab1FGRdO (ORCPT ); Tue, 7 Jun 2011 13:33:14 -0400 Received: from int-mailstore01.merit.edu ([207.75.116.232]:51734 "EHLO int-mailstore01.merit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757391Ab1FGRdN (ORCPT ); Tue, 7 Jun 2011 13:33:13 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by int-mailstore01.merit.edu (Postfix) with ESMTP id 3D0893083A6D; Tue, 7 Jun 2011 13:33:13 -0400 (EDT) X-Virus-Scanned: amavisd-new at int-mailstore01.merit.edu Received: from int-mailstore01.merit.edu ([127.0.0.1]) by localhost (int-mailstore01.merit.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qEJsuP2VcAVV; Tue, 7 Jun 2011 13:33:12 -0400 (EDT) Received: from merit.edu (host-17.subnet-17.med.umich.edu [141.214.17.17]) by int-mailstore01.merit.edu (Postfix) with ESMTPSA id 953423055B74; Tue, 7 Jun 2011 13:33:12 -0400 (EDT) Date: Tue, 7 Jun 2011 13:33:11 -0400 From: Jim Rees To: Benny Halevy Cc: linux-nfs@vger.kernel.org, peter honeyman Subject: [PATCH 60/88] SQUASHME: pnfs-block: nfs4_blk_add_block_disk ret must be signed Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 07 Jun 2011 17:33:15 +0000 (UTC) From: Benny Halevy otherwise checking for ret < 0 is futile. Signed-off-by: Benny Halevy --- fs/nfs/blocklayout/blocklayoutdev.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/nfs/blocklayout/blocklayoutdev.c b/fs/nfs/blocklayout/blocklayoutdev.c index ef39c36..a866f5c 100644 --- a/fs/nfs/blocklayout/blocklayoutdev.c +++ b/fs/nfs/blocklayout/blocklayoutdev.c @@ -105,7 +105,8 @@ nfs4_blk_add_block_disk(struct device *cdev, static char *claim_ptr = "I belong to pnfs block driver"; struct block_device *bdev; struct gendisk *gd; - unsigned int major, minor, ret = 0; + unsigned int major, minor; + int ret; dev_t dev; dprintk("%s enter \n", __func__);