From patchwork Fri Nov 9 18:45:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Geggus X-Patchwork-Id: 1721611 Return-Path: X-Original-To: patchwork-linux-nfs@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D12D0DF264 for ; Fri, 9 Nov 2012 18:45:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755128Ab2KISpi (ORCPT ); Fri, 9 Nov 2012 13:45:38 -0500 Received: from mail.gnuher.de ([78.47.12.54]:58598 "EHLO mail.gnuher.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754622Ab2KISpi (ORCPT ); Fri, 9 Nov 2012 13:45:38 -0500 Received: from ultimate100.geggus.net ([2a01:198:297:1::1]) by mail.gnuher.de (envelope-from ) with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) id 1TWtaC-0001nX-69 for linux-nfs@vger.kernel.org; Fri, 09 Nov 2012 19:45:36 +0100 Received: from news by ultimate100.geggus.net (envelope-from ) with local (Exim 4.72) id 1TWta9-0006Vz-6I for linux-nfs@vger.kernel.org; Fri, 09 Nov 2012 19:45:33 +0100 To: linux-nfs@vger.kernel.org Path: not-for-mail From: Sven Geggus Subject: Re: Kernel update 3.5.7 -> 3.6.3 breaks NFS4 Date: Fri, 9 Nov 2012 18:45:32 +0000 (UTC) Organization: Geggus clan, virtual section Lines: 54 Message-ID: References: <20121026171549.GA11806@fieldses.org> <20121029094038.GA14836@geggus.net> <20121029150203.GB9502@fieldses.org> <20121105165459.GA2958@geggus.net> NNTP-Posting-Host: diesel.geggus.net Mime-Version: 1.0 X-Trace: ultimate100.geggus.net 1352486732 23892 192.168.3.2 (9 Nov 2012 18:45:32 GMT) X-Complaints-To: usenet@geggus.net NNTP-Posting-Date: Fri, 9 Nov 2012 18:45:32 +0000 (UTC) Cancel-Lock: sha1:SVzPTE3fzYoRWwHnWDTPGjPI5IM= X-TERMINAL: rxvt-unicode X-OS: Debian GNU/Linux (Kernel 3.6.3) User-Agent: tin/2.1.1-20120623 ("Mulindry") (UNIX) (Linux/3.6.3 (x86_64)) X-remote-host: Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Sven Geggus wrote: > OK, I now figured out which commit did cause the problem: > > Thus "git diff 08843b79..cc8362b1" on a linux-stable tree from > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git should > give us the relevant changes. After a private conversation with J. Bruce Fields I figured out that I have not been quite there yet. So here comes a FTR post what exactly caused my problem. It is the following change: $ git diff d9c2ede63c74048dfddbb129c59ac01176b0ab71 bbf43dc888833ac0539e437dbaeb28bfd4fbab9f if (len < 0) @@ -226,11 +224,9 @@ static inline int get_int(char **bpp, int *anint) if (len == 0) return -ENOENT; - rv = simple_strtol(buf, &ep, 0); - if (*ep) + if (kstrtoint(buf, 0, anint)) return -EINVAL; - *anint = rv; return 0; } Reverting this change on recent kernels makes them work for me again. Sven diff --git a/include/linux/sunrpc/cache.h b/include/linux/sunrpc/cache.h index 6def1f6..af42596 100644 --- a/include/linux/sunrpc/cache.h +++ b/include/linux/sunrpc/cache.h @@ -217,8 +217,6 @@ extern int qword_get(char **bpp, char *dest, int bufsize); static inline int get_int(char **bpp, int *anint) { char buf[50]; - char *ep; - int rv; int len = qword_get(bpp, buf, sizeof(buf));