[v5,0/7] ndctl: cxl: add monitor support for trace events

Message

Dave Jiang Nov. 10, 2022, 12:07 a.m. UTC

This patch series for ndctl implements the monitor command for the cxl tool.
The initial implementation will collect CXL trace events emitted by the
kernel. libtraceevent and libtracefs will be used to parse the trace
event buffer. The monitor will pend on an epoll fd and wait for new event
entries to be posted. The output will be in json format. By default the events
are emitted to stdio, but can also be logged to a file. Each event is converted
to a JSON object and logged as such. All the fields exported are read by the
monitor code and added to the JSON object.

v5:
- Remove unneeded header includes. (Vishal)
- Reformat using git clang-format. (Vishal)
- Change uuid string to 40 bytes allocation. (Vishal)
- Change cxl_event_to_json_callback() to cxl_event_to_json(). (Vishal)
- Change cxl_event_parse_cb() to cxl_event_parse(). (Vishal)
- Squash patch 3 & 4. (Vishal)
- Move common logging helper to util/log.c. (Vishal)
- Squash patch 5 & 7. (Vishal)
- Drop Alison's pid patch. (Vishal)
- Fixup man page. (Vishal)

v4:
- Fix num_to_json for less than int size (Ira)
- Use TEP_FIELD flags to determine data type. (Steve)
- Use tracefs_event_enable() instad of directly toggle sysfs via lib calls (Steve)
- Remove tracefs_trace_is_on() in disable() call (Steve)
- Update to use tep_data_pid() (Steve)

v3:
- Change uuid parsing from u8[] to uuid_t (Alison)
- Add event_name to event_ctx for filtering (Alison)
- Add event_pid to event_ctx for filtering (Alison)
- Add parse_event callback to event_ctx for filtering (Alison)

v2:
- Simplify logging functions (Nathan)
- Drop ndctl prefix (Vishal)
- Reduce to single trace event system (Alison)
- Add systemd startup file
- Add man page

---

Dave Jiang (7):
      ndctl: cxl: add helper function to parse trace event to json object
      ndctl: cxl: add helper to parse through all current events
      ndctl: cxl: add common function to enable/disable event trace
      ndctl: move common logging functions from ndctl/monitor.c to util/log.c
      ndctl: cxl: add monitor command for event trace events
      ndctl: cxl: add systemd service for monitor
      ndctl: cxl: add man page documentation for monitor


 Documentation/cxl/cxl-monitor.txt |  62 ++++++++
 Documentation/cxl/meson.build     |   1 +
 cxl/builtin.h                     |   1 +
 cxl/cxl-monitor.service           |   9 ++
 cxl/cxl.c                         |   1 +
 cxl/event_trace.c                 | 251 ++++++++++++++++++++++++++++++
 cxl/event_trace.h                 |  27 ++++
 cxl/meson.build                   |   8 +
 cxl/monitor.c                     | 215 +++++++++++++++++++++++++
 meson.build                       |   3 +
 ndctl.spec.in                     |   1 +
 ndctl/monitor.c                   |  41 +----
 util/log.c                        |  34 ++++
 util/log.h                        |   8 +-
 14 files changed, 624 insertions(+), 38 deletions(-)
 create mode 100644 Documentation/cxl/cxl-monitor.txt
 create mode 100644 cxl/cxl-monitor.service
 create mode 100644 cxl/event_trace.c
 create mode 100644 cxl/event_trace.h
 create mode 100644 cxl/monitor.c

--