| Message ID | 20200820021641.3188-1-thunder.leizhen@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | bugfix and optimize for drivers/nvdimm | expand |
Hi all: Any comment? I want to merge patches 1 and 2 into one, then send other patches separately. On 2020/8/20 10:16, Zhen Lei wrote: > v2 --> v3: > 1. Fix spelling error of patch 1 subject: memmory --> memory > 2. Add "Reviewed-by: Oliver O'Halloran <oohall@gmail.com>" into patch 1 > 3. Rewrite patch descriptions of Patch 1, 3, 4 > 4. Add 3 new trivial patches 5-7, I just found that yesterday. > 5. Unify all "subsystem" names to "libnvdimm:" > > v1 --> v2: > 1. Add Fixes for Patch 1-2 > 2. Slightly change the subject and description of Patch 1 > 3. Add a new trivial Patch 4, I just found that yesterday. > > v1: > I found a memleak when I learned the drivers/nvdimm code today. And I also > added a sanity check for priv->bus_desc.provider_name, because strdup() > maybe failed. Patch 3 is a trivial source code optimization. > > > Zhen Lei (7): > libnvdimm: fix memory leaks in of_pmem.c > libnvdimm: add sanity check for provider_name in > of_pmem_region_probe() > libnvdimm: simplify walk_to_nvdimm_bus() > libnvdimm: reduce an unnecessary if branch in nd_region_create() > libnvdimm: reduce an unnecessary if branch in nd_region_activate() > libnvdimm: make sure EXPORT_SYMBOL_GPL(nvdimm_flush) close to its > function > libnvdimm: slightly simplify available_slots_show() > > drivers/nvdimm/bus.c | 7 +++---- > drivers/nvdimm/dimm_devs.c | 5 ++--- > drivers/nvdimm/of_pmem.c | 7 +++++++ > drivers/nvdimm/region_devs.c | 13 ++++--------- > 4 files changed, 16 insertions(+), 16 deletions(-) >
v2 --> v3: 1. Fix spelling error of patch 1 subject: memmory --> memory 2. Add "Reviewed-by: Oliver O'Halloran <oohall@gmail.com>" into patch 1 3. Rewrite patch descriptions of Patch 1, 3, 4 4. Add 3 new trivial patches 5-7, I just found that yesterday. 5. Unify all "subsystem" names to "libnvdimm:" v1 --> v2: 1. Add Fixes for Patch 1-2 2. Slightly change the subject and description of Patch 1 3. Add a new trivial Patch 4, I just found that yesterday. v1: I found a memleak when I learned the drivers/nvdimm code today. And I also added a sanity check for priv->bus_desc.provider_name, because strdup() maybe failed. Patch 3 is a trivial source code optimization. Zhen Lei (7): libnvdimm: fix memory leaks in of_pmem.c libnvdimm: add sanity check for provider_name in of_pmem_region_probe() libnvdimm: simplify walk_to_nvdimm_bus() libnvdimm: reduce an unnecessary if branch in nd_region_create() libnvdimm: reduce an unnecessary if branch in nd_region_activate() libnvdimm: make sure EXPORT_SYMBOL_GPL(nvdimm_flush) close to its function libnvdimm: slightly simplify available_slots_show() drivers/nvdimm/bus.c | 7 +++---- drivers/nvdimm/dimm_devs.c | 5 ++--- drivers/nvdimm/of_pmem.c | 7 +++++++ drivers/nvdimm/region_devs.c | 13 ++++--------- 4 files changed, 16 insertions(+), 16 deletions(-)