From patchwork Fri Feb 5 22:28:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12071141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4336C433DB for ; Fri, 5 Feb 2021 22:29:28 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D420A64FF0 for ; Fri, 5 Feb 2021 22:29:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D420A64FF0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kleine-koenig.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id B2766100EAAFA; Fri, 5 Feb 2021 14:29:27 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:4f8:c0c:3a97::2; helo=antares.kleine-koenig.org; envelope-from=uwe@kleine-koenig.org; receiver= Received: from antares.kleine-koenig.org (antares.kleine-koenig.org [IPv6:2a01:4f8:c0c:3a97::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7210D100EBBC1 for ; Fri, 5 Feb 2021 14:29:00 -0800 (PST) Received: by antares.kleine-koenig.org (Postfix, from userid 1000) id 21106AEDEF7; Fri, 5 Feb 2021 23:28:57 +0100 (CET) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton Subject: [PATCH v2 0/5] dax-device: Some cleanups Date: Fri, 5 Feb 2021 23:28:37 +0100 Message-Id: <20210205222842.34896-1-uwe@kleine-koenig.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Message-ID-Hash: ULQWUJTRWFA67KG3MVGGNSAGRFZE6EU4 X-Message-ID-Hash: ULQWUJTRWFA67KG3MVGGNSAGRFZE6EU4 X-MailFrom: uwe@kleine-koenig.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Hello, I didn't get any feedback for the (implicit) v1 of this series that started with Message-Id: 20210127230124.109522-1-uwe@kleine-koenig.org, but I identified a few improvements myself: - Use "dax-device" consistently as a prefix - Instead of requiring a .remove callback, make it explicitly optional. (Drop checking for .remove from former patch 1, introduce new patch "Properly handle drivers without remove callback") - The new patch about remove being optional allows to simplify one of the two dax drivers which is implemented in patch 4 - Patch 5 got a bit smaller because we now have one driver less with a remove callback. - Added Andrew to To: as he merged dax drivers in the past. Andrew: Assuming you consider these patches useful, would you please care for merging them? Best regards Uwe Uwe Kleine-König (5): dax-device: Prevent registering drivers without probe callback dax-device: Properly handle drivers without remove callback dax-device: Fix error path in dax_driver_register dax-device: Drop an empty .remove callback dax-device: Make remove callback return void drivers/dax/bus.c | 22 ++++++++++++++++++++-- drivers/dax/bus.h | 2 +- drivers/dax/device.c | 8 +------- drivers/dax/kmem.c | 7 ++----- 4 files changed, 24 insertions(+), 15 deletions(-) base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e