mbox series

[ndctl,v4,0/4] cxl/monitor and ndctl/monitor fixes

Message ID 20230711115344.562823-1-lizhijian@fujitsu.com (mailing list archive)
Headers show
Series cxl/monitor and ndctl/monitor fixes | expand

Message

Zhijian Li (Fujitsu) July 11, 2023, 11:53 a.m. UTC
V4:
  - Add reviewed tags and minor fixes including comment style and
changelog update
  - combine "cxl/monitor: use strcmp to compare the reserved word" and
    "ndctl/monitor: use strcmp to compare the reserved word" to one
    patch
  - Drop "cxl/monitor: always log started message" which would break a
    json output.

V3:
- update comit log of patch3 and patch6 per Dave's comments.

V2:
- exchange order of previous patch1 and patch2
- add reviewed tag in patch5
- commit log improvements

It mainly fix monitor not working when log file is specified. For
example
$ cxl monitor -l ./cxl-monitor.log
It seems that someone missed something at the begining.

Furture, it compares the filename with reserved word more accurately

patch1-2: It re-enables logfile(including default_log) functionality
and simplify the sanity check in the combination relative path file
and daemon mode.

patch3 and patch6 change strncmp to strcmp to compare the acurrate
reserved words.


*** BLURB HERE ***

Li Zhijian (4):
  cxl/monitor: Enable default_log and refactor sanity check
  cxl/monitor: replace monitor.log_file with monitor.ctx.log_file
  ndctl: use strcmp for reserved word in monitor commands
  Documentation/cxl/cxl-monitor.txt: Fix inaccurate description

 Documentation/cxl/cxl-monitor.txt |  3 +--
 cxl/monitor.c                     | 43 ++++++++++++++++---------------
 ndctl/monitor.c                   |  4 +--
 3 files changed, 25 insertions(+), 25 deletions(-)