From patchwork Tue Apr 2 00:17:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ho-Ren (Jack) Chuang" X-Patchwork-Id: 13613192 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC70E556 for ; Tue, 2 Apr 2024 00:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712017066; cv=none; b=HxJEhC3HN878feTi3Tpz4/zaRUXTXn8k4L1JeSK62Hvh9lki0Da3TE/T+PzWfyBhQ5iO2kqognwUAZMD5g+Lxl29T2VxV8p8wfeL+2AEV6bblREjKarjhFtuENAEQ+YJn/BYklfemCa0LgEIIhrxQWSwfYSrPyos4mrXBP1Yb4k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712017066; c=relaxed/simple; bh=SCrDUhEkZxFSPTEl/r8bXpDqiMbz+gOCwj9dhEfB9cc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=CJ+WtqxJBoTZSVqbIfMmOuRtPvDNMawcvup5SmjQLO2HyPh+cOifuzIK3BTEFy9upztwF4EERZxeyxBWav1F2CyV13aeP8osM7ZalXNeS/mUN2x3aka8/+IEXm63CEx8mfHcxDyhDXU0XUep8kerYctfMVrI8AcLjAxA4eZCHUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=R+euSRno; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="R+euSRno" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-69185f093f5so32638056d6.3 for ; Mon, 01 Apr 2024 17:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1712017062; x=1712621862; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gW68csmOvBMTYM9kf5jTmocSt+5Cfpv4k9wOl9BtKJ0=; b=R+euSRnotSRluZQ5tZDlKneKRZZ0OrRjz+eqj+e9q8IfmRBTrtIJEoUjbpA2RAvLWB ahCdCqd5hFummRJHCcX7jyfPRa0O8i724os9EnDgAQhqLKf1q4e2ncO+FDlP53DOvpJE c6aN1hTgg0yQ0t5IR3eLr/Tpnmu/96iXWgRHf3Sb7rDjpHpLJAVq/asopTU/30DUXqZL 4RQ5WP9p/jksWUHvhPIECjoKHoBNi7wOinAtaiaQ6RbmVJNuVE9yR0FdCvK+SyfKXSeT W8qdw5BJoc4gtcJMZCpCsVXKb0bK9AH6pKs383SgZJqFSM9Gge/tpIoie0Qnst0pF3GH QZsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712017062; x=1712621862; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gW68csmOvBMTYM9kf5jTmocSt+5Cfpv4k9wOl9BtKJ0=; b=iBjY2xvKexx1+EODA85Q1UzARmvpgbPy6hroXN7qbGuZT01xJjtjKgAg4G0+q+/idG IoLdyzT9HUmUg6CxE+gj5cqtcS01LTpt9zunHasEKVa4kqhcBBD2N3S3lkHEN5JLUy3p BBcF7TmWcoIbzd2N84wnc6xq32iphLvR1ogtfo/0i539E0RS9Zu2DyHmQKSJ0IPfR8/0 S0TuOr5JnxxprEqR3MmJ3/C3EObKovP/1rQ3fJhBFoNOKs0QyaP6EmzmJzlhEL5kpc4r WbnsBqoGrM9h0NGAiVvilZ1DEre4c2fZG0aq1oeYUuLzKY6NjkhH7mqwR3M3ze2CoBym IBHw== X-Forwarded-Encrypted: i=1; AJvYcCVBZqIkRMgWpEAsAJs0RUFpRTmT65qFGomJfAJF98apkzQkcZG6QuaALl+mLooh2cXwmfQKz1bQrr37defcIWsMtTUn8iwE X-Gm-Message-State: AOJu0Yxijqpnib8bD4bTwi0U8Z9CRHuT579ZWd6K0bvaxqaGH8WiH5hi INxBNXSjdT8pDy3FzUzFUry+CIV/WAN3pAWfTlOh6uoblswOzg+jxEwzZ4qXYCs= X-Google-Smtp-Source: AGHT+IHI1NovuRSzlyW3MYabIw0PVUmZGVgQf3UfVLAx8wFoGSl+V+dNtBDwUZKth1SSmnW9MKt4eA== X-Received: by 2002:a0c:f707:0:b0:699:bbd:7976 with SMTP id w7-20020a0cf707000000b006990bbd7976mr3538796qvn.22.1712017062196; Mon, 01 Apr 2024 17:17:42 -0700 (PDT) Received: from n231-228-171.byted.org ([130.44.212.125]) by smtp.gmail.com with ESMTPSA id e10-20020a0562141d0a00b00698f9771822sm3013112qvd.83.2024.04.01.17.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 17:17:41 -0700 (PDT) From: "Ho-Ren (Jack) Chuang" To: "Huang, Ying" , "Gregory Price" , aneesh.kumar@linux.ibm.com, mhocko@suse.com, tj@kernel.org, john@jagalactic.com, "Eishan Mirakhur" , "Vinicius Tavares Petrucci" , "Ravis OpenSrc" , "Alistair Popple" , "Srinivasulu Thanneeru" , "SeongJae Park" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , "Ho-Ren (Jack) Chuang" , qemu-devel@nongnu.org Subject: [PATCH v10 0/2] Improved Memory Tier Creation for CPUless NUMA Nodes Date: Tue, 2 Apr 2024 00:17:36 +0000 Message-Id: <20240402001739.2521623-1-horenchuang@bytedance.com> X-Mailer: git-send-email 2.20.1 Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When a memory device, such as CXL1.1 type3 memory, is emulated as normal memory (E820_TYPE_RAM), the memory device is indistinguishable from normal DRAM in terms of memory tiering with the current implementation. The current memory tiering assigns all detected normal memory nodes to the same DRAM tier. This results in normal memory devices with different attributions being unable to be assigned to the correct memory tier, leading to the inability to migrate pages between different types of memory. https://lore.kernel.org/linux-mm/PH0PR08MB7955E9F08CCB64F23963B5C3A860A@PH0PR08MB7955.namprd08.prod.outlook.com/T/ This patchset automatically resolves the issues. It delays the initialization of memory tiers for CPUless NUMA nodes until they obtain HMAT information and after all devices are initialized at boot time, eliminating the need for user intervention. If no HMAT is specified, it falls back to using `default_dram_type`. Example usecase: We have CXL memory on the host, and we create VMs with a new system memory device backed by host CXL memory. We inject CXL memory performance attributes through QEMU, and the guest now sees memory nodes with performance attributes in HMAT. With this change, we enable the guest kernel to construct the correct memory tiering for the memory nodes. - v10: Thanks to Andrew's and SeongJae's comments, * Address kunit compilation errors * Resolve the bug of not returning the correct error code in `mt_perf_to_adistance` -v9: * Address corner cases in `memory_tier_late_init`. Thank Ying's comments. * https://lore.kernel.org/lkml/20240329053353.309557-1-horenchuang@bytedance.com/T/#u -v8: * Fix email format * https://lore.kernel.org/lkml/20240329004815.195476-1-horenchuang@bytedance.com/T/#u -v7: * Add Reviewed-by: "Huang, Ying" -v6: Thanks to Ying's comments, * Move `default_dram_perf_lock` to the function's beginning for clarity * Fix double unlocking at v5 * https://lore.kernel.org/lkml/20240327072729.3381685-1-horenchuang@bytedance.com/T/#u -v5: Thanks to Ying's comments, * Add comments about what is protected by `default_dram_perf_lock` * Fix an uninitialized pointer mtype * Slightly shorten the time holding `default_dram_perf_lock` * Fix a deadlock bug in `mt_perf_to_adistance` * https://lore.kernel.org/lkml/20240327041646.3258110-1-horenchuang@bytedance.com/T/#u -v4: Thanks to Ying's comments, * Remove redundant code * Reorganize patches accordingly * https://lore.kernel.org/lkml/20240322070356.315922-1-horenchuang@bytedance.com/T/#u -v3: Thanks to Ying's comments, * Make the newly added code independent of HMAT * Upgrade set_node_memory_tier to support more cases * Put all non-driver-initialized memory types into default_memory_types instead of using hmat_memory_types * find_alloc_memory_type -> mt_find_alloc_memory_type * https://lore.kernel.org/lkml/20240320061041.3246828-1-horenchuang@bytedance.com/T/#u -v2: Thanks to Ying's comments, * Rewrite cover letter & patch description * Rename functions, don't use _hmat * Abstract common functions into find_alloc_memory_type() * Use the expected way to use set_node_memory_tier instead of modifying it * https://lore.kernel.org/lkml/20240312061729.1997111-1-horenchuang@bytedance.com/T/#u -v1: * https://lore.kernel.org/lkml/20240301082248.3456086-1-horenchuang@bytedance.com/T/#u Ho-Ren (Jack) Chuang (2): memory tier: dax/kmem: introduce an abstract layer for finding, allocating, and putting memory types memory tier: create CPUless memory tiers after obtaining HMAT info drivers/dax/kmem.c | 20 +----- include/linux/memory-tiers.h | 14 ++++ mm/memory-tiers.c | 127 ++++++++++++++++++++++++++++++----- 3 files changed, 126 insertions(+), 35 deletions(-)