From patchwork Wed Nov 25 01:00:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhiqiang Liu X-Patchwork-Id: 11930031 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_40, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C625FC56202 for ; Wed, 25 Nov 2020 01:00:47 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 243BB21534 for ; Wed, 25 Nov 2020 01:00:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 243BB21534 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 85E86100EF24E; Tue, 24 Nov 2020 17:00:46 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=45.249.212.191; helo=szxga05-in.huawei.com; envelope-from=liuzhiqiang26@huawei.com; receiver= Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2008F100EF24C for ; Tue, 24 Nov 2020 17:00:41 -0800 (PST) Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CgjH02PJpzLm69; Wed, 25 Nov 2020 09:00:12 +0800 (CST) Received: from [127.0.0.1] (10.174.176.238) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Nov 2020 09:00:29 +0800 To: "Verma, Vishal L" From: Zhiqiang Liu Subject: [ndctl PATCH V2 0/8] fix serverl issues reported by Coverity Message-ID: <3211fe8a-33fb-37ca-e192-ad1f116f4acd@huawei.com> Date: Wed, 25 Nov 2020 09:00:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Content-Language: en-US X-Originating-IP: [10.174.176.238] X-CFilter-Loop: Reflected Message-ID-Hash: LWMV67ZGXG6X3C6B2VZLY66BJX4BFHJH X-Message-ID-Hash: LWMV67ZGXG6X3C6B2VZLY66BJX4BFHJH X-MailFrom: liuzhiqiang26@huawei.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "linux-nvdimm@lists.01.org" , linfeilong , liuzhiqiang26@huawei.com X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Changes: V1->V2 - add one empty line in 1/8 patch as suggested by Jeff Moyer . Recently, we use Coverity to analysis the ndctl package. Several issues should be resolved to make Coverity happy. Zhiqiang Liu (8): namespace: check whether pfn|dax|btt is NULL in setup_namespace lib/libndctl: fix memory leakage problem in add_bus libdaxctl: fix memory leakage in add_dax_region() dimm: fix potential fd leakage in dimm_action() util/help: check whether strdup returns NULL in exec_man_konqueror lib/inject: check whether cmd is created successfully libndctl: check whether ndctl_btt_get_namespace returns NULL in callers namespace: check whether seed is NULL in validate_namespace_options daxctl/lib/libdaxctl.c | 3 +++ ndctl/dimm.c | 12 +++++++----- ndctl/lib/inject.c | 8 ++++++++ ndctl/lib/libndctl.c | 1 + ndctl/namespace.c | 23 ++++++++++++++++++----- test/libndctl.c | 16 +++++++++++----- test/parent-uuid.c | 2 +- util/help.c | 8 +++++++- util/json.c | 3 +++ 9 files changed, 59 insertions(+), 17 deletions(-)