mbox series

[0/2] nvdimm: Convert to platform remove callback returning void

Message ID cover.1712756722.git.u.kleine-koenig@pengutronix.de (mailing list archive)
Headers show
Series nvdimm: Convert to platform remove callback returning void | expand

Message

Uwe Kleine-König April 10, 2024, 1:47 p.m. UTC
Hello,

this series converts all platform drivers below drivers/nvdimm/ to not
use struct platform_device::remove() any more. See commit 5c5a7680e67b
("platform: Provide a remove callback that returns no value") for an
extended explanation and the eventual goal.

All conversations are trivial, because the driver's .remove() callbacks
returned zero unconditionally.

There are no interdependencies between these patches, so they can be
applied independently if needed. This is merge window material.

Best regards
Uwe

Uwe Kleine-König (2):
  nvdimm/e820: Convert to platform remove callback returning void
  nvdimm/of_pmem: Convert to platform remove callback returning void

 drivers/nvdimm/e820.c    | 5 ++---
 drivers/nvdimm/of_pmem.c | 6 ++----
 2 files changed, 4 insertions(+), 7 deletions(-)

base-commit: 6ebf211bb11dfc004a2ff73a9de5386fa309c430

Comments

Dave Jiang April 10, 2024, 3:33 p.m. UTC | #1
On 4/10/24 6:47 AM, Uwe Kleine-König wrote:
> Hello,
> 
> this series converts all platform drivers below drivers/nvdimm/ to not
> use struct platform_device::remove() any more. See commit 5c5a7680e67b
> ("platform: Provide a remove callback that returns no value") for an
> extended explanation and the eventual goal.
> 
> All conversations are trivial, because the driver's .remove() callbacks
> returned zero unconditionally.
> 
> There are no interdependencies between these patches, so they can be
> applied independently if needed. This is merge window material.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (2):
>   nvdimm/e820: Convert to platform remove callback returning void
>   nvdimm/of_pmem: Convert to platform remove callback returning void
> 
>  drivers/nvdimm/e820.c    | 5 ++---
>  drivers/nvdimm/of_pmem.c | 6 ++----
>  2 files changed, 4 insertions(+), 7 deletions(-)
> 
> base-commit: 6ebf211bb11dfc004a2ff73a9de5386fa309c430

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

for the series
Uwe Kleine-König April 29, 2024, 7:33 a.m. UTC | #2
Hello,

On Wed, Apr 10, 2024 at 03:47:32PM +0200, Uwe Kleine-König wrote:
> this series converts all platform drivers below drivers/nvdimm/ to not
> use struct platform_device::remove() any more. See commit 5c5a7680e67b
> ("platform: Provide a remove callback that returns no value") for an
> extended explanation and the eventual goal.
> 
> All conversations are trivial, because the driver's .remove() callbacks
> returned zero unconditionally.
> 
> There are no interdependencies between these patches, so they can be
> applied independently if needed. This is merge window material.

I intend to send the change adapting the prototype of struct
platform_device::remove() soon after the upcoming merge window closed.
So it would be great if these two patches made it in before. If not,
I'll ask Greg to take these patches together with the change to struct
platform_device.

Best regards
Uwe