From patchwork Fri Apr 22 19:47:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 8915391 Return-Path: X-Original-To: patchwork-linux-nvdimm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 51849BF29F for ; Fri, 22 Apr 2016 19:48:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 758DB2021B for ; Fri, 22 Apr 2016 19:48:19 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78CBB20212 for ; Fri, 22 Apr 2016 19:48:18 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 6E97A1A20D1; Fri, 22 Apr 2016 12:48:18 -0700 (PDT) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ml01.01.org (Postfix) with ESMTP id A407D1A20D1 for ; Fri, 22 Apr 2016 12:48:17 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 22 Apr 2016 12:48:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,518,1455004800"; d="scan'208";a="950970650" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.14]) by fmsmga001.fm.intel.com with ESMTP; 22 Apr 2016 12:48:17 -0700 Subject: [ndctl PATCH 5/8] ndctl, xaction-namespace: make 'verbose' option available in all sub-commands From: Dan Williams To: linux-nvdimm@lists.01.org Date: Fri, 22 Apr 2016 12:47:28 -0700 Message-ID: <146135444838.4228.16562355726281815141.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <146135442234.4228.904225076597683142.stgit@dwillia2-desk3.amr.corp.intel.com> References: <146135442234.4228.904225076597683142.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.17.1-9-g687f MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Rather than limiting the -v option to create-namespace, enable it for all xaction-namespace commands i.e. {enable, disable, create, destroy}-namespace. Signed-off-by: Dan Williams --- Documentation/ndctl-destroy-namespace.txt | 5 +++++ Documentation/xable-namespace-options.txt | 4 ++++ builtin-xaction-namespace.c | 6 +++--- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/ndctl-destroy-namespace.txt b/Documentation/ndctl-destroy-namespace.txt index 623820533cec..ea6d2856107a 100644 --- a/Documentation/ndctl-destroy-namespace.txt +++ b/Documentation/ndctl-destroy-namespace.txt @@ -22,6 +22,11 @@ include::xable-namespace-options.txt[] Specifying --force causes the namespace to be disabled before the operation is attempted. +-v:: +--verbose:: + Emit debug messages for the namespace destruction operation + + SEE ALSO -------- linkndctl:ndctl-create-namespace[1] diff --git a/Documentation/xable-namespace-options.txt b/Documentation/xable-namespace-options.txt index a5c876180c91..cb24c2d61328 100644 --- a/Documentation/xable-namespace-options.txt +++ b/Documentation/xable-namespace-options.txt @@ -6,3 +6,7 @@ the operation on every namespace in the system, optionally filtered by region -r:: --region=:: include::xable-region-options.txt[] + +-v:: +--verbose:: + Emit debug messages for the namespace operation diff --git a/builtin-xaction-namespace.c b/builtin-xaction-namespace.c index e2e6d518c64d..23b38ad0b73b 100644 --- a/builtin-xaction-namespace.c +++ b/builtin-xaction-namespace.c @@ -71,7 +71,8 @@ struct parsed_parameters { OPT_STRING('b', "bus", ¶m.bus, "bus-id", \ "limit namespace to a bus with an id or provider of "), \ OPT_STRING('r', "region", ¶m.region, "region-id", \ - "limit namespace to a region with an id or name of ") + "limit namespace to a region with an id or name of "), \ +OPT_BOOLEAN('v', "verbose", &verbose, "emit extra debug messages to stderr") #define CREATE_OPTIONS() \ OPT_STRING('e', "reconfig", ¶m.reconfig, "reconfig namespace", \ @@ -90,8 +91,7 @@ OPT_STRING('l', "sector-size", ¶m.sector_size, "lba-size", \ "specify the logical sector size in bytes"), \ OPT_STRING('t', "type", ¶m.type, "type", \ "specify the type of namespace to create 'pmem' or 'blk'"), \ -OPT_BOOLEAN('f', "force", &force, "reconfigure namespace even if currently active"), \ -OPT_BOOLEAN('v', "verbose", &verbose, "emit extra debug messages to stderr") +OPT_BOOLEAN('f', "force", &force, "reconfigure namespace even if currently active") static const struct option base_options[] = { BASE_OPTIONS(),