From patchwork Sat Feb 10 05:23:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 10210319 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2649A60247 for ; Sat, 10 Feb 2018 05:32:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E64C29949 for ; Sat, 10 Feb 2018 05:32:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 11F192994F; Sat, 10 Feb 2018 05:32:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C30E629949 for ; Sat, 10 Feb 2018 05:32:56 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id B2F9B222DE126; Fri, 9 Feb 2018 21:27:09 -0800 (PST) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=dan.j.williams@intel.com; receiver=linux-nvdimm@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D6908223DB799 for ; Fri, 9 Feb 2018 21:27:07 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2018 21:32:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,487,1511856000"; d="scan'208";a="33599680" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by orsmga002.jf.intel.com with ESMTP; 09 Feb 2018 21:32:53 -0800 Subject: [ndctl PATCH] ndctl, firmware: fix kernel version check From: Dan Williams To: linux-nvdimm@lists.01.org Date: Fri, 09 Feb 2018 21:23:48 -0800 Message-ID: <151824022875.4967.15665172528794072137.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.17.1-9-g687f MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Virus-Scanned: ClamAV using ClamSMTP The firmware update passes when it should skip due to a misplaced newline. Cc: Dave Jiang Signed-off-by: Dan Williams --- test/firmware-update.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/firmware-update.sh b/test/firmware-update.sh index 79767d2dc41f..0d5bcdb3cc42 100755 --- a/test/firmware-update.sh +++ b/test/firmware-update.sh @@ -53,8 +53,7 @@ do_tests() $ndctl update-firmware -d $dev -f $image } -check_min_kver "4.16" || { echo "kernel $KVER may lack firmware update test handling"; exit -$rc; } +check_min_kver "4.16" || { echo "kernel $KVER may lack firmware update test handling"; exit $rc; } modprobe nfit_test rc=1 reset