diff mbox

ndctl: fix ndctl_persistence_domain declaration

Message ID 1523021334-9976-1-git-send-email-lukasz.plewa@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lukasz Plewa April 6, 2018, 1:28 p.m. UTC
From: Łukasz Plewa <lukasz.plewa@intel.com>

the declaration of ndctl_persistence_domain should be above first use
of this enum

Reported-by: Kamil Diedrich <kamil.diedrich@intel.com>
Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
---
 ndctl/libndctl.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Dan Williams April 6, 2018, 2:40 p.m. UTC | #1
On Fri, Apr 6, 2018 at 6:28 AM,  <lukasz.plewa@intel.com> wrote:
> From: Łukasz Plewa <lukasz.plewa@intel.com>
>
> the declaration of ndctl_persistence_domain should be above first use
> of this enum
>
> Reported-by: Kamil Diedrich <kamil.diedrich@intel.com>
> Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
> ---
>  ndctl/libndctl.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Verma, Vishal L April 6, 2018, 9:39 p.m. UTC | #2
On Fri, 2018-04-06 at 07:40 -0700, Dan Williams wrote:
> On Fri, Apr 6, 2018 at 6:28 AM,  <lukasz.plewa@intel.com> wrote:

> > From: Łukasz Plewa <lukasz.plewa@intel.com>

> > 

> > the declaration of ndctl_persistence_domain should be above first use

> > of this enum

> > 

> > Reported-by: Kamil Diedrich <kamil.diedrich@intel.com>

> > Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>

> > ---

> >  ndctl/libndctl.h | 14 +++++++-------

> >  1 file changed, 7 insertions(+), 7 deletions(-)

> 

> Looks good,

> 

> Reviewed-by: Dan Williams <dan.j.williams@intel.com>


Thanks, applied.
> _______________________________________________

> Linux-nvdimm mailing list

> Linux-nvdimm@lists.01.org

> https://lists.01.org/mailman/listinfo/linux-nvdimm
diff mbox

Patch

diff --git a/ndctl/libndctl.h b/ndctl/libndctl.h
index cf6a77f..684fcd4 100644
--- a/ndctl/libndctl.h
+++ b/ndctl/libndctl.h
@@ -97,6 +97,13 @@  void ndctl_set_log_priority(struct ndctl_ctx *ctx, int priority);
 void ndctl_set_userdata(struct ndctl_ctx *ctx, void *userdata);
 void *ndctl_get_userdata(struct ndctl_ctx *ctx);
 
+enum ndctl_persistence_domain {
+	PERSISTENCE_NONE = 0,
+	PERSISTENCE_MEM_CTRL = 10,
+	PERSISTENCE_CPU_CACHE = 20,
+	PERSISTENCE_UNKNOWN = INT_MAX,
+};
+
 struct ndctl_bus;
 struct ndctl_bus *ndctl_bus_get_first(struct ndctl_ctx *ctx);
 struct ndctl_bus *ndctl_bus_get_next(struct ndctl_bus *bus);
@@ -309,13 +316,6 @@  struct badblock {
 	unsigned int len;
 };
 
-enum ndctl_persistence_domain {
-	PERSISTENCE_NONE = 0,
-	PERSISTENCE_MEM_CTRL = 10,
-	PERSISTENCE_CPU_CACHE = 20,
-	PERSISTENCE_UNKNOWN = INT_MAX,
-};
-
 struct ndctl_region;
 struct ndctl_region *ndctl_region_get_first(struct ndctl_bus *bus);
 struct ndctl_region *ndctl_region_get_next(struct ndctl_region *region);